fix: harden diagnostics persistence and update downloads

This commit is contained in:
Sucukdeluxe
2026-08-31 01:52:11 +02:00
parent 9fa979fb4d
commit 50f04b2761
8 changed files with 1718 additions and 248 deletions
+14 -3
View File
@@ -102,7 +102,14 @@ Diese Datei hält den verifizierten technischen Arbeitsstand fest. Sie enthält
- Das Hauptfenster ist unter Windows nun ausdrücklich Besitzer des App-Lebenszyklus: Nach einem natürlichen, vom Renderer bestätigten Schließen wird der kontrollierte Shutdown auch bei verbleibenden Providerfenstern gestartet. Der normale `beforeunload`-Pfad bleibt erhalten, damit noch nicht übertragene Linksammler-Änderungen synchron gesichert werden können. - Das Hauptfenster ist unter Windows nun ausdrücklich Besitzer des App-Lebenszyklus: Nach einem natürlichen, vom Renderer bestätigten Schließen wird der kontrollierte Shutdown auch bei verbleibenden Providerfenstern gestartet. Der normale `beforeunload`-Pfad bleibt erhalten, damit noch nicht übertragene Linksammler-Änderungen synchron gesichert werden können.
- `second-instance` und `activate` stellen ein vorhandenes Hauptfenster wieder her oder erzeugen ein fehlendes neu. Ein Start während eines bereits laufenden Shutdowns plant genau einen Relaunch nach dem Prozessende ein. - `second-instance` und `activate` stellen ein vorhandenes Hauptfenster wieder her oder erzeugen ein fehlendes neu. Ein Start während eines bereits laufenden Shutdowns plant genau einen Relaunch nach dem Prozessende ein.
- Der Shutdown besitzt einen äußeren 10-Sekunden-Wächter. Nach erfolgreichem Controller-Shutdown wird weiterhin normal mit `app.quit()` beendet; blockieren Renderer- oder Providerfenster diesen letzten Schritt, erzwingt ein separater 2-Sekunden-Wächter den Exit. `shutdownDaemon()` läuft im Graceful-Pfad erst nach `controller.shutdown()`. - Der Shutdown besitzt einen äußeren 10-Sekunden-Wächter. Nach erfolgreichem Controller-Shutdown wird weiterhin normal mit `app.quit()` beendet; blockieren Renderer- oder Providerfenster diesen letzten Schritt, erzwingt ein separater 2-Sekunden-Wächter den Exit. `shutdownDaemon()` läuft im Graceful-Pfad erst nach `controller.shutdown()`.
- Die Änderung ist nur auf dem Arbeitsbranch implementiert und getestet. Sie wurde weder veröffentlicht noch auf dem Server installiert; dafür ist eine neue ausdrückliche Release-/Deployment-Freigabe erforderlich. - Der Debug-Server serialisiert Start, Stop und Restart. Gleichzeitige Restarts können keinen unverwalteten Listener mehr hinterlassen, wartende Restarts können einen Stop nicht mehr überholen und ein Stop während des Socket-Starts löst die Lifecycle-Queue zuverlässig auf.
- Settings- und Session-Recovery unterscheiden jetzt gültige leere Zustände von JSON-gültigen, aber unbrauchbaren Strukturen. Eine absichtlich leere Session bleibt maßgeblich; beschädigte Settings-/Session-Primärdateien fallen auf ein intaktes Backup zurück. Sparse historische Settings bleiben kompatibel, und eine fehlende Settings-Primärdatei wird aus dem Backup repariert.
- Das sichere Crash-Journal für ausstehende Hoster-Metadaten-Umbenennungen bleibt über einen Neustart erhalten. Nur absolute echte Unterpfade des Paketausgabeordners werden übernommen; fremde, relative oder mit dem Ausgabeordner identische Pfade werden verworfen.
- Asynchrone Settings- und Session-Saves lösen ihre Promises erst nach dem zugehörigen dauerhaften Schreibvorgang auf und propagieren Fehler. Coalescing, Drain-Ende, Importbarriere und Replay warten auch bei Fehlern auf alle gestarteten Writes; verlorene Wakeups, hängende Barrieren, still verworfene Saves und falsch erfolgreiche Waiter wurden mit Race-Regressionen abgedeckt.
- Der Updater beendet Backpressure-, Shutdown- und Idle-Wartezustände auch bei Schreibfehlern zuverlässig. Er wartet vor dem Rename auf den tatsächlichen Dateistream-Close, propagiert späte Close-Fehler, hält die Fehlerabsicherung bis `close` aktiv und blockiert bei einem nie auflösenden Response-`cancel()` nicht mehr dauerhaft.
- Die übergroßen Updater-Test-Fixtures wurden durch gleichwertige 128-KiB-MZ-Payloads ersetzt, damit Integritäts- und Fallback-Tests unter paralleler Last nicht an Vitests 5-Sekunden-Grenze flaken.
- Die Entpacklogik und ihre Produktionspfade wurden nicht verändert.
- Die Änderungen sind nur auf dem Arbeitsbranch implementiert und getestet. Sie wurden weder veröffentlicht noch auf dem Server installiert; dafür ist eine neue ausdrückliche Release-/Deployment-Freigabe erforderlich.
## Start-, Build- und Testbefehle ## Start-, Build- und Testbefehle
@@ -152,6 +159,10 @@ npm exec -- tsc --noEmit
- Vollständiger Client-Lauf ohne den privilegierten Symlink-Metadatentest: 138 Testdateien erfolgreich, 1 JVM-Testdatei übersprungen; 2.609 Tests erfolgreich und 4 übersprungen. Ein unter paralleler Build-Last einmal auffälliger, fachfremder Ordner-Aufräumtest war anschließend dreimal isoliert und im vollständigen Wiederholungslauf erfolgreich. - Vollständiger Client-Lauf ohne den privilegierten Symlink-Metadatentest: 138 Testdateien erfolgreich, 1 JVM-Testdatei übersprungen; 2.609 Tests erfolgreich und 4 übersprungen. Ein unter paralleler Build-Last einmal auffälliger, fachfremder Ordner-Aufräumtest war anschließend dreimal isoliert und im vollständigen Wiederholungslauf erfolgreich.
- `public-release-metadata.test.ts` separat: 22 von 24 erfolgreich. Die zwei übrigen Fälle scheitern weiterhin ausschließlich beim Anlegen ihrer Symlink-Fixtures mit Windows-`EPERM`, bevor die Produktassertion ausgeführt wird. - `public-release-metadata.test.ts` separat: 22 von 24 erfolgreich. Die zwei übrigen Fälle scheitern weiterhin ausschließlich beim Anlegen ihrer Symlink-Fixtures mit Windows-`EPERM`, bevor die Produktassertion ausgeführt wird.
- Nach dem Lifecycle-Fix erneut erfolgreich: TypeScript, vollständiger Main-/Renderer-Build, Self-Check und 16 von 16 Backup-API-Tests. Die bekannte Vite-Warnung zum rund 574 KiB großen Renderer-Chunk bleibt bestehen. - Nach dem Lifecycle-Fix erneut erfolgreich: TypeScript, vollständiger Main-/Renderer-Build, Self-Check und 16 von 16 Backup-API-Tests. Die bekannte Vite-Warnung zum rund 574 KiB großen Renderer-Chunk bleibt bestehen.
- Gezielte finale Regressionen: Storage und Session-Restart 141 von 141, Updater 40 von 40 und Debug-Server 18 von 18 erfolgreich.
- Finaler vollständiger Client-Lauf ohne den privilegierten Symlink-Metadatentest: 138 Testdateien erfolgreich, 1 JVM-Testdatei übersprungen; 2.640 Tests erfolgreich und 4 übersprungen.
- Der erste vollständige Lauf dieser Änderung hatte bei 2.639 erfolgreichen Tests genau einen 5-Sekunden-Timeout in einer Updater-Testfixture mit der 88,5-MiB-Node-EXE. Nach dem Ersatz aller reinen MZ-Fixtures durch 128-KiB-Payloads war der vollständige Wiederholungslauf grün.
- Nach allen finalen Korrekturen erneut erfolgreich: TypeScript, vollständiger Main-/Renderer-Build, Self-Check und 16 von 16 Backup-API-Tests. Die bekannte Vite-Warnung zum rund 574 KiB großen Renderer-Chunk bleibt bestehen.
## Bekannte Probleme und Risiken ## Bekannte Probleme und Risiken
@@ -165,11 +176,11 @@ npm exec -- tsc --noEmit
- Der Renderer-Bundle-Chunk liegt über Vites 500-KiB-Warnschwelle. - Der Renderer-Bundle-Chunk liegt über Vites 500-KiB-Warnschwelle.
- Die Shutdown-Wächter können einen vollständig synchron blockierten Main-Thread nicht präemptieren. Im äußersten Fall beträgt die kombinierte Grenze knapp 12 Sekunden: bis zu 10 Sekunden Controller-Shutdown plus 2 Sekunden Quit-Bestätigung. - Die Shutdown-Wächter können einen vollständig synchron blockierten Main-Thread nicht präemptieren. Im äußersten Fall beträgt die kombinierte Grenze knapp 12 Sekunden: bis zu 10 Sekunden Controller-Shutdown plus 2 Sekunden Quit-Bestätigung.
- Beim erzwungenen Exit können letzte asynchrone Logzeilen oder Benachrichtigungen fehlen; die wesentlichen Queue-, Settings-, Statistik- und Collector-Daten werden zuvor synchron gesichert. Laufende externe Extraktions-/Remux-Prozesse bleiben ein separater späterer Härtungspunkt. - Beim erzwungenen Exit können letzte asynchrone Logzeilen oder Benachrichtigungen fehlen; die wesentlichen Queue-, Settings-, Statistik- und Collector-Daten werden zuvor synchron gesichert. Laufende externe Extraktions-/Remux-Prozesse bleiben ein separater späterer Härtungspunkt.
- Der Start-/Beenden-Fix ist noch nicht veröffentlicht oder auf dem Server installiert. Bis zu einer ausdrücklich freigegebenen Auslieferung läuft dort weiterhin die bisherige Version. - Die aktuellen Lifecycle-, Debug-Server-, Persistenz- und Updater-Fixes sind noch nicht veröffentlicht oder auf dem Server installiert. Bis zu einer ausdrücklich freigegebenen Auslieferung läuft dort weiterhin die bisherige Version.
## Nächste sinnvolle Schritte ## Nächste sinnvolle Schritte
1. Für eine Auslieferung des Start-/Beenden-Fixes zuerst Stand, Ziel, Tests und Rollback-Weg nennen und Saschas ausdrückliches Release-/Deployment-Go abwarten. 1. Für eine Auslieferung der aktuellen Fehlerkorrekturen zuerst Stand, Ziel, Tests und Rollback-Weg nennen und Saschas ausdrückliches Release-/Deployment-Go abwarten.
2. Nach einer freigegebenen Serverinstallation den Ablauf Real-Debrid-Web-Download, Hauptfenster schließen und unmittelbar neu starten am echten Zielsystem verifizieren; vor jedem Eingriff Prozessbaum und Logtail sichern. 2. Nach einer freigegebenen Serverinstallation den Ablauf Real-Debrid-Web-Download, Hauptfenster schließen und unmittelbar neu starten am echten Zielsystem verifizieren; vor jedem Eingriff Prozessbaum und Logtail sichern.
3. Sicherheitsabhängigkeiten in einem separaten Upgrade-Branch aktualisieren, Electron-/Vite-/Vitest-Major-Wechsel einzeln testen und danach den vollständigen Windows-Paketpfad prüfen. 3. Sicherheitsabhängigkeiten in einem separaten Upgrade-Branch aktualisieren, Electron-/Vite-/Vitest-Major-Wechsel einzeln testen und danach den vollständigen Windows-Paketpfad prüfen.
4. Eine nichtdestruktive Strategie zur Bereinigung der divergierenden `main`-Branches abstimmen; kein Force-Push ohne ausdrückliche Freigabe. 4. Eine nichtdestruktive Strategie zur Bereinigung der divergierenden `main`-Branches abstimmen; kein Force-Push ohne ausdrückliche Freigabe.
+83 -26
View File
@@ -76,6 +76,9 @@ let runtimeBaseDir = "";
let allowlist: string[] = []; let allowlist: string[] = [];
let requestLimits = new Map<string, { startedAt: number; count: number }>(); let requestLimits = new Map<string, { startedAt: number; count: number }>();
let notificationStatusProvider: (() => NotificationSupportPayload) | null = null; let notificationStatusProvider: (() => NotificationSupportPayload) | null = null;
let serverLifecycleQueue: Promise<void> = Promise.resolve();
let serverLifecycleGeneration = 0;
let debugServerEnabled = false;
export interface DebugServerRuntimeStatus { export interface DebugServerRuntimeStatus {
running: boolean; running: boolean;
@@ -1177,6 +1180,12 @@ function openServerSocket(): Promise<void> {
resolve(); resolve();
} }
}; };
srv.once("close", () => {
if (server === srv) {
server = null;
}
settle();
});
srv.on("error", (err: NodeJS.ErrnoException) => { srv.on("error", (err: NodeJS.ErrnoException) => {
if (err.code === "EADDRINUSE") { if (err.code === "EADDRINUSE") {
logger.warn(`Debug-Server: Port ${bindPort} belegt (EADDRINUSE) - Server nicht gestartet`); logger.warn(`Debug-Server: Port ${bindPort} belegt (EADDRINUSE) - Server nicht gestartet`);
@@ -1196,6 +1205,46 @@ function openServerSocket(): Promise<void> {
}); });
} }
function enqueueServerLifecycle(operation: () => Promise<void>): Promise<void> {
const pending = serverLifecycleQueue.then(operation, operation);
serverLifecycleQueue = pending.catch(() => undefined);
return pending;
}
function closeServerSocket(): Promise<void> {
const current = server;
if (!current) {
return Promise.resolve();
}
server = null;
return new Promise((resolve) => {
let settled = false;
let timeout: NodeJS.Timeout | null = null;
const done = (): void => {
if (settled) {
return;
}
settled = true;
if (timeout) {
clearTimeout(timeout);
}
resolve();
};
try {
current.close(() => done());
} catch {
done();
}
try {
current.closeAllConnections?.();
} catch {
}
if (!settled) {
timeout = setTimeout(done, 1500);
}
});
}
export function startDebugServer( export function startDebugServer(
mgr: DownloadManager, mgr: DownloadManager,
baseDir: string, baseDir: string,
@@ -1204,30 +1253,32 @@ export function startDebugServer(
runtimeBaseDir = baseDir; runtimeBaseDir = baseDir;
manager = mgr; manager = mgr;
notificationStatusProvider = readCurrentNotificationStatus || null; notificationStatusProvider = readCurrentNotificationStatus || null;
void openServerSocket(); debugServerEnabled = true;
const generation = ++serverLifecycleGeneration;
void enqueueServerLifecycle(async () => {
if (!debugServerEnabled || generation !== serverLifecycleGeneration) {
return;
}
await closeServerSocket();
if (!debugServerEnabled || generation !== serverLifecycleGeneration) {
return;
}
await openServerSocket();
});
} }
export async function restartDebugServer(): Promise<DebugServerRuntimeStatus> { export async function restartDebugServer(): Promise<DebugServerRuntimeStatus> {
const old = server; const generation = serverLifecycleGeneration;
if (old) { await enqueueServerLifecycle(async () => {
server = null; if (!debugServerEnabled || generation !== serverLifecycleGeneration) {
await new Promise<void>((resolve) => { return;
let settled = false; }
const done = (): void => { await closeServerSocket();
if (!settled) { if (!debugServerEnabled || generation !== serverLifecycleGeneration) {
settled = true; return;
resolve(); }
} await openServerSocket();
}; });
old.close(() => done());
try {
old.closeAllConnections?.();
} catch {
}
setTimeout(done, 1500);
});
}
await openServerSocket();
return getDebugServerRuntimeStatus(); return getDebugServerRuntimeStatus();
} }
@@ -1273,15 +1324,21 @@ export function clearDebugToken(): void {
} }
export function stopDebugServer(): void { export function stopDebugServer(): void {
debugServerEnabled = false;
serverLifecycleGeneration += 1;
notificationStatusProvider = null; notificationStatusProvider = null;
if (server) { const current = server;
server.close(); server = null;
requestLimits = new Map();
if (current) {
try { try {
server.closeAllConnections?.(); current.close();
} catch {
}
try {
current.closeAllConnections?.();
} catch { } catch {
} }
server = null;
requestLimits = new Map();
logger.info("Debug-Server gestoppt"); logger.info("Debug-Server gestoppt");
} }
} }
+288 -79
View File
@@ -86,6 +86,20 @@ function normalizeSessionTargetPath(value: unknown, packageOutputDir: string): s
return path.resolve(targetPath); return path.resolve(targetPath);
} }
function normalizeSessionMetadataRenameTargetPath(value: unknown, packageOutputDir: string): string {
if (!path.isAbsolute(packageOutputDir)) {
return "";
}
const targetPath = normalizeSessionTargetPath(value, packageOutputDir);
if (!targetPath) {
return "";
}
const resolvedOutputDir = path.resolve(packageOutputDir);
const normalizedTargetPath = process.platform === "win32" ? targetPath.toLowerCase() : targetPath;
const normalizedOutputDir = process.platform === "win32" ? resolvedOutputDir.toLowerCase() : resolvedOutputDir;
return normalizedTargetPath === normalizedOutputDir ? "" : targetPath;
}
function clampNumber(value: unknown, fallback: number, min: number, max: number): number { function clampNumber(value: unknown, fallback: number, min: number, max: number): number {
const num = Number(value); const num = Number(value);
if (!Number.isFinite(num)) { if (!Number.isFinite(num)) {
@@ -910,6 +924,13 @@ function migrateLegacyMegaEnableFlags(parsed: AppSettings): AppSettings {
return { ...parsed, megaDebridApiEnabled: preferApi, megaDebridWebEnabled: !preferApi }; return { ...parsed, megaDebridApiEnabled: preferApi, megaDebridWebEnabled: !preferApi };
} }
const PERSISTED_SETTINGS_KEYS = new Set(Object.keys(defaultSettings()));
function isPersistedSettingsEnvelope(value: unknown): boolean {
const parsed = asRecord(value);
return Boolean(parsed && Object.keys(parsed).some((key) => PERSISTED_SETTINGS_KEYS.has(key)));
}
interface LoadedSettingsFile { interface LoadedSettingsFile {
settings: AppSettings; settings: AppSettings;
needsCredentialRewrite: boolean; needsCredentialRewrite: boolean;
@@ -917,7 +938,12 @@ interface LoadedSettingsFile {
function readSettingsFile(filePath: string): LoadedSettingsFile | null { function readSettingsFile(filePath: string): LoadedSettingsFile | null {
try { try {
const parsed = JSON.parse(fs.readFileSync(filePath, "utf8")) as AppSettings; const raw = JSON.parse(fs.readFileSync(filePath, "utf8")) as unknown;
if (!isPersistedSettingsEnvelope(raw)) {
logger.error(`Settings-Datei beschädigt (Struktur ungültig): ${filePath}`);
return null;
}
const parsed = raw as AppSettings;
const needsCredentialRewrite = needsPersistedSettingsRewrite(parsed); const needsCredentialRewrite = needsPersistedSettingsRewrite(parsed);
const restored = restorePersistedSettings(parsed); const restored = restorePersistedSettings(parsed);
const migratedLanguage = (restored as Partial<AppSettings>).language === undefined ? "de" : restored.language; const migratedLanguage = (restored as Partial<AppSettings>).language === undefined ? "de" : restored.language;
@@ -1004,6 +1030,7 @@ export function normalizeLoadedSession(raw: unknown): SessionState {
progressPercent: clampNumber(item.progressPercent, 0, 0, 100), progressPercent: clampNumber(item.progressPercent, 0, 0, 100),
fileName: asText(item.fileName) || "download.bin", fileName: asText(item.fileName) || "download.bin",
targetPath: asText(item.targetPath), targetPath: asText(item.targetPath),
metadataRenameTargetPath: asText(item.metadataRenameTargetPath) || undefined,
resumable: item.resumable === undefined ? true : Boolean(item.resumable), resumable: item.resumable === undefined ? true : Boolean(item.resumable),
attempts: clampNumber(item.attempts, 0, 0, 10_000), attempts: clampNumber(item.attempts, 0, 0, 10_000),
lastError: asText(item.lastError), lastError: asText(item.lastError),
@@ -1084,6 +1111,7 @@ export function normalizeLoadedSession(raw: unknown): SessionState {
} }
let droppedUnsafeTargetPathCount = 0; let droppedUnsafeTargetPathCount = 0;
let droppedUnsafeMetadataRenameTargetPathCount = 0;
for (const item of Object.values(itemsById)) { for (const item of Object.values(itemsById)) {
const pkg = packagesById[item.packageId]; const pkg = packagesById[item.packageId];
if (!pkg) { if (!pkg) {
@@ -1094,10 +1122,23 @@ export function normalizeLoadedSession(raw: unknown): SessionState {
droppedUnsafeTargetPathCount += 1; droppedUnsafeTargetPathCount += 1;
} }
item.targetPath = safeTargetPath; item.targetPath = safeTargetPath;
const metadataRenameTargetPath = asText(item.metadataRenameTargetPath);
const safeMetadataRenameTargetPath = normalizeSessionMetadataRenameTargetPath(metadataRenameTargetPath, pkg.outputDir);
if (metadataRenameTargetPath && !safeMetadataRenameTargetPath) {
droppedUnsafeMetadataRenameTargetPathCount += 1;
}
if (safeMetadataRenameTargetPath) {
item.metadataRenameTargetPath = safeMetadataRenameTargetPath;
} else {
delete item.metadataRenameTargetPath;
}
} }
if (droppedUnsafeTargetPathCount > 0) { if (droppedUnsafeTargetPathCount > 0) {
logger.warn(`normalizeLoadedSession: ${droppedUnsafeTargetPathCount} unsichere targetPath-Eintraege verworfen`); logger.warn(`normalizeLoadedSession: ${droppedUnsafeTargetPathCount} unsichere targetPath-Eintraege verworfen`);
} }
if (droppedUnsafeMetadataRenameTargetPathCount > 0) {
logger.warn(`normalizeLoadedSession: ${droppedUnsafeMetadataRenameTargetPathCount} unsichere metadataRenameTargetPath-Einträge verworfen`);
}
for (const pkg of Object.values(packagesById)) { for (const pkg of Object.values(packagesById)) {
pkg.itemIds = pkg.itemIds.filter((itemId) => { pkg.itemIds = pkg.itemIds.filter((itemId) => {
@@ -1143,13 +1184,12 @@ export function normalizeLoadedSession(raw: unknown): SessionState {
export function loadSettings(paths: StoragePaths): AppSettings { export function loadSettings(paths: StoragePaths): AppSettings {
ensureBaseDir(paths.baseDir); ensureBaseDir(paths.baseDir);
if (!fs.existsSync(paths.configFile)) { const primaryExists = fs.existsSync(paths.configFile);
return defaultSettings(); const backupFile = `${paths.configFile}.bak`;
} const backupExists = fs.existsSync(backupFile);
const loaded = readSettingsFile(paths.configFile); const loaded = primaryExists ? readSettingsFile(paths.configFile) : null;
if (loaded) { if (loaded) {
const backupFile = `${paths.configFile}.bak`; const backupNeedsCredentialRewrite = backupExists
const backupNeedsCredentialRewrite = fs.existsSync(backupFile)
? needsSettingsFileCredentialRewrite(backupFile) ? needsSettingsFileCredentialRewrite(backupFile)
: false; : false;
if (loaded.needsCredentialRewrite || backupNeedsCredentialRewrite) { if (loaded.needsCredentialRewrite || backupNeedsCredentialRewrite) {
@@ -1158,15 +1198,18 @@ export function loadSettings(paths: StoragePaths): AppSettings {
return loaded.settings; return loaded.settings;
} }
const backupFile = `${paths.configFile}.bak`; const backupLoaded = backupExists ? readSettingsFile(backupFile) : null;
const backupLoaded = fs.existsSync(backupFile) ? readSettingsFile(backupFile) : null;
if (backupLoaded) { if (backupLoaded) {
logger.warn("Konfiguration defekt, Backup-Datei wird verwendet"); logger.warn(primaryExists
? "Konfiguration defekt, Backup-Datei wird verwendet"
: "Konfiguration fehlt, Backup-Datei wird verwendet");
rewriteProtectedSettings(paths, backupLoaded.settings); rewriteProtectedSettings(paths, backupLoaded.settings);
return backupLoaded.settings; return backupLoaded.settings;
} }
logger.error("Konfiguration konnte nicht geladen werden (auch Backup fehlgeschlagen)"); if (primaryExists || backupExists) {
logger.error("Konfiguration konnte nicht geladen werden (auch Backup fehlgeschlagen)");
}
return defaultSettings(); return defaultSettings();
} }
@@ -1282,6 +1325,16 @@ interface LoadedSessionFile {
wasRunning: boolean; wasRunning: boolean;
} }
function isPersistedSessionEnvelope(value: unknown): boolean {
const parsed = asRecord(value);
return Boolean(
parsed
&& Array.isArray(parsed.packageOrder)
&& asRecord(parsed.packages)
&& asRecord(parsed.items)
);
}
function readSessionFile(filePath: string): LoadedSessionFile | null { function readSessionFile(filePath: string): LoadedSessionFile | null {
let raw: string | null = null; let raw: string | null = null;
const maxAttempts = 5; const maxAttempts = 5;
@@ -1310,6 +1363,10 @@ function readSessionFile(filePath: string): LoadedSessionFile | null {
} }
try { try {
const parsed = JSON.parse(raw) as unknown; const parsed = JSON.parse(raw) as unknown;
if (!isPersistedSessionEnvelope(parsed)) {
logger.error(`Session-Datei beschädigt (Struktur ungültig): ${filePath}`);
return null;
}
const normalized = normalizeLoadedSession(parsed); const normalized = normalizeLoadedSession(parsed);
const wasRunning = normalized.running; const wasRunning = normalized.running;
const session = normalizeLoadedSessionTransientFields(normalized); const session = normalizeLoadedSessionTransientFields(normalized);
@@ -1331,8 +1388,19 @@ export function saveSettings(paths: StoragePaths, settings: AppSettings): void {
writeSettingsFileAtomically(paths.configFile, payloads.primary); writeSettingsFileAtomically(paths.configFile, payloads.primary);
} }
let asyncSettingsSaveRunning = false; interface AsyncSaveWaiter {
let asyncSettingsSaveQueued: { paths: StoragePaths; settings: AppSettings; generation: number } | null = null; resolve: () => void;
reject: (error: unknown) => void;
}
interface QueuedSettingsSave {
paths: StoragePaths;
settings: AppSettings;
generation: number;
waiters: AsyncSaveWaiter[];
}
let asyncSettingsSaveQueued: QueuedSettingsSave | null = null;
let syncSettingsSaveGeneration = 0; let syncSettingsSaveGeneration = 0;
let activeSettingsSave: Promise<void> | null = null; let activeSettingsSave: Promise<void> | null = null;
@@ -1364,27 +1432,52 @@ async function writeSettingsPayload(paths: StoragePaths, settings: AppSettings,
} }
} }
async function saveSettingsPayloadAsync(paths: StoragePaths, settings: AppSettings, generation: number): Promise<void> { function startSettingsSaveDrain(): void {
if (asyncSettingsSaveRunning) { if (activeSettingsSave) {
asyncSettingsSaveQueued = { paths, settings, generation };
return; return;
} }
asyncSettingsSaveRunning = true; let operation: Promise<void>;
const operation = writeSettingsPayload(paths, settings, generation).catch((error) => { operation = (async () => {
logger.error(`Async Settings-Save fehlgeschlagen: ${String(error)}`); while (asyncSettingsSaveQueued) {
}).finally(() => { const current = asyncSettingsSaveQueued;
asyncSettingsSaveRunning = false; asyncSettingsSaveQueued = null;
try {
await writeSettingsPayload(current.paths, current.settings, current.generation);
current.waiters.forEach((waiter) => waiter.resolve());
} catch (error) {
current.waiters.forEach((waiter) => waiter.reject(error));
const pending = asyncSettingsSaveQueued as QueuedSettingsSave | null;
asyncSettingsSaveQueued = null;
pending?.waiters.forEach((waiter) => waiter.reject(error));
logger.error(`Async Settings-Save fehlgeschlagen: ${String(error)}`);
throw error;
}
}
})().finally(() => {
if (activeSettingsSave === operation) { if (activeSettingsSave === operation) {
activeSettingsSave = null; activeSettingsSave = null;
} }
if (asyncSettingsSaveQueued) { if (asyncSettingsSaveQueued) {
const queued = asyncSettingsSaveQueued; startSettingsSaveDrain();
asyncSettingsSaveQueued = null;
void saveSettingsPayloadAsync(queued.paths, queued.settings, queued.generation);
} }
}); });
activeSettingsSave = operation; activeSettingsSave = operation;
await operation; void operation.catch(() => {});
}
function saveSettingsPayloadAsync(paths: StoragePaths, settings: AppSettings, generation: number): Promise<void> {
return new Promise<void>((resolve, reject) => {
const waiter = { resolve, reject };
if (asyncSettingsSaveQueued) {
asyncSettingsSaveQueued.paths = paths;
asyncSettingsSaveQueued.settings = settings;
asyncSettingsSaveQueued.generation = generation;
asyncSettingsSaveQueued.waiters.push(waiter);
} else {
asyncSettingsSaveQueued = { paths, settings, generation, waiters: [waiter] };
}
startSettingsSaveDrain();
});
} }
export async function saveSettingsAsync(paths: StoragePaths, settings: AppSettings): Promise<void> { export async function saveSettingsAsync(paths: StoragePaths, settings: AppSettings): Promise<void> {
@@ -1446,23 +1539,6 @@ export function loadSessionWithStatus(paths: StoragePaths): SessionLoadResult {
const primary = primaryExists ? readSessionFile(paths.sessionFile) : null; const primary = primaryExists ? readSessionFile(paths.sessionFile) : null;
if (primary) { if (primary) {
const primaryPkgCount = Object.keys(primary.session.packages).length;
if (primaryPkgCount === 0 && backupExists) {
const backup = readSessionFile(backupFile);
if (backup) {
const backupPkgCount = Object.keys(backup.session.packages).length;
if (backupPkgCount > 0) {
logger.warn(`Session-Datei ist leer (0 Pakete), aber Backup hat ${backupPkgCount} Pakete — verwende Backup`);
try {
const payload = JSON.stringify({ ...backup.session, updatedAt: Date.now() }, safeJsonReplacer);
fs.writeFileSync(syncTempFile, payload, "utf8");
syncRenameWithExdevFallback(syncTempFile, paths.sessionFile);
} catch {
}
return { session: backup.session, status: "recovered-backup", wasRunning: backup.wasRunning };
}
}
}
return { session: primary.session, status: "ok", wasRunning: primary.wasRunning }; return { session: primary.session, status: "ok", wasRunning: primary.wasRunning };
} }
@@ -1532,8 +1608,14 @@ export function saveSession(paths: StoragePaths, session: SessionState): void {
} }
} }
let asyncSaveRunning = false; interface QueuedSessionSave {
let asyncSaveQueued: { paths: StoragePaths; payload: string; generation: number } | null = null; paths: StoragePaths;
payload: string;
generation: number;
waiters: AsyncSaveWaiter[];
}
let asyncSaveQueued: QueuedSessionSave | null = null;
let syncSaveGeneration = 0; let syncSaveGeneration = 0;
let activeSessionSave: Promise<void> | null = null; let activeSessionSave: Promise<void> | null = null;
@@ -1568,27 +1650,52 @@ async function writeSessionPayload(paths: StoragePaths, payload: string, generat
} }
} }
async function saveSessionPayloadAsync(paths: StoragePaths, payload: string, generation: number): Promise<void> { function startSessionSaveDrain(): void {
if (asyncSaveRunning) { if (activeSessionSave) {
asyncSaveQueued = { paths, payload, generation };
return; return;
} }
asyncSaveRunning = true; let operation: Promise<void>;
const operation = writeSessionPayload(paths, payload, generation).catch((error) => { operation = (async () => {
logger.error(`Async Session-Save fehlgeschlagen: ${String(error)}`); while (asyncSaveQueued) {
}).finally(() => { const current = asyncSaveQueued;
asyncSaveRunning = false; asyncSaveQueued = null;
try {
await writeSessionPayload(current.paths, current.payload, current.generation);
current.waiters.forEach((waiter) => waiter.resolve());
} catch (error) {
current.waiters.forEach((waiter) => waiter.reject(error));
const pending = asyncSaveQueued as QueuedSessionSave | null;
asyncSaveQueued = null;
pending?.waiters.forEach((waiter) => waiter.reject(error));
logger.error(`Async Session-Save fehlgeschlagen: ${String(error)}`);
throw error;
}
}
})().finally(() => {
if (activeSessionSave === operation) { if (activeSessionSave === operation) {
activeSessionSave = null; activeSessionSave = null;
} }
if (asyncSaveQueued) { if (asyncSaveQueued) {
const queued = asyncSaveQueued; startSessionSaveDrain();
asyncSaveQueued = null;
void saveSessionPayloadAsync(queued.paths, queued.payload, queued.generation);
} }
}); });
activeSessionSave = operation; activeSessionSave = operation;
await operation; void operation.catch(() => {});
}
function saveSessionPayloadAsync(paths: StoragePaths, payload: string, generation: number): Promise<void> {
return new Promise<void>((resolve, reject) => {
const waiter = { resolve, reject };
if (asyncSaveQueued) {
asyncSaveQueued.paths = paths;
asyncSaveQueued.payload = payload;
asyncSaveQueued.generation = generation;
asyncSaveQueued.waiters.push(waiter);
} else {
asyncSaveQueued = { paths, payload, generation, waiters: [waiter] };
}
startSessionSaveDrain();
});
} }
interface BlockedSettingsSave { interface BlockedSettingsSave {
@@ -1616,6 +1723,47 @@ export interface PersistenceBarrier {
let activePersistenceBarrier: PersistenceBarrierState | null = null; let activePersistenceBarrier: PersistenceBarrierState | null = null;
interface DetachedAsyncSaves {
settings: QueuedSettingsSave | null;
session: QueuedSessionSave | null;
}
function detachPendingAsyncSaves(): DetachedAsyncSaves {
const detached = {
settings: asyncSettingsSaveQueued,
session: asyncSaveQueued
};
asyncSettingsSaveQueued = null;
asyncSaveQueued = null;
return detached;
}
function rejectDetachedAsyncSaves(detached: DetachedAsyncSaves, error: unknown): void {
detached.settings?.waiters.forEach((waiter) => waiter.reject(error));
detached.session?.waiters.forEach((waiter) => waiter.reject(error));
}
function requeueDetachedAsyncSaves(detached: DetachedAsyncSaves): void {
if (detached.settings) {
detached.settings.generation = syncSettingsSaveGeneration;
if (asyncSettingsSaveQueued) {
asyncSettingsSaveQueued.waiters.unshift(...detached.settings.waiters);
} else {
asyncSettingsSaveQueued = detached.settings;
}
startSettingsSaveDrain();
}
if (detached.session) {
detached.session.generation = syncSaveGeneration;
if (asyncSaveQueued) {
asyncSaveQueued.waiters.unshift(...detached.session.waiters);
} else {
asyncSaveQueued = detached.session;
}
startSessionSaveDrain();
}
}
function blockSettingsSave(state: PersistenceBarrierState, paths: StoragePaths, settings: AppSettings): Promise<void> { function blockSettingsSave(state: PersistenceBarrierState, paths: StoragePaths, settings: AppSettings): Promise<void> {
return new Promise<void>((resolve, reject) => { return new Promise<void>((resolve, reject) => {
const waiter = { resolve, reject }; const waiter = { resolve, reject };
@@ -1643,28 +1791,61 @@ function blockSessionSave(state: PersistenceBarrierState, paths: StoragePaths, p
} }
async function replayBlockedSaves(state: PersistenceBarrierState): Promise<void> { async function replayBlockedSaves(state: PersistenceBarrierState): Promise<void> {
let firstError: unknown;
let failed = false;
while (state.blockedSettings || state.blockedSession) { while (state.blockedSettings || state.blockedSession) {
const blockedSettings = state.blockedSettings; const blockedSettings = state.blockedSettings;
const blockedSession = state.blockedSession; const blockedSession = state.blockedSession;
state.blockedSettings = null; state.blockedSettings = null;
state.blockedSession = null; state.blockedSession = null;
try { const [settingsResult, sessionResult] = await Promise.allSettled([
await Promise.all([ blockedSettings
blockedSettings ? saveSettingsPayloadAsync(blockedSettings.paths, blockedSettings.settings, syncSettingsSaveGeneration)
? saveSettingsPayloadAsync(blockedSettings.paths, blockedSettings.settings, syncSettingsSaveGeneration) : Promise.resolve(),
: Promise.resolve(), blockedSession
blockedSession ? saveSessionPayloadAsync(blockedSession.paths, blockedSession.payload, syncSaveGeneration)
? saveSessionPayloadAsync(blockedSession.paths, blockedSession.payload, syncSaveGeneration) : Promise.resolve()
: Promise.resolve() ]);
]); if (blockedSettings) {
blockedSettings?.waiters.forEach((waiter) => waiter.resolve()); if (settingsResult.status === "fulfilled") {
blockedSession?.waiters.forEach((waiter) => waiter.resolve()); blockedSettings.waiters.forEach((waiter) => waiter.resolve());
} catch (error) { } else {
blockedSettings?.waiters.forEach((waiter) => waiter.reject(error)); blockedSettings.waiters.forEach((waiter) => waiter.reject(settingsResult.reason));
blockedSession?.waiters.forEach((waiter) => waiter.reject(error)); if (!failed) {
throw error; firstError = settingsResult.reason;
failed = true;
}
}
}
if (blockedSession) {
if (sessionResult.status === "fulfilled") {
blockedSession.waiters.forEach((waiter) => waiter.resolve());
} else {
blockedSession.waiters.forEach((waiter) => waiter.reject(sessionResult.reason));
if (!failed) {
firstError = sessionResult.reason;
failed = true;
}
}
} }
} }
if (failed) {
throw firstError;
}
}
function rejectBlockedSaves(state: PersistenceBarrierState, error: unknown): void {
state.blockedSettings?.waiters.forEach((waiter) => waiter.reject(error));
state.blockedSession?.waiters.forEach((waiter) => waiter.reject(error));
state.blockedSettings = null;
state.blockedSession = null;
}
function resolveBlockedSaves(state: PersistenceBarrierState): void {
state.blockedSettings?.waiters.forEach((waiter) => waiter.resolve());
state.blockedSession?.waiters.forEach((waiter) => waiter.resolve());
state.blockedSettings = null;
state.blockedSession = null;
} }
export async function acquirePersistenceBarrier(): Promise<PersistenceBarrier> { export async function acquirePersistenceBarrier(): Promise<PersistenceBarrier> {
@@ -1680,19 +1861,46 @@ export async function acquirePersistenceBarrier(): Promise<PersistenceBarrier> {
resolveReleased resolveReleased
}; };
activePersistenceBarrier = state; activePersistenceBarrier = state;
cancelPendingAsyncSaves(); const detachedSaves = detachPendingAsyncSaves();
await Promise.all([activeSettingsSave ?? Promise.resolve(), activeSessionSave ?? Promise.resolve()]); const activeWriteResults = await Promise.allSettled([
activeSettingsSave ?? Promise.resolve(),
activeSessionSave ?? Promise.resolve()
]);
const activeWriteFailure = activeWriteResults.find((result) => result.status === "rejected");
if (activeWriteFailure?.status === "rejected") {
rejectBlockedSaves(state, activeWriteFailure.reason);
if (activePersistenceBarrier === state) {
activePersistenceBarrier = null;
}
requeueDetachedAsyncSaves(detachedSaves);
state.resolveReleased();
throw activeWriteFailure.reason;
}
rejectDetachedAsyncSaves(detachedSaves, new Error("Persistenzbarriere hat ausstehenden Save verworfen"));
let finished = false; let finished = false;
return { return {
release: async ({ replayBlocked }) => { release: async ({ replayBlocked }) => {
if (finished) return; if (finished) return;
finished = true; finished = true;
let replayError: unknown;
let replayFailed = false;
try { try {
if (replayBlocked) { if (replayBlocked) {
await replayBlockedSaves(state); do {
try {
await replayBlockedSaves(state);
} catch (error) {
if (!replayFailed) {
replayError = error;
replayFailed = true;
}
}
} while (state.blockedSettings || state.blockedSession);
} else { } else {
state.blockedSettings?.waiters.forEach((waiter) => waiter.resolve()); resolveBlockedSaves(state);
state.blockedSession?.waiters.forEach((waiter) => waiter.resolve()); }
if (replayFailed) {
throw replayError;
} }
} finally { } finally {
if (activePersistenceBarrier === state) { if (activePersistenceBarrier === state) {
@@ -1705,10 +1913,11 @@ export async function acquirePersistenceBarrier(): Promise<PersistenceBarrier> {
} }
export function cancelPendingAsyncSaves(): void { export function cancelPendingAsyncSaves(): void {
asyncSaveQueued = null;
asyncSettingsSaveQueued = null;
syncSaveGeneration += 1;
syncSettingsSaveGeneration += 1; syncSettingsSaveGeneration += 1;
syncSaveGeneration += 1;
const detached = detachPendingAsyncSaves();
detached.session?.waiters.forEach((waiter) => waiter.resolve());
detached.settings?.waiters.forEach((waiter) => waiter.resolve());
} }
export async function saveSessionAsync(paths: StoragePaths, session: SessionState): Promise<void> { export async function saveSessionAsync(paths: StoragePaths, session: SessionState): Promise<void> {
+137 -11
View File
@@ -702,11 +702,135 @@ async function downloadFile(
const tempPath = `${targetPath}.tmp`; const tempPath = `${targetPath}.tmp`;
const writeStream = fs.createWriteStream(tempPath); const writeStream = fs.createWriteStream(tempPath);
const reader = response.body.getReader(); const reader = response.body.getReader();
let writeError: unknown = null;
const idleMs = getBodyIdleTimeout(); const idleMs = getBodyIdleTimeout();
const idleAbortController = new AbortController();
let idleTimer: NodeJS.Timeout | null = null; let idleTimer: NodeJS.Timeout | null = null;
let idleTimedOut = false; let idleTimedOut = false;
const idleTimeoutError = (): Error => new Error(`Update Download Body Timeout nach ${Math.ceil(idleMs / 1000)}s`);
const onWriteError = (error: unknown): void => {
writeError = error;
void reader.cancel().catch(() => undefined);
};
const onWriteClose = (): void => {
writeStream.removeListener("error", onWriteError);
};
writeStream.on("error", onWriteError);
writeStream.once("close", onWriteClose);
const waitForDrain = async (): Promise<void> => {
if (writeError !== null) throw writeError;
if (idleTimedOut) throw idleTimeoutError();
if (shutdown?.aborted) throw new Error("aborted:update_shutdown");
await new Promise<void>((resolve, reject) => {
let settled = false;
const cleanup = (): void => {
writeStream.removeListener("drain", onDrain);
writeStream.removeListener("error", onError);
idleAbortController.signal.removeEventListener("abort", onIdleTimeout);
shutdown?.removeEventListener("abort", onAbort);
};
const settle = (error?: unknown): void => {
if (settled) return;
settled = true;
cleanup();
if (error !== undefined) {
reject(error);
} else {
resolve();
}
};
const onDrain = (): void => settle();
const onError = (error: unknown): void => settle(error);
const onIdleTimeout = (): void => settle(idleTimeoutError());
const onAbort = (): void => settle(new Error("aborted:update_shutdown"));
writeStream.once("drain", onDrain);
writeStream.once("error", onError);
idleAbortController.signal.addEventListener("abort", onIdleTimeout, { once: true });
shutdown?.addEventListener("abort", onAbort, { once: true });
if (writeError !== null) {
settle(writeError);
} else if (idleTimedOut) {
onIdleTimeout();
} else if (shutdown?.aborted) {
onAbort();
}
});
};
const finishWriting = async (): Promise<void> => {
if (writeError !== null) throw writeError;
if (idleTimedOut) throw idleTimeoutError();
if (shutdown?.aborted) throw new Error("aborted:update_shutdown");
await new Promise<void>((resolve, reject) => {
let settled = false;
let endSucceeded = false;
let closed = false;
const cleanup = (): void => {
writeStream.removeListener("error", onError);
writeStream.removeListener("close", onClose);
idleAbortController.signal.removeEventListener("abort", onIdleTimeout);
shutdown?.removeEventListener("abort", onAbort);
};
const settle = (error?: unknown): void => {
if (settled) return;
settled = true;
cleanup();
if (error !== undefined) {
reject(error);
} else {
resolve();
}
};
const onError = (error: unknown): void => settle(error);
const settleIfComplete = (): void => {
if (endSucceeded && closed) settle();
};
const onClose = (): void => {
closed = true;
if (writeError !== null) {
settle(writeError);
return;
}
settleIfComplete();
};
const onIdleTimeout = (): void => settle(idleTimeoutError());
const onAbort = (): void => settle(new Error("aborted:update_shutdown"));
writeStream.once("error", onError);
writeStream.once("close", onClose);
idleAbortController.signal.addEventListener("abort", onIdleTimeout, { once: true });
shutdown?.addEventListener("abort", onAbort, { once: true });
if (writeError !== null) {
settle(writeError);
} else if (idleTimedOut) {
onIdleTimeout();
} else if (shutdown?.aborted) {
onAbort();
} else {
try {
writeStream.end((error?: unknown) => {
if (error !== undefined && error !== null) {
settle(error);
} else {
endSucceeded = true;
settleIfComplete();
}
});
} catch (error) {
settle(error);
}
}
});
};
const clearIdle = (): void => { const clearIdle = (): void => {
if (idleTimer) { if (idleTimer) {
clearTimeout(idleTimer); clearTimeout(idleTimer);
@@ -719,7 +843,8 @@ async function downloadFile(
if (idleMs > 0) { if (idleMs > 0) {
idleTimer = setTimeout(() => { idleTimer = setTimeout(() => {
idleTimedOut = true; idleTimedOut = true;
reader.cancel().catch(() => undefined); idleAbortController.abort();
void reader.cancel().catch(() => undefined);
}, idleMs); }, idleMs);
} }
}; };
@@ -728,39 +853,40 @@ async function downloadFile(
resetIdle(); resetIdle();
for (;;) { for (;;) {
if (shutdown?.aborted) { if (shutdown?.aborted) {
await reader.cancel().catch(() => undefined); void reader.cancel().catch(() => undefined);
throw new Error("aborted:update_shutdown"); throw new Error("aborted:update_shutdown");
} }
const { done, value } = await reader.read(); const { done, value } = await reader.read();
if (writeError !== null) throw writeError;
if (done) break; if (done) break;
const buf = Buffer.from(value.buffer, value.byteOffset, value.byteLength); const buf = Buffer.from(value.buffer, value.byteOffset, value.byteLength);
if (!writeStream.write(buf)) { if (!writeStream.write(buf)) {
await new Promise<void>((resolve) => writeStream.once("drain", resolve)); await waitForDrain();
} }
if (writeError !== null) throw writeError;
downloadedBytes += buf.byteLength; downloadedBytes += buf.byteLength;
resetIdle(); resetIdle();
reportProgress(false); reportProgress(false);
} }
await finishWriting();
if (writeError !== null) throw writeError;
} catch (error) { } catch (error) {
writeStream.destroy(); writeStream.destroy();
void reader.cancel().catch(() => undefined);
await fs.promises.rm(tempPath, { force: true }).catch(() => {}); await fs.promises.rm(tempPath, { force: true }).catch(() => {});
if (idleTimedOut) { if (idleTimedOut) {
throw new Error(`Update Download Body Timeout nach ${Math.ceil(idleMs / 1000)}s`); throw idleTimeoutError();
} }
throw error; throw error;
} finally { } finally {
clearIdle(); clearIdle();
} }
await new Promise<void>((resolve, reject) => {
writeStream.end(() => resolve());
writeStream.on("error", reject);
});
if (idleTimedOut) { if (idleTimedOut) {
await fs.promises.rm(tempPath, { force: true }).catch(() => {}); await fs.promises.rm(tempPath, { force: true }).catch(() => {});
throw new Error(`Update Download Body Timeout nach ${Math.ceil(idleMs / 1000)}s`); throw idleTimeoutError();
} }
if (totalBytes && downloadedBytes !== totalBytes) { if (totalBytes && downloadedBytes !== totalBytes) {
+55 -1
View File
@@ -44,7 +44,7 @@ import { defaultSettings } from "../src/main/constants";
import { configureCredentialProtector } from "../src/main/credential-protection"; import { configureCredentialProtector } from "../src/main/credential-protection";
import { createRendererState } from "../src/main/renderer-state"; import { createRendererState } from "../src/main/renderer-state";
import { getAuditLogPath, initAuditLog, logAuditEvent, shutdownAuditLog } from "../src/main/audit-log"; import { getAuditLogPath, initAuditLog, logAuditEvent, shutdownAuditLog } from "../src/main/audit-log";
import { startDebugServer, stopDebugServer } from "../src/main/debug-server"; import { getDebugServerRuntimeStatus, restartDebugServer, startDebugServer, stopDebugServer, writeDebugServerConfig } from "../src/main/debug-server";
import { ensureItemLog, initItemLogs, shutdownItemLogs } from "../src/main/item-log"; import { ensureItemLog, initItemLogs, shutdownItemLogs } from "../src/main/item-log";
import { configureLogger, getLogFilePath, logger } from "../src/main/logger"; import { configureLogger, getLogFilePath, logger } from "../src/main/logger";
import { ensurePackageLog, initPackageLogs, shutdownPackageLogs } from "../src/main/package-log"; import { ensurePackageLog, initPackageLogs, shutdownPackageLogs } from "../src/main/package-log";
@@ -370,6 +370,60 @@ afterEach(() => {
}); });
describe("debug-server", () => { describe("debug-server", () => {
it("keeps exactly one reachable server across concurrent restarts", async () => {
const fixture = await createFixture();
writeDebugServerConfig({ allowlist: ["203.0.113.5"] });
await Promise.all([restartDebugServer(), restartDebugServer()]);
expect(getDebugServerRuntimeStatus()).toEqual(expect.objectContaining({
running: true,
allowlistCount: 1
}));
const response = await authedFetch(`${fixture.baseUrl}/health`, fixture.token);
expect(response.ok).toBe(true);
});
it("does not reopen after stop races with queued restarts", async () => {
const fixture = await createFixture();
const restarts = Promise.all([restartDebugServer(), restartDebugServer()]);
stopDebugServer();
await restarts;
expect(getDebugServerRuntimeStatus().running).toBe(false);
await expect(fetch(`${fixture.baseUrl}/health`, {
signal: AbortSignal.timeout(1000)
})).rejects.toThrow();
});
it("settles the lifecycle queue when stopped during socket startup", async () => {
const baseDir = fs.mkdtempSync(path.join(os.tmpdir(), "rd-debug-start-stop-"));
tempDirs.push(baseDir);
const port = await getFreePort();
fs.writeFileSync(path.join(baseDir, "debug_token.txt"), "debug-secret", "utf8");
fs.writeFileSync(path.join(baseDir, "debug_port.txt"), String(port), "utf8");
fs.writeFileSync(path.join(baseDir, "debug_host.txt"), "127.0.0.1", "utf8");
fs.writeFileSync(path.join(baseDir, "debug_allowlist.txt"), "", "utf8");
startDebugServer({} as DownloadManager, baseDir);
await Promise.resolve();
await Promise.resolve();
stopDebugServer();
const outcome = await Promise.race([
restartDebugServer().then(() => "settled"),
new Promise<string>((resolve) => setTimeout(() => resolve("timeout"), 500))
]);
expect(outcome).toBe("settled");
expect(getDebugServerRuntimeStatus().running).toBe(false);
startDebugServer({} as DownloadManager, baseDir);
await waitForReady(`http://127.0.0.1:${port}/health`);
expect(getDebugServerRuntimeStatus().running).toBe(true);
});
it("serves the exact safe notification DTO in its endpoint and diagnostics", async () => { it("serves the exact safe notification DTO in its endpoint and diagnostics", async () => {
const fixture = await createFixture(); const fixture = await createFixture();
const response = await authedFetch(`${fixture.baseUrl}/notifications`, fixture.token); const response = await authedFetch(`${fixture.baseUrl}/notifications`, fixture.token);
+2 -2
View File
@@ -185,7 +185,7 @@ describe("session restart loss", () => {
expect(Object.keys(loaded.items)).toEqual([]); expect(Object.keys(loaded.items)).toEqual([]);
}); });
it("recovers from the backup when the primary exists but is empty", () => { it("keeps a valid empty primary authoritative over an older populated backup", () => {
const dir = fs.mkdtempSync(path.join(os.tmpdir(), "rd-loss-")); const dir = fs.mkdtempSync(path.join(os.tmpdir(), "rd-loss-"));
tempDirs.push(dir); tempDirs.push(dir);
const paths = createStoragePaths(dir); const paths = createStoragePaths(dir);
@@ -194,7 +194,7 @@ describe("session restart loss", () => {
fs.writeFileSync(`${paths.sessionFile}.bak`, JSON.stringify(sessionWith(["A", "B"])), "utf8"); fs.writeFileSync(`${paths.sessionFile}.bak`, JSON.stringify(sessionWith(["A", "B"])), "utf8");
const loaded = loadSession(paths); const loaded = loadSession(paths);
expect(Object.keys(loaded.packages).sort()).toEqual(["A", "B"]); expect(Object.keys(loaded.packages)).toEqual([]);
}); });
it("does not let an in-flight/queued async settings save clobber a newer synchronous saveSettings", async () => { it("does not let an in-flight/queued async settings save clobber a newer synchronous saveSettings", async () => {
+595
View File
@@ -1961,6 +1961,66 @@ describe("settings storage", () => {
expect(restoredPrimary.packages && "pkg-backup" in restoredPrimary.packages).toBe(true); expect(restoredPrimary.packages && "pkg-backup" in restoredPrimary.packages).toBe(true);
}); });
it("keeps a valid intentionally empty primary session authoritative over its populated backup", () => {
const dir = fs.mkdtempSync(path.join(os.tmpdir(), "rd-store-empty-primary-"));
tempDirs.push(dir);
const paths = createStoragePaths(dir);
const populated = normalizeLoadedSession({
...emptySession(),
packageOrder: ["pkg-old"],
packages: {
"pkg-old": {
id: "pkg-old",
name: "Old Package",
outputDir: path.join(dir, "out"),
extractDir: path.join(dir, "extract"),
status: "queued",
itemIds: []
}
}
});
saveSession(paths, populated);
saveSession(paths, emptySession());
const loaded = loadSessionWithStatus(paths);
expect(loaded.status).toBe("ok");
expect(loaded.session.packageOrder).toEqual([]);
expect(loaded.session.packages).toEqual({});
});
it.each([
["empty object", {}],
["null", null],
["array", []]
])("recovers the backup when the primary contains a JSON-valid invalid %s envelope", (_label, invalidPrimary) => {
const dir = fs.mkdtempSync(path.join(os.tmpdir(), "rd-store-invalid-session-envelope-"));
tempDirs.push(dir);
const paths = createStoragePaths(dir);
const backup = normalizeLoadedSession({
...emptySession(),
packageOrder: ["pkg-backup"],
packages: {
"pkg-backup": {
id: "pkg-backup",
name: "Backup Package",
outputDir: path.join(dir, "out"),
extractDir: path.join(dir, "extract"),
status: "queued",
itemIds: []
}
}
});
fs.writeFileSync(`${paths.sessionFile}.bak`, JSON.stringify(backup), "utf8");
fs.writeFileSync(paths.sessionFile, JSON.stringify(invalidPrimary), "utf8");
const loaded = loadSessionWithStatus(paths);
expect(loaded.status).toBe("recovered-backup");
expect(loaded.session.packageOrder).toEqual(["pkg-backup"]);
expect(Object.keys(loaded.session.packages)).toEqual(["pkg-backup"]);
});
it("returns defaults when config file contains invalid JSON", () => { it("returns defaults when config file contains invalid JSON", () => {
const dir = fs.mkdtempSync(path.join(os.tmpdir(), "rd-store-")); const dir = fs.mkdtempSync(path.join(os.tmpdir(), "rd-store-"));
tempDirs.push(dir); tempDirs.push(dir);
@@ -1995,6 +2055,68 @@ describe("settings storage", () => {
expect(loaded.packageName).toBe("from-backup"); expect(loaded.packageName).toBe("from-backup");
}); });
it.each([
["empty object", {}],
["null", null],
["array", []],
["unrecognized object", { unrelated: true }]
])("loads and repairs the backup when the primary config contains a JSON-valid invalid %s envelope", (_label, invalidPrimary) => {
const dir = fs.mkdtempSync(path.join(os.tmpdir(), "rd-store-invalid-settings-envelope-"));
tempDirs.push(dir);
const paths = createStoragePaths(dir);
const backupSettings = {
...defaultSettings(),
outputDir: path.join(dir, "backup-output"),
packageName: "from-valid-backup"
};
fs.writeFileSync(`${paths.configFile}.bak`, JSON.stringify(backupSettings), "utf8");
fs.writeFileSync(paths.configFile, JSON.stringify(invalidPrimary), "utf8");
const loaded = loadSettings(paths);
expect(loaded.outputDir).toBe(backupSettings.outputDir);
expect(loaded.packageName).toBe("from-valid-backup");
expect(loadSettings(paths).packageName).toBe("from-valid-backup");
});
it("keeps a sparse legacy primary config authoritative over its backup", () => {
const dir = fs.mkdtempSync(path.join(os.tmpdir(), "rd-store-sparse-settings-"));
tempDirs.push(dir);
const paths = createStoragePaths(dir);
const legacyOutputDir = path.join(dir, "legacy-output");
fs.writeFileSync(`${paths.configFile}.bak`, JSON.stringify({
...defaultSettings(),
outputDir: path.join(dir, "backup-output"),
packageName: "from-backup"
}), "utf8");
fs.writeFileSync(paths.configFile, JSON.stringify({ outputDir: legacyOutputDir }), "utf8");
const loaded = loadSettings(paths);
expect(loaded.outputDir).toBe(legacyOutputDir);
expect(loaded.packageName).toBe("");
});
it("loads and repairs backup config when the primary config is missing", () => {
const dir = fs.mkdtempSync(path.join(os.tmpdir(), "rd-store-missing-config-"));
tempDirs.push(dir);
const paths = createStoragePaths(dir);
const settings = {
...defaultSettings(),
outputDir: path.join(dir, "kept-output"),
packageName: "from-existing-backup"
};
saveSettings(paths, settings);
fs.rmSync(paths.configFile);
const loaded = loadSettings(paths);
expect(loaded.outputDir).toBe(settings.outputDir);
expect(loaded.packageName).toBe("from-existing-backup");
expect(loadSettings(paths).packageName).toBe("from-existing-backup");
expect(fs.existsSync(paths.configFile)).toBe(true);
});
it("sanitizes malformed persisted session structures", () => { it("sanitizes malformed persisted session structures", () => {
const dir = fs.mkdtempSync(path.join(os.tmpdir(), "rd-store-")); const dir = fs.mkdtempSync(path.join(os.tmpdir(), "rd-store-"));
tempDirs.push(dir); tempDirs.push(dir);
@@ -2104,6 +2226,102 @@ describe("settings storage", () => {
expect(loaded.items["item-outside"]?.targetPath).toBe(""); expect(loaded.items["item-outside"]?.targetPath).toBe("");
}); });
it("preserves a metadata rename journal inside the package output directory across save and load", () => {
const dir = fs.mkdtempSync(path.join(os.tmpdir(), "rd-store-"));
tempDirs.push(dir);
const paths = createStoragePaths(dir);
const outputDir = path.join(dir, "downloads", "journal");
const currentPath = path.join(outputDir, "opaque.bin");
const renameTargetPath = path.join(outputDir, "resolved-name.rar");
const session = emptySession();
session.packageOrder = ["pkg-journal"];
session.packages["pkg-journal"] = {
id: "pkg-journal",
name: "Journal Package",
outputDir,
extractDir: path.join(dir, "extract", "journal"),
status: "completed",
itemIds: ["item-journal"],
cancelled: false,
enabled: true,
createdAt: 1,
updatedAt: 1
};
session.items["item-journal"] = {
id: "item-journal",
packageId: "pkg-journal",
url: "https://ddownload.com/journal123",
provider: null,
status: "completed",
retries: 0,
speedBps: 0,
downloadedBytes: 1024,
totalBytes: 1024,
progressPercent: 100,
fileName: "resolved-name.rar",
targetPath: currentPath,
metadataRenameTargetPath: renameTargetPath,
resumable: true,
attempts: 1,
lastError: "",
fullStatus: "Fertig",
createdAt: 1,
updatedAt: 1
};
saveSession(paths, session);
const loaded = loadSession(paths);
expect(loaded.items["item-journal"]?.metadataRenameTargetPath).toBe(path.resolve(renameTargetPath));
});
it("drops a metadata rename journal outside the package output directory", () => {
const dir = fs.mkdtempSync(path.join(os.tmpdir(), "rd-store-"));
tempDirs.push(dir);
const paths = createStoragePaths(dir);
const outputDir = path.join(dir, "downloads", "journal");
const session = emptySession();
session.packageOrder = ["pkg-journal"];
session.packages["pkg-journal"] = {
id: "pkg-journal",
name: "Journal Package",
outputDir,
extractDir: path.join(dir, "extract", "journal"),
status: "completed",
itemIds: ["item-journal"],
cancelled: false,
enabled: true,
createdAt: 1,
updatedAt: 1
};
session.items["item-journal"] = {
id: "item-journal",
packageId: "pkg-journal",
url: "https://ddownload.com/journal123",
provider: null,
status: "completed",
retries: 0,
speedBps: 0,
downloadedBytes: 1024,
totalBytes: 1024,
progressPercent: 100,
fileName: "resolved-name.rar",
targetPath: path.join(outputDir, "opaque.bin"),
metadataRenameTargetPath: path.join(dir, "outside", "resolved-name.rar"),
resumable: true,
attempts: 1,
lastError: "",
fullStatus: "Fertig",
createdAt: 1,
updatedAt: 1
};
saveSession(paths, session);
const loaded = loadSession(paths);
expect(loaded.items["item-journal"]?.metadataRenameTargetPath).toBeUndefined();
});
it("captures async session save payload before later mutations", async () => { it("captures async session save payload before later mutations", async () => {
const dir = fs.mkdtempSync(path.join(os.tmpdir(), "rd-store-")); const dir = fs.mkdtempSync(path.join(os.tmpdir(), "rd-store-"));
tempDirs.push(dir); tempDirs.push(dir);
@@ -2120,6 +2338,158 @@ describe("settings storage", () => {
expect(persisted.summaryText).toBe("before-mutation"); expect(persisted.summaryText).toBe("before-mutation");
}); });
it("keeps a queued async settings save pending until its payload is persisted", async () => {
const dir = fs.mkdtempSync(path.join(os.tmpdir(), "rd-store-settings-queue-"));
tempDirs.push(dir);
const paths = createStoragePaths(dir);
saveSettings(paths, defaultSettings());
const writeFile = fs.promises.writeFile.bind(fs.promises);
let releaseFirstWrite = () => {};
let markFirstWriteStarted = () => {};
const firstWriteStarted = new Promise<void>((resolve) => { markFirstWriteStarted = resolve; });
const firstWriteRelease = new Promise<void>((resolve) => { releaseFirstWrite = resolve; });
let settingsTempWrites = 0;
vi.spyOn(fs.promises, "writeFile").mockImplementation(async (filePath, data, options) => {
await writeFile(filePath, data, options);
if (String(filePath) === `${paths.configFile}.settings.tmp` && settingsTempWrites++ === 0) {
markFirstWriteStarted();
await firstWriteRelease;
}
});
const first = saveSettingsAsync(paths, { ...defaultSettings(), packageName: "first" });
await firstWriteStarted;
let secondSettled = false;
const second = saveSettingsAsync(paths, { ...defaultSettings(), packageName: "second" })
.then(() => { secondSettled = true; });
await new Promise<void>((resolve) => setImmediate(resolve));
const settledWhileBlocked = secondSettled;
releaseFirstWrite();
await Promise.all([first, second]);
await vi.waitFor(() => expect(loadSettings(paths).packageName).toBe("second"));
expect(settledWhileBlocked).toBe(false);
});
it("keeps a queued async session save pending until its payload is persisted", async () => {
const dir = fs.mkdtempSync(path.join(os.tmpdir(), "rd-store-session-queue-"));
tempDirs.push(dir);
const paths = createStoragePaths(dir);
const openFile = fs.promises.open.bind(fs.promises);
let releaseFirstWrite = () => {};
let markFirstWriteStarted = () => {};
const firstWriteStarted = new Promise<void>((resolve) => { markFirstWriteStarted = resolve; });
const firstWriteRelease = new Promise<void>((resolve) => { releaseFirstWrite = resolve; });
let sessionTempWrites = 0;
vi.spyOn(fs.promises, "open").mockImplementation(async (filePath, flags, mode) => {
const handle = await openFile(filePath, flags, mode);
if (String(filePath) === `${paths.sessionFile}.async.tmp`) {
const writeFile = handle.writeFile.bind(handle);
handle.writeFile = async (...args: Parameters<typeof handle.writeFile>) => {
const result = await writeFile(...args);
if (sessionTempWrites++ === 0) {
markFirstWriteStarted();
await firstWriteRelease;
}
return result;
};
}
return handle;
});
const first = saveSessionAsync(paths, { ...emptySession(), summaryText: "first" });
await firstWriteStarted;
let secondSettled = false;
const second = saveSessionAsync(paths, { ...emptySession(), summaryText: "second" })
.then(() => { secondSettled = true; });
await new Promise<void>((resolve) => setImmediate(resolve));
const settledWhileBlocked = secondSettled;
releaseFirstWrite();
await Promise.all([first, second]);
await vi.waitFor(() => expect(loadSession(paths).summaryText).toBe("second"));
expect(settledWhileBlocked).toBe(false);
});
it("drains a settings save queued in the completion tail", async () => {
const dir = fs.mkdtempSync(path.join(os.tmpdir(), "rd-store-settings-tail-"));
tempDirs.push(dir);
const paths = createStoragePaths(dir);
const renameFile = fs.renameSync.bind(fs);
let secondSave: Promise<void> | null = null;
let markSecondSaveStarted = () => {};
const secondSaveStarted = new Promise<void>((resolve) => { markSecondSaveStarted = resolve; });
let scheduled = false;
vi.spyOn(fs, "renameSync").mockImplementation((source, destination) => {
const result = renameFile(source, destination);
if (!scheduled && String(destination) === paths.configFile) {
scheduled = true;
queueMicrotask(() => queueMicrotask(() => {
secondSave = saveSettingsAsync(paths, { ...defaultSettings(), packageName: "second" });
markSecondSaveStarted();
}));
}
return result;
});
const firstSave = saveSettingsAsync(paths, { ...defaultSettings(), packageName: "first" });
await secondSaveStarted;
await firstSave;
expect(secondSave).not.toBeNull();
await secondSave;
expect(loadSettings(paths).packageName).toBe("second");
});
it("drains a session save queued in the completion tail", async () => {
const dir = fs.mkdtempSync(path.join(os.tmpdir(), "rd-store-session-tail-"));
tempDirs.push(dir);
const paths = createStoragePaths(dir);
const renameFile = fs.renameSync.bind(fs);
let secondSave: Promise<void> | null = null;
let markSecondSaveStarted = () => {};
const secondSaveStarted = new Promise<void>((resolve) => { markSecondSaveStarted = resolve; });
let scheduled = false;
vi.spyOn(fs, "renameSync").mockImplementation((source, destination) => {
const result = renameFile(source, destination);
if (!scheduled && String(destination) === paths.sessionFile) {
scheduled = true;
queueMicrotask(() => queueMicrotask(() => {
secondSave = saveSessionAsync(paths, { ...emptySession(), summaryText: "second" });
markSecondSaveStarted();
}));
}
return result;
});
const firstSave = saveSessionAsync(paths, { ...emptySession(), summaryText: "first" });
await secondSaveStarted;
await firstSave;
expect(secondSave).not.toBeNull();
await secondSave;
expect(loadSession(paths).summaryText).toBe("second");
});
it("rejects async settings and session saves when persistence fails", async () => {
const dir = fs.mkdtempSync(path.join(os.tmpdir(), "rd-store-async-errors-"));
tempDirs.push(dir);
const paths = createStoragePaths(dir);
const settingsFailure = vi.spyOn(fs.promises, "writeFile")
.mockRejectedValueOnce(new Error("settings write failed"));
await expect(saveSettingsAsync(paths, defaultSettings())).rejects.toThrow("settings write failed");
settingsFailure.mockRestore();
const sessionFailure = vi.spyOn(fs.promises, "open")
.mockRejectedValueOnce(new Error("session write failed"));
await expect(saveSessionAsync(paths, emptySession())).rejects.toThrow("session write failed");
sessionFailure.mockRestore();
});
it("keeps newer synchronous settings and session saves when older async commits resume", async () => { it("keeps newer synchronous settings and session saves when older async commits resume", async () => {
const dir = fs.mkdtempSync(path.join(os.tmpdir(), "rd-store-sync-wins-")); const dir = fs.mkdtempSync(path.join(os.tmpdir(), "rd-store-sync-wins-"));
tempDirs.push(dir); tempDirs.push(dir);
@@ -2260,6 +2630,8 @@ describe("settings storage", () => {
releaseSessionWrite(); releaseSessionWrite();
const barrier = await barrierPromise; const barrier = await barrierPromise;
await Promise.all([oldSettingsSave, oldSessionSave]); await Promise.all([oldSettingsSave, oldSessionSave]);
expect(loadSettings(paths).packageName).toBe("old-settings");
expect(loadSession(paths).summaryText).toBe("old-session");
const blockedSettingsSave = saveSettingsAsync(paths, oldSettings); const blockedSettingsSave = saveSettingsAsync(paths, oldSettings);
const blockedSessionSave = saveSessionAsync(paths, oldSession); const blockedSessionSave = saveSessionAsync(paths, oldSession);
@@ -2295,6 +2667,229 @@ describe("settings storage", () => {
await nextBarrier.release({ replayBlocked: false }); await nextBarrier.release({ replayBlocked: false });
}); });
it("cleans up a barrier acquisition after an active write fails", async () => {
const dir = fs.mkdtempSync(path.join(os.tmpdir(), "rd-store-barrier-acquire-failure-"));
tempDirs.push(dir);
const paths = createStoragePaths(dir);
let markWriteStarted = () => {};
const writeStarted = new Promise<void>((resolve) => { markWriteStarted = resolve; });
let rejectWrite = (_error: Error) => {};
const writeRelease = new Promise<void>((_resolve, reject) => { rejectWrite = reject; });
const writeFile = fs.promises.writeFile.bind(fs.promises);
vi.spyOn(fs.promises, "writeFile").mockImplementation((filePath, data, options) => {
if (String(filePath) === `${paths.configFile}.settings.tmp`) {
markWriteStarted();
return writeRelease;
}
return writeFile(filePath, data, options);
});
const activeSave = saveSettingsAsync(paths, { ...defaultSettings(), packageName: "failing" })
.then(() => "resolved", (error: unknown) => `rejected:${String((error as Error).message || error)}`);
await writeStarted;
const barrierAttempt = acquirePersistenceBarrier();
const blockedSave = saveSessionAsync(paths, { ...emptySession(), summaryText: "blocked" })
.then(() => "resolved", (error: unknown) => `rejected:${String((error as Error).message || error)}`);
rejectWrite(new Error("active write failed"));
await expect(barrierAttempt).rejects.toThrow("active write failed");
expect(await activeSave).toBe("rejected:active write failed");
expect(await Promise.race([
blockedSave,
new Promise<string>((resolve) => setTimeout(() => resolve("timeout"), 100))
])).toBe("rejected:active write failed");
vi.restoreAllMocks();
await saveSettingsAsync(paths, { ...defaultSettings(), packageName: "after-failure" });
expect(loadSettings(paths).packageName).toBe("after-failure");
const nextBarrier = await acquirePersistenceBarrier();
await nextBarrier.release({ replayBlocked: false });
});
it("requeues a pending settings save when barrier acquisition fails", async () => {
const dir = fs.mkdtempSync(path.join(os.tmpdir(), "rd-store-barrier-settings-requeue-"));
tempDirs.push(dir);
const paths = createStoragePaths(dir);
const writeFile = fs.promises.writeFile.bind(fs.promises);
let markWriteStarted = () => {};
const writeStarted = new Promise<void>((resolve) => { markWriteStarted = resolve; });
let rejectWrite = (_error: Error) => {};
const writeRelease = new Promise<void>((_resolve, reject) => { rejectWrite = reject; });
let settingsWrites = 0;
vi.spyOn(fs.promises, "writeFile").mockImplementation((filePath, data, options) => {
if (String(filePath) === `${paths.configFile}.settings.tmp` && settingsWrites++ === 0) {
markWriteStarted();
return writeRelease;
}
return writeFile(filePath, data, options);
});
const activeSave = saveSettingsAsync(paths, { ...defaultSettings(), packageName: "active" })
.then(() => "resolved", (error: unknown) => `rejected:${String((error as Error).message || error)}`);
await writeStarted;
let queuedSettled = false;
const queuedSave = saveSettingsAsync(paths, { ...defaultSettings(), packageName: "queued-latest" })
.then(() => "resolved", (error: unknown) => `rejected:${String((error as Error).message || error)}`)
.finally(() => { queuedSettled = true; });
const barrierAttempt = acquirePersistenceBarrier();
await new Promise<void>((resolve) => setImmediate(resolve));
const settledBeforeFailure = queuedSettled;
rejectWrite(new Error("active settings write failed"));
await expect(barrierAttempt).rejects.toThrow("active settings write failed");
expect(await activeSave).toBe("rejected:active settings write failed");
expect(await queuedSave).toBe("resolved");
expect(settledBeforeFailure).toBe(false);
expect(loadSettings(paths).packageName).toBe("queued-latest");
});
it("requeues a pending session save when barrier acquisition fails", async () => {
const dir = fs.mkdtempSync(path.join(os.tmpdir(), "rd-store-barrier-session-requeue-"));
tempDirs.push(dir);
const paths = createStoragePaths(dir);
const openFile = fs.promises.open.bind(fs.promises);
let markOpenStarted = () => {};
const openStarted = new Promise<void>((resolve) => { markOpenStarted = resolve; });
let rejectOpen = (_error: Error) => {};
const openRelease = new Promise<never>((_resolve, reject) => { rejectOpen = reject; });
let sessionOpens = 0;
vi.spyOn(fs.promises, "open").mockImplementation((filePath, flags, mode) => {
if (String(filePath) === `${paths.sessionFile}.async.tmp` && sessionOpens++ === 0) {
markOpenStarted();
return openRelease;
}
return openFile(filePath, flags, mode);
});
const activeSave = saveSessionAsync(paths, { ...emptySession(), summaryText: "active" })
.then(() => "resolved", (error: unknown) => `rejected:${String((error as Error).message || error)}`);
await openStarted;
let queuedSettled = false;
const queuedSave = saveSessionAsync(paths, { ...emptySession(), summaryText: "queued-latest" })
.then(() => "resolved", (error: unknown) => `rejected:${String((error as Error).message || error)}`)
.finally(() => { queuedSettled = true; });
const barrierAttempt = acquirePersistenceBarrier();
await new Promise<void>((resolve) => setImmediate(resolve));
const settledBeforeFailure = queuedSettled;
rejectOpen(new Error("active session open failed"));
await expect(barrierAttempt).rejects.toThrow("active session open failed");
expect(await activeSave).toBe("rejected:active session open failed");
expect(await queuedSave).toBe("resolved");
expect(settledBeforeFailure).toBe(false);
expect(loadSession(paths).summaryText).toBe("queued-latest");
});
it("rejects pre-barrier queued saves when a successful import barrier discards them", async () => {
const dir = fs.mkdtempSync(path.join(os.tmpdir(), "rd-store-barrier-explicit-discard-"));
tempDirs.push(dir);
const paths = createStoragePaths(dir);
saveSettings(paths, defaultSettings());
saveSession(paths, emptySession());
const writeFile = fs.promises.writeFile.bind(fs.promises);
const openFile = fs.promises.open.bind(fs.promises);
let releaseSettingsWrite = () => {};
let releaseSessionWrite = () => {};
let markSettingsWriteStarted = () => {};
let markSessionWriteStarted = () => {};
const settingsWriteStarted = new Promise<void>((resolve) => { markSettingsWriteStarted = resolve; });
const sessionWriteStarted = new Promise<void>((resolve) => { markSessionWriteStarted = resolve; });
const settingsWriteRelease = new Promise<void>((resolve) => { releaseSettingsWrite = resolve; });
const sessionWriteRelease = new Promise<void>((resolve) => { releaseSessionWrite = resolve; });
vi.spyOn(fs.promises, "writeFile").mockImplementation(async (filePath, data, options) => {
await writeFile(filePath, data, options);
if (String(filePath) === `${paths.configFile}.settings.tmp`) {
markSettingsWriteStarted();
await settingsWriteRelease;
}
});
vi.spyOn(fs.promises, "open").mockImplementation(async (filePath, flags, mode) => {
const handle = await openFile(filePath, flags, mode);
if (String(filePath) === `${paths.sessionFile}.async.tmp`) {
const originalWrite = handle.writeFile.bind(handle);
handle.writeFile = async (...args: Parameters<typeof handle.writeFile>) => {
const result = await originalWrite(...args);
markSessionWriteStarted();
await sessionWriteRelease;
return result;
};
}
return handle;
});
const activeSettings = saveSettingsAsync(paths, { ...defaultSettings(), packageName: "active" });
const activeSession = saveSessionAsync(paths, { ...emptySession(), summaryText: "active" });
await Promise.all([settingsWriteStarted, sessionWriteStarted]);
const queuedSettings = saveSettingsAsync(paths, { ...defaultSettings(), packageName: "discarded" })
.then(() => "resolved", (error: unknown) => `rejected:${String((error as Error).message || error)}`);
const queuedSession = saveSessionAsync(paths, { ...emptySession(), summaryText: "discarded" })
.then(() => "resolved", (error: unknown) => `rejected:${String((error as Error).message || error)}`);
const barrierAttempt = acquirePersistenceBarrier();
releaseSettingsWrite();
releaseSessionWrite();
const barrier = await barrierAttempt;
await Promise.all([activeSettings, activeSession]);
expect(await queuedSettings).toMatch(/^rejected:.*barrier/i);
expect(await queuedSession).toMatch(/^rejected:.*barrier/i);
saveSettings(paths, { ...defaultSettings(), packageName: "imported" });
saveSession(paths, { ...emptySession(), summaryText: "imported" });
await barrier.release({ replayBlocked: false });
expect(loadSettings(paths).packageName).toBe("imported");
expect(loadSession(paths).summaryText).toBe("imported");
});
it("waits for every started replay write before releasing a failed barrier", async () => {
const dir = fs.mkdtempSync(path.join(os.tmpdir(), "rd-store-barrier-replay-failure-"));
tempDirs.push(dir);
const paths = createStoragePaths(dir);
const openFile = fs.promises.open.bind(fs.promises);
let markSessionWriteStarted = () => {};
const sessionWriteStarted = new Promise<void>((resolve) => { markSessionWriteStarted = resolve; });
let releaseSessionWrite = () => {};
const sessionWriteRelease = new Promise<void>((resolve) => { releaseSessionWrite = resolve; });
const writeFile = fs.promises.writeFile.bind(fs.promises);
vi.spyOn(fs.promises, "writeFile").mockImplementation((filePath, data, options) => {
if (String(filePath) === `${paths.configFile}.settings.tmp`) {
return Promise.reject(new Error("replay settings failed"));
}
return writeFile(filePath, data, options);
});
vi.spyOn(fs.promises, "open").mockImplementation(async (filePath, flags, mode) => {
const handle = await openFile(filePath, flags, mode);
if (String(filePath) === `${paths.sessionFile}.async.tmp`) {
const writeFile = handle.writeFile.bind(handle);
handle.writeFile = async (...args: Parameters<typeof handle.writeFile>) => {
const result = await writeFile(...args);
markSessionWriteStarted();
await sessionWriteRelease;
return result;
};
}
return handle;
});
const barrier = await acquirePersistenceBarrier();
const settingsSave = saveSettingsAsync(paths, { ...defaultSettings(), packageName: "replayed-settings" })
.then(() => "resolved", (error: unknown) => `rejected:${String((error as Error).message || error)}`);
const sessionSave = saveSessionAsync(paths, { ...emptySession(), summaryText: "replayed-session" })
.then(() => "resolved", (error: unknown) => `rejected:${String((error as Error).message || error)}`);
let releaseSettled = false;
const releaseResult = barrier.release({ replayBlocked: true })
.then(() => "resolved", (error: unknown) => `rejected:${String((error as Error).message || error)}`)
.finally(() => { releaseSettled = true; });
await sessionWriteStarted;
await new Promise<void>((resolve) => setImmediate(resolve));
expect(releaseSettled).toBe(false);
releaseSessionWrite();
expect(await releaseResult).toBe("rejected:replay settings failed");
expect(await settingsSave).toBe("rejected:replay settings failed");
expect(await sessionSave).toBe("resolved");
const nextBarrier = await acquirePersistenceBarrier();
await nextBarrier.release({ replayBlocked: false });
});
it("creates session backup before sync and async session overwrites", async () => { it("creates session backup before sync and async session overwrites", async () => {
const dir = fs.mkdtempSync(path.join(os.tmpdir(), "rd-store-")); const dir = fs.mkdtempSync(path.join(os.tmpdir(), "rd-store-"));
tempDirs.push(dir); tempDirs.push(dir);
+427 -9
View File
@@ -1,5 +1,6 @@
import fs from "node:fs"; import fs from "node:fs";
import crypto from "node:crypto"; import crypto from "node:crypto";
import { EventEmitter } from "node:events";
import { afterEach, describe, expect, it, vi } from "vitest"; import { afterEach, describe, expect, it, vi } from "vitest";
const { spawnMock, unrefMock, onceMock } = vi.hoisted(() => { const { spawnMock, unrefMock, onceMock } = vi.hoisted(() => {
@@ -27,7 +28,7 @@ vi.mock("node:child_process", () => ({
spawn: spawnMock spawn: spawnMock
})); }));
import { buildInstallerLaunchArgs, checkGitHubUpdate, installLatestUpdate, isRemoteNewer, normalizeUpdateRepo, parseVersionParts } from "../src/main/update"; import { abortActiveUpdateDownload, buildInstallerLaunchArgs, checkGitHubUpdate, installLatestUpdate, isRemoteNewer, normalizeUpdateRepo, parseVersionParts } from "../src/main/update";
import { APP_VERSION } from "../src/main/constants"; import { APP_VERSION } from "../src/main/constants";
import { UpdateCheckResult, UpdateInstallProgress } from "../src/shared/types"; import { UpdateCheckResult, UpdateInstallProgress } from "../src/shared/types";
@@ -41,7 +42,14 @@ function sha512Hex(buffer: Buffer): string {
return crypto.createHash("sha512").update(buffer).digest("hex"); return crypto.createHash("sha512").update(buffer).digest("hex");
} }
function createExecutablePayload() {
const payload = Buffer.alloc(128 * 1024);
payload.write("MZ");
return payload;
}
afterEach(() => { afterEach(() => {
abortActiveUpdateDownload();
globalThis.fetch = originalFetch; globalThis.fetch = originalFetch;
spawnMock.mockClear(); spawnMock.mockClear();
unrefMock.mockClear(); unrefMock.mockClear();
@@ -50,6 +58,416 @@ afterEach(() => {
}); });
describe("update", () => { describe("update", () => {
it("settles a backpressured update write when the target stream errors", async () => {
class FailingWriteStream extends EventEmitter {
private markWriteStarted!: () => void;
readonly writeStarted = new Promise<void>((resolve) => {
this.markWriteStarted = resolve;
});
write(): boolean {
this.markWriteStarted();
return false;
}
end(callback?: () => void): this {
callback?.();
return this;
}
destroy(): this {
return this;
}
}
const stream = new FailingWriteStream();
vi.spyOn(fs, "createWriteStream").mockReturnValue(stream as unknown as ReturnType<typeof fs.createWriteStream>);
globalThis.fetch = (async (): Promise<Response> => new Response(Buffer.alloc(160 * 1024, 1), {
status: 200,
headers: { "Content-Length": String(160 * 1024) }
})) as typeof fetch;
const pending = installLatestUpdate("owner/repo", {
updateAvailable: true,
currentVersion: APP_VERSION,
latestVersion: "9.9.9",
latestTag: "",
releaseUrl: "https://example.invalid/release",
setupAssetUrl: "https://example.invalid/",
setupAssetName: "",
setupAssetDigest: `sha256:${"a".repeat(64)}`
});
await stream.writeStarted;
const writeError = Object.assign(new Error("disk full"), { code: "ENOSPC" });
stream.emit("error", writeError);
const timeout = Symbol("timeout");
const outcome = await Promise.race([
pending,
new Promise<typeof timeout>((resolve) => setTimeout(() => resolve(timeout), 100))
]);
if (outcome === timeout) {
stream.emit("drain");
await pending;
}
expect(outcome).not.toBe(timeout);
expect(outcome).toEqual(expect.objectContaining({ started: false }));
expect((outcome as { message: string }).message).toMatch(/disk full|ENOSPC/i);
const next = await installLatestUpdate("owner/repo", {
updateAvailable: false,
currentVersion: APP_VERSION,
latestVersion: APP_VERSION,
latestTag: `v${APP_VERSION}`,
releaseUrl: "https://example.invalid/release"
});
expect(next.message).not.toBe("Update-Download läuft bereits");
});
it("settles shutdown abort while an update write waits for drain", async () => {
class BackpressuredWriteStream extends EventEmitter {
private markWriteStarted!: () => void;
private wasDestroyed = false;
readonly writeStarted = new Promise<void>((resolve) => {
this.markWriteStarted = resolve;
});
write(): boolean {
this.markWriteStarted();
return false;
}
end(callback?: () => void): this {
callback?.();
return this;
}
destroy(): this {
this.wasDestroyed = true;
return this;
}
emitLateDestroyError(error: Error): boolean {
if (!this.wasDestroyed) {
throw new Error("stream was not destroyed");
}
const handled = this.listenerCount("error") > 0;
if (handled) {
this.emit("error", error);
}
this.emit("close");
return handled;
}
}
const stream = new BackpressuredWriteStream();
vi.spyOn(fs, "createWriteStream").mockReturnValue(stream as unknown as ReturnType<typeof fs.createWriteStream>);
globalThis.fetch = (async (): Promise<Response> => new Response(Buffer.alloc(160 * 1024, 1), {
status: 200,
headers: { "Content-Length": String(160 * 1024) }
})) as typeof fetch;
const pending = installLatestUpdate("owner/repo", {
updateAvailable: true,
currentVersion: APP_VERSION,
latestVersion: "9.9.9",
latestTag: "",
releaseUrl: "https://example.invalid/release",
setupAssetUrl: "https://example.invalid/",
setupAssetName: "",
setupAssetDigest: `sha256:${"a".repeat(64)}`
});
await stream.writeStarted;
abortActiveUpdateDownload();
const timeout = Symbol("timeout");
const outcome = await Promise.race([
pending,
new Promise<typeof timeout>((resolve) => setTimeout(() => resolve(timeout), 100))
]);
if (outcome === timeout) {
stream.emit("drain");
await pending;
}
expect(outcome).not.toBe(timeout);
expect(outcome).toEqual(expect.objectContaining({ started: false }));
expect((outcome as { message: string }).message).toMatch(/aborted:update_shutdown/i);
expect(stream.emitLateDestroyError(new Error("late destroy failure"))).toBe(true);
expect(stream.listenerCount("error")).toBe(0);
const next = await installLatestUpdate("owner/repo", {
updateAvailable: false,
currentVersion: APP_VERSION,
latestVersion: APP_VERSION,
latestTag: `v${APP_VERSION}`,
releaseUrl: "https://example.invalid/release"
});
expect(next.message).not.toBe("Update-Download läuft bereits");
});
it("does not wait for a stalled body cancellation during shutdown", async () => {
class BackpressuredWriteStream extends EventEmitter {
private markWriteStarted!: () => void;
private markDestroyed!: () => void;
readonly writeStarted = new Promise<void>((resolve) => {
this.markWriteStarted = resolve;
});
readonly destroyed = new Promise<void>((resolve) => {
this.markDestroyed = resolve;
});
write(): boolean {
this.markWriteStarted();
return false;
}
end(callback?: () => void): this {
callback?.();
return this;
}
destroy(): this {
this.markDestroyed();
this.emit("close");
return this;
}
}
const stream = new BackpressuredWriteStream();
const cancelState: { release?: () => void } = {};
let markCancellationRequested!: () => void;
const cancellationRequested = new Promise<void>((resolve) => {
markCancellationRequested = resolve;
});
const responseBody = new ReadableStream<Uint8Array>({
start(controller) {
controller.enqueue(new Uint8Array(160 * 1024));
},
cancel() {
markCancellationRequested();
return new Promise<void>((resolve) => {
cancelState.release = resolve;
});
}
});
vi.spyOn(fs, "createWriteStream").mockReturnValue(stream as unknown as ReturnType<typeof fs.createWriteStream>);
globalThis.fetch = (async (): Promise<Response> => new Response(responseBody, {
status: 200,
headers: { "Content-Length": String(160 * 1024) }
})) as typeof fetch;
const pending = installLatestUpdate("owner/repo", {
updateAvailable: true,
currentVersion: APP_VERSION,
latestVersion: "9.9.9",
latestTag: "",
releaseUrl: "https://example.invalid/release",
setupAssetUrl: "https://example.invalid/",
setupAssetName: "",
setupAssetDigest: `sha256:${"a".repeat(64)}`
});
await stream.writeStarted;
abortActiveUpdateDownload();
const timeout = Symbol("timeout");
const outcome = await Promise.race([
pending,
new Promise<typeof timeout>((resolve) => setTimeout(() => resolve(timeout), 100))
]);
const cancellationOutcome = await Promise.race([
cancellationRequested.then(() => true),
new Promise<false>((resolve) => setTimeout(() => resolve(false), 100))
]);
if (outcome === timeout) {
cancelState.release?.();
await pending;
}
cancelState.release?.();
expect(outcome).not.toBe(timeout);
expect(cancellationOutcome).toBe(true);
expect(outcome).toEqual(expect.objectContaining({ started: false }));
expect((outcome as { message: string }).message).toMatch(/aborted:update_shutdown/i);
await expect(stream.destroyed).resolves.toBeUndefined();
});
it("propagates the original write error from the end callback", async () => {
const finalWriteError = Object.assign(new Error("final disk failure"), { code: "EIO" });
class FinalizingWriteStream extends EventEmitter {
write(): boolean {
return true;
}
end(callback?: (error?: Error) => void): this {
callback?.(finalWriteError);
this.emit("error", finalWriteError);
this.emit("close");
return this;
}
destroy(): this {
this.emit("close");
return this;
}
}
const stream = new FinalizingWriteStream();
vi.spyOn(fs, "createWriteStream").mockReturnValue(stream as unknown as ReturnType<typeof fs.createWriteStream>);
globalThis.fetch = (async (): Promise<Response> => new Response(Buffer.alloc(160 * 1024, 1), {
status: 200,
headers: { "Content-Length": String(160 * 1024) }
})) as typeof fetch;
const outcome = await installLatestUpdate("owner/repo", {
updateAvailable: true,
currentVersion: APP_VERSION,
latestVersion: "9.9.9",
latestTag: "",
releaseUrl: "https://example.invalid/release",
setupAssetUrl: "https://example.invalid/",
setupAssetName: "",
setupAssetDigest: `sha256:${"a".repeat(64)}`
});
expect(outcome).toEqual(expect.objectContaining({ started: false }));
expect(outcome.message).toMatch(/final disk failure|EIO/i);
});
it("waits for close and propagates a late close error after a successful end callback", async () => {
const lateCloseError = Object.assign(new Error("late close failure EIO"), { code: "EIO" });
class LateCloseFailureStream extends EventEmitter {
private closed = false;
write(): boolean {
return true;
}
end(callback?: (error?: Error) => void): this {
callback?.();
this.emit("finish");
queueMicrotask(() => {
this.emit("error", lateCloseError);
this.closed = true;
this.emit("close");
});
return this;
}
destroy(): this {
if (!this.closed) {
this.closed = true;
this.emit("close");
}
return this;
}
}
const stream = new LateCloseFailureStream();
const renameSpy = vi.spyOn(fs.promises, "rename").mockRejectedValue(new Error("rename must not run"));
vi.spyOn(fs, "createWriteStream").mockReturnValue(stream as unknown as ReturnType<typeof fs.createWriteStream>);
globalThis.fetch = (async (): Promise<Response> => new Response(Buffer.alloc(160 * 1024, 1), {
status: 200,
headers: { "Content-Length": String(160 * 1024) }
})) as typeof fetch;
const outcome = await installLatestUpdate("owner/repo", {
updateAvailable: true,
currentVersion: APP_VERSION,
latestVersion: "9.9.9",
latestTag: "",
releaseUrl: "https://example.invalid/release",
setupAssetUrl: "https://example.invalid/",
setupAssetName: "",
setupAssetDigest: `sha256:${"a".repeat(64)}`
});
expect(outcome).toEqual(expect.objectContaining({ started: false }));
expect(outcome.message).toMatch(/late close failure|EIO/i);
expect(renameSpy).not.toHaveBeenCalled();
expect(stream.listenerCount("error")).toBe(0);
});
it("settles an idle timeout while an update write waits for drain", async () => {
const previousTimeout = process.env.RD_UPDATE_BODY_IDLE_TIMEOUT_MS;
process.env.RD_UPDATE_BODY_IDLE_TIMEOUT_MS = "1000";
class BackpressuredWriteStream extends EventEmitter {
private markWriteStarted!: () => void;
private markDestroyed!: () => void;
readonly writeStarted = new Promise<void>((resolve) => {
this.markWriteStarted = resolve;
});
readonly destroyed = new Promise<void>((resolve) => {
this.markDestroyed = resolve;
});
write(): boolean {
this.markWriteStarted();
return false;
}
end(callback?: () => void): this {
callback?.();
return this;
}
destroy(): this {
this.markDestroyed();
this.emit("close");
return this;
}
}
const stream = new BackpressuredWriteStream();
const externalErrorListener = (): void => undefined;
stream.on("error", externalErrorListener);
vi.spyOn(fs, "createWriteStream").mockReturnValue(stream as unknown as ReturnType<typeof fs.createWriteStream>);
globalThis.fetch = (async (): Promise<Response> => new Response(Buffer.alloc(160 * 1024, 1), {
status: 200,
headers: { "Content-Length": String(160 * 1024) }
})) as typeof fetch;
try {
const pending = installLatestUpdate("owner/repo", {
updateAvailable: true,
currentVersion: APP_VERSION,
latestVersion: "9.9.9",
latestTag: "",
releaseUrl: "https://example.invalid/release",
setupAssetUrl: "https://example.invalid/",
setupAssetName: "",
setupAssetDigest: `sha256:${"a".repeat(64)}`
});
await stream.writeStarted;
const timeout = Symbol("timeout");
const idleOutcome = await Promise.race([
stream.destroyed.then(() => "destroyed" as const),
new Promise<typeof timeout>((resolve) => setTimeout(() => resolve(timeout), 1600))
]);
abortActiveUpdateDownload();
const outcome = await pending;
expect(idleOutcome).toBe("destroyed");
expect(outcome).toEqual(expect.objectContaining({ started: false }));
expect(stream.listenerCount("drain")).toBe(0);
expect(stream.listeners("error")).toEqual([externalErrorListener]);
} finally {
if (previousTimeout === undefined) {
delete process.env.RD_UPDATE_BODY_IDLE_TIMEOUT_MS;
} else {
process.env.RD_UPDATE_BODY_IDLE_TIMEOUT_MS = previousTimeout;
}
}
});
it("always refreshes release metadata before installing instead of using the previous check result", () => { it("always refreshes release metadata before installing instead of using the previous check result", () => {
const controller = fs.readFileSync(new URL("../src/main/app-controller.ts", import.meta.url), "utf8"); const controller = fs.readFileSync(new URL("../src/main/app-controller.ts", import.meta.url), "utf8");
const install = controller.slice(controller.indexOf("public async installUpdate"), controller.indexOf("public addLinks")); const install = controller.slice(controller.indexOf("public async installUpdate"), controller.indexOf("public addLinks"));
@@ -173,7 +591,7 @@ describe("update", () => {
}); });
it("falls back to alternate download URL when setup asset URL returns 404", async () => { it("falls back to alternate download URL when setup asset URL returns 404", async () => {
const executablePayload = fs.readFileSync(process.execPath); const executablePayload = createExecutablePayload();
const executableDigest = sha256Hex(executablePayload); const executableDigest = sha256Hex(executablePayload);
const requestedUrls: string[] = []; const requestedUrls: string[] = [];
globalThis.fetch = (async (input: RequestInfo | URL): Promise<Response> => { globalThis.fetch = (async (input: RequestInfo | URL): Promise<Response> => {
@@ -210,7 +628,7 @@ describe("update", () => {
}); });
it("skips draft tag payload and resolves setup asset from stable latest release", async () => { it("skips draft tag payload and resolves setup asset from stable latest release", async () => {
const executablePayload = fs.readFileSync(process.execPath); const executablePayload = createExecutablePayload();
const requestedUrls: string[] = []; const requestedUrls: string[] = [];
globalThis.fetch = (async (input: RequestInfo | URL): Promise<Response> => { globalThis.fetch = (async (input: RequestInfo | URL): Promise<Response> => {
@@ -351,7 +769,7 @@ describe("update", () => {
}, 20000); }, 20000);
it("blocks installer start when SHA256 digest mismatches", async () => { it("blocks installer start when SHA256 digest mismatches", async () => {
const executablePayload = fs.readFileSync(process.execPath); const executablePayload = createExecutablePayload();
globalThis.fetch = (async (input: RequestInfo | URL): Promise<Response> => { globalThis.fetch = (async (input: RequestInfo | URL): Promise<Response> => {
const url = typeof input === "string" ? input : input instanceof URL ? input.toString() : input.url; const url = typeof input === "string" ? input : input instanceof URL ? input.toString() : input.url;
if (url.includes("mismatch-setup.exe")) { if (url.includes("mismatch-setup.exe")) {
@@ -380,7 +798,7 @@ describe("update", () => {
}); });
it("blocks installer start when no digest can be resolved", async () => { it("blocks installer start when no digest can be resolved", async () => {
const executablePayload = fs.readFileSync(process.execPath); const executablePayload = createExecutablePayload();
globalThis.fetch = (async (input: RequestInfo | URL): Promise<Response> => { globalThis.fetch = (async (input: RequestInfo | URL): Promise<Response> => {
const url = typeof input === "string" ? input : input instanceof URL ? input.toString() : input.url; const url = typeof input === "string" ? input : input instanceof URL ? input.toString() : input.url;
if (url.includes("unsigned-setup.exe")) { if (url.includes("unsigned-setup.exe")) {
@@ -409,7 +827,7 @@ describe("update", () => {
}); });
it("uses latest.yml SHA512 digest when API asset digest is missing", async () => { it("uses latest.yml SHA512 digest when API asset digest is missing", async () => {
const executablePayload = fs.readFileSync(process.execPath); const executablePayload = createExecutablePayload();
const digestSha512Hex = sha512Hex(executablePayload); const digestSha512Hex = sha512Hex(executablePayload);
const digestSha512Base64 = Buffer.from(digestSha512Hex, "hex").toString("base64"); const digestSha512Base64 = Buffer.from(digestSha512Hex, "hex").toString("base64");
const requestedUrls: string[] = []; const requestedUrls: string[] = [];
@@ -480,7 +898,7 @@ describe("update", () => {
}); });
it("rejects installer when latest.yml SHA512 digest does not match", async () => { it("rejects installer when latest.yml SHA512 digest does not match", async () => {
const executablePayload = fs.readFileSync(process.execPath); const executablePayload = createExecutablePayload();
const wrongDigestBase64 = Buffer.alloc(64, 0x13).toString("base64"); const wrongDigestBase64 = Buffer.alloc(64, 0x13).toString("base64");
globalThis.fetch = (async (input: RequestInfo | URL): Promise<Response> => { globalThis.fetch = (async (input: RequestInfo | URL): Promise<Response> => {
@@ -547,7 +965,7 @@ describe("update", () => {
}); });
it("emits install progress events while downloading and launching update", async () => { it("emits install progress events while downloading and launching update", async () => {
const executablePayload = fs.readFileSync(process.execPath); const executablePayload = createExecutablePayload();
const digest = sha256Hex(executablePayload); const digest = sha256Hex(executablePayload);
globalThis.fetch = (async (input: RequestInfo | URL): Promise<Response> => { globalThis.fetch = (async (input: RequestInfo | URL): Promise<Response> => {
@@ -595,7 +1013,7 @@ describe("update", () => {
}); });
it("keeps the application running when Windows rejects the installer process", async () => { it("keeps the application running when Windows rejects the installer process", async () => {
const executablePayload = fs.readFileSync(process.execPath); const executablePayload = createExecutablePayload();
const digest = sha256Hex(executablePayload); const digest = sha256Hex(executablePayload);
globalThis.fetch = (async (): Promise<Response> => new Response(executablePayload, { globalThis.fetch = (async (): Promise<Response> => new Response(executablePayload, {
status: 200, status: 200,