From 586ebea201824a89bfcbd1794f383aa13996cc17 Mon Sep 17 00:00:00 2001
From: Sucukdeluxe <Sucukdeluxe@users.noreply.github.com>
Date: Sat, 15 Aug 2026 02:17:24 +0200
Subject: [PATCH] fix(accounts): simplify identity copy tooltips

Show only the copy action in populated username and email cell tooltips instead of repeating values already visible in the table. Preserve explicit accessible button labels and add German and English regression coverage.
---
 src/renderer/i18n.ts                             | 2 +-
 src/renderer/views/settings/AccountWorkspace.tsx | 2 +-
 tests/i18n.test.ts                               | 1 +
 tests/settings-view.test.tsx                     | 3 +++
 4 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/src/renderer/i18n.ts b/src/renderer/i18n.ts
index 678d219..0f7bd76 100644
--- a/src/renderer/i18n.ts
+++ b/src/renderer/i18n.ts
@@ -184,7 +184,7 @@ const pairs = [
   ["· API-Quota konnte nicht geladen werden", "· API quota could not be loaded"], ["Name kopiert", "Name copied"], ["Link kopiert", "Link copied"],
   ["Download-Ziel", "Download destination"], ["Support-Logs:", "Support logs:"], ["Session-Logs", "Session logs"], ["Paket-Logs", "Package logs"], ["Support-Bundle:", "Support bundle:"], ["Warnungen:", "Warnings:"],
   ["Web-Login", "Web login"], ["API-Token", "API token"], ["erfolgreich", "successful"], ["Unbekannt", "Unknown"], ["Abgebrochen", "Cancelled"], ["Passwort", "Password"],
-  ["Sicherung", "Backup"], ["Session-Log", "Session log"], ["Remote-Support", "Remote support"], ["Kopieren", "Copy"], ["Verbindungscode", "Connection code"], ["deaktiviert", "disabled"]
+  ["Sicherung", "Backup"], ["Session-Log", "Session log"], ["Remote-Support", "Remote support"], ["Kopieren", "Copy"], ["Klicken zum Kopieren", "Click to copy"], ["Verbindungscode", "Connection code"], ["deaktiviert", "disabled"]
 ] as const;
 
 const deToEn = new Map<string, string>(pairs);
diff --git a/src/renderer/views/settings/AccountWorkspace.tsx b/src/renderer/views/settings/AccountWorkspace.tsx
index 728b405..fb9e028 100644
--- a/src/renderer/views/settings/AccountWorkspace.tsx
+++ b/src/renderer/views/settings/AccountWorkspace.tsx
@@ -142,7 +142,7 @@ function renderAccountIdentityCell({
 }): ReactElement {
   const copyable = value.trim() !== "" && value !== "—";
   return (
-    <span className={className} role="cell" title={copyable ? `${value}\nKlicken zum Kopieren` : value}>
+    <span className={className} role="cell" title={copyable ? "Klicken zum Kopieren" : value}>
       {copyable ? (
         <button
           aria-label={`${label} kopieren`}
diff --git a/tests/i18n.test.ts b/tests/i18n.test.ts
index a506c64..a78d63c 100644
--- a/tests/i18n.test.ts
+++ b/tests/i18n.test.ts
@@ -70,6 +70,7 @@ describe("renderer localization", () => {
       .toBe("Do you really want to remove the empty collection Tab 2?");
     expect(translateUiText("Link kopieren", "en")).toBe("Copy Link");
     expect(translateUiText("example.test Klicken zum Kopieren", "en")).toBe("Click to copy example.test");
+    expect(translateUiText("Klicken zum Kopieren", "en")).toBe("Click to copy");
     expect(translateUiText("Geschwindigkeit verschieben", "en")).toBe("Move Speed");
     expect(translateUiText("Geschwindigkeit nach links verschieben", "en")).toBe("Move Speed left");
     expect(translateUiText("Move Speed right", "de")).toBe("Geschwindigkeit nach rechts verschieben");
diff --git a/tests/settings-view.test.tsx b/tests/settings-view.test.tsx
index 2f239fb..4ac9fd5 100644
--- a/tests/settings-view.test.tsx
+++ b/tests/settings-view.test.tsx
@@ -834,6 +834,8 @@ describe("account workspace", () => {
       })
     });
     const buttons = findElements(tree, (element) => String(element.props.className || "").includes("settings-account-copy-button"));
+    const copyableCells = findElements(tree, (element) => ["settings-account-username", "settings-account-email"].includes(String(element.props.className || "")))
+      .filter((element) => element.props.title === "Klicken zum Kopieren");
     const username = buttons.find((button) => button.props["aria-label"] === "Benutzername kopieren");
     const email = buttons.find((button) => button.props["aria-label"] === "E-Mail kopieren");
     let stopped = 0;
@@ -843,6 +845,7 @@ describe("account workspace", () => {
     username?.props.onDoubleClick({ stopPropagation: () => { stopped += 1; } });
 
     expect(buttons.some((button) => button.props.children === "—")).toBe(false);
+    expect(copyableCells).toHaveLength(buttons.length);
     expect(copies).toEqual([
       "Benutzername:stored-user",
       "E-Mail:verified@example.test"