Harden resume flows and ship v1.1.23 stability fixes

tests/download-manager.test.ts

@@ -0,0 +1,859 @@
+import fs from "node:fs";
+import os from "node:os";
+import path from "node:path";
+import http from "node:http";
+import { once } from "node:events";
+import { afterEach, describe, expect, it } from "vitest";
+import { DownloadManager } from "../src/main/download-manager";
+import { defaultSettings } from "../src/main/constants";
+import { createStoragePaths, emptySession } from "../src/main/storage";
+
+const tempDirs: string[] = [];
+const originalFetch = globalThis.fetch;
+
+async function waitFor(predicate: () => boolean, timeoutMs = 15000): Promise<void> {
+  const started = Date.now();
+  while (!predicate()) {
+    if (Date.now() - started > timeoutMs) {
+      throw new Error("waitFor timeout");
+    }
+    await new Promise((resolve) => setTimeout(resolve, 60));
+  }
+}
+
+afterEach(() => {
+  globalThis.fetch = originalFetch;
+  for (const dir of tempDirs.splice(0)) {
+    fs.rmSync(dir, { recursive: true, force: true });
+  }
+});
+
+describe("download manager", () => {
+  it("retries interrupted streams and resumes download", async () => {
+    const root = fs.mkdtempSync(path.join(os.tmpdir(), "rd-dm-"));
+    tempDirs.push(root);
+    const binary = Buffer.alloc(512 * 1024, 11);
+    let directCalls = 0;
+
+    const server = http.createServer((req, res) => {
+      if ((req.url || "") !== "/direct") {
+        res.statusCode = 404;
+        res.end("not-found");
+        return;
+      }
+
+      directCalls += 1;
+      const range = String(req.headers.range || "");
+      const match = range.match(/bytes=(\d+)-/i);
+      const start = match ? Number(match[1]) : 0;
+
+      if (directCalls === 1 && start === 0) {
+        res.statusCode = 200;
+        res.setHeader("Accept-Ranges", "bytes");
+        res.setHeader("Content-Length", String(binary.length));
+        res.write(binary.subarray(0, Math.floor(binary.length / 2)));
+        res.socket?.destroy();
+        return;
+      }
+
+      const chunk = binary.subarray(start);
+      if (start > 0) {
+        res.statusCode = 206;
+        res.setHeader("Content-Range", `bytes ${start}-${binary.length - 1}/${binary.length}`);
+      } else {
+        res.statusCode = 200;
+      }
+      res.setHeader("Accept-Ranges", "bytes");
+      res.setHeader("Content-Length", String(chunk.length));
+      res.end(chunk);
+    });
+
+    server.listen(0, "127.0.0.1");
+    await once(server, "listening");
+
+    const address = server.address();
+    if (!address || typeof address === "string") {
+      throw new Error("server address unavailable");
+    }
+    const directUrl = `http://127.0.0.1:${address.port}/direct`;
+
+    globalThis.fetch = async (input: RequestInfo | URL, init?: RequestInit): Promise<Response> => {
+      const url = typeof input === "string" ? input : input instanceof URL ? input.toString() : input.url;
+      if (url.includes("/unrestrict/link")) {
+        return new Response(
+          JSON.stringify({
+            download: directUrl,
+            filename: "episode.mkv",
+            filesize: binary.length
+          }),
+          {
+            status: 200,
+            headers: { "Content-Type": "application/json" }
+          }
+        );
+      }
+      return originalFetch(input, init);
+    };
+
+    try {
+      const manager = new DownloadManager(
+        {
+          ...defaultSettings(),
+          token: "rd-token",
+          outputDir: path.join(root, "downloads"),
+          extractDir: path.join(root, "extract"),
+          autoExtract: false,
+          autoReconnect: false
+        },
+        emptySession(),
+        createStoragePaths(path.join(root, "state"))
+      );
+
+      manager.addPackages([{ name: "retry", links: ["https://dummy/retry"] }]);
+      manager.start();
+      await waitFor(() => !manager.getSnapshot().session.running, 25000);
+
+      const item = Object.values(manager.getSnapshot().session.items)[0];
+      expect(item?.status).toBe("completed");
+      expect(item?.retries).toBeGreaterThan(0);
+      expect(directCalls).toBeGreaterThan(1);
+      expect(fs.existsSync(item.targetPath)).toBe(true);
+      expect(fs.statSync(item.targetPath).size).toBe(binary.length);
+    } finally {
+      server.close();
+      await once(server, "close");
+    }
+  });
+
+  it("assigns unique target paths for same filenames in parallel", async () => {
+    const root = fs.mkdtempSync(path.join(os.tmpdir(), "rd-dm-"));
+    tempDirs.push(root);
+    const binary = Buffer.alloc(64 * 1024, 9);
+
+    const server = http.createServer((req, res) => {
+      if ((req.url || "") !== "/same") {
+        res.statusCode = 404;
+        res.end("not-found");
+        return;
+      }
+      setTimeout(() => {
+        res.statusCode = 200;
+        res.setHeader("Accept-Ranges", "bytes");
+        res.setHeader("Content-Length", String(binary.length));
+        res.end(binary);
+      }, 260);
+    });
+
+    server.listen(0, "127.0.0.1");
+    await once(server, "listening");
+
+    const address = server.address();
+    if (!address || typeof address === "string") {
+      throw new Error("server address unavailable");
+    }
+    const directUrl = `http://127.0.0.1:${address.port}/same`;
+
+    globalThis.fetch = async (input: RequestInfo | URL, init?: RequestInit): Promise<Response> => {
+      const url = typeof input === "string" ? input : input instanceof URL ? input.toString() : input.url;
+      if (url.includes("/unrestrict/link")) {
+        return new Response(
+          JSON.stringify({
+            download: directUrl,
+            filename: "same-release.mkv",
+            filesize: binary.length
+          }),
+          {
+            status: 200,
+            headers: { "Content-Type": "application/json" }
+          }
+        );
+      }
+      return originalFetch(input, init);
+    };
+
+    try {
+      const manager = new DownloadManager(
+        {
+          ...defaultSettings(),
+          token: "rd-token",
+          outputDir: path.join(root, "downloads"),
+          extractDir: path.join(root, "extract"),
+          autoExtract: false,
+          maxParallel: 2
+        },
+        emptySession(),
+        createStoragePaths(path.join(root, "state"))
+      );
+
+      manager.addPackages([{ name: "same-name", links: ["https://dummy/first", "https://dummy/second"] }]);
+      manager.start();
+      await waitFor(() => !manager.getSnapshot().session.running, 25000);
+
+      const items = Object.values(manager.getSnapshot().session.items);
+      expect(items).toHaveLength(2);
+      expect(items.every((item) => item.status === "completed")).toBe(true);
+      const targetPaths = items.map((item) => item.targetPath);
+      expect(new Set(targetPaths).size).toBe(2);
+      for (const targetPath of targetPaths) {
+        expect(fs.existsSync(targetPath)).toBe(true);
+      }
+    } finally {
+      server.close();
+      await once(server, "close");
+    }
+  });
+
+  it("reuses stored partial target path when queued item resumes", async () => {
+    const root = fs.mkdtempSync(path.join(os.tmpdir(), "rd-dm-"));
+    tempDirs.push(root);
+    const binary = Buffer.alloc(256 * 1024, 7);
+    const partialSize = 64 * 1024;
+    const pkgDir = path.join(root, "downloads", "resume");
+    fs.mkdirSync(pkgDir, { recursive: true });
+    const existingTargetPath = path.join(pkgDir, "resume.mkv");
+    fs.writeFileSync(existingTargetPath, binary.subarray(0, partialSize));
+    let seenRangeStart = -1;
+
+    const server = http.createServer((req, res) => {
+      if ((req.url || "") !== "/resume") {
+        res.statusCode = 404;
+        res.end("not-found");
+        return;
+      }
+
+      const range = String(req.headers.range || "");
+      const match = range.match(/bytes=(\d+)-/i);
+      const start = match ? Number(match[1]) : 0;
+      seenRangeStart = start;
+      const chunk = binary.subarray(start);
+
+      if (start > 0) {
+        res.statusCode = 206;
+        res.setHeader("Content-Range", `bytes ${start}-${binary.length - 1}/${binary.length}`);
+      } else {
+        res.statusCode = 200;
+      }
+      res.setHeader("Accept-Ranges", "bytes");
+      res.setHeader("Content-Length", String(chunk.length));
+      res.end(chunk);
+    });
+
+    server.listen(0, "127.0.0.1");
+    await once(server, "listening");
+
+    const address = server.address();
+    if (!address || typeof address === "string") {
+      throw new Error("server address unavailable");
+    }
+    const directUrl = `http://127.0.0.1:${address.port}/resume`;
+
+    globalThis.fetch = async (input: RequestInfo | URL, init?: RequestInit): Promise<Response> => {
+      const url = typeof input === "string" ? input : input instanceof URL ? input.toString() : input.url;
+      if (url.includes("/unrestrict/link")) {
+        return new Response(
+          JSON.stringify({
+            download: directUrl,
+            filename: "resume.mkv",
+            filesize: binary.length
+          }),
+          {
+            status: 200,
+            headers: { "Content-Type": "application/json" }
+          }
+        );
+      }
+      return originalFetch(input, init);
+    };
+
+    try {
+      const session = emptySession();
+      const packageId = "resume-pkg";
+      const itemId = "resume-item";
+      const createdAt = Date.now() - 10_000;
+
+      session.packageOrder = [packageId];
+      session.packages[packageId] = {
+        id: packageId,
+        name: "resume",
+        outputDir: pkgDir,
+        extractDir: path.join(root, "extract", "resume"),
+        status: "queued",
+        itemIds: [itemId],
+        cancelled: false,
+        createdAt,
+        updatedAt: createdAt
+      };
+      session.items[itemId] = {
+        id: itemId,
+        packageId,
+        url: "https://dummy/resume",
+        provider: null,
+        status: "queued",
+        retries: 0,
+        speedBps: 0,
+        downloadedBytes: partialSize,
+        totalBytes: binary.length,
+        progressPercent: Math.floor((partialSize / binary.length) * 100),
+        fileName: "resume.mkv",
+        targetPath: existingTargetPath,
+        resumable: true,
+        attempts: 0,
+        lastError: "",
+        fullStatus: "Wartet",
+        createdAt,
+        updatedAt: createdAt
+      };
+
+      const manager = new DownloadManager(
+        {
+          ...defaultSettings(),
+          token: "rd-token",
+          outputDir: path.join(root, "downloads"),
+          extractDir: path.join(root, "extract"),
+          autoExtract: false
+        },
+        session,
+        createStoragePaths(path.join(root, "state"))
+      );
+
+      manager.start();
+      await waitFor(() => !manager.getSnapshot().session.running, 25000);
+
+      const item = manager.getSnapshot().session.items[itemId];
+      expect(item?.status).toBe("completed");
+      expect(item?.targetPath).toBe(existingTargetPath);
+      expect(seenRangeStart).toBe(partialSize);
+      expect(fs.statSync(existingTargetPath).size).toBe(binary.length);
+    } finally {
+      server.close();
+      await once(server, "close");
+    }
+  });
+
+  it("treats HTTP 416 on full range as completed resume", async () => {
+    const root = fs.mkdtempSync(path.join(os.tmpdir(), "rd-dm-"));
+    tempDirs.push(root);
+    const binary = Buffer.alloc(128 * 1024, 2);
+    const pkgDir = path.join(root, "downloads", "range-complete");
+    fs.mkdirSync(pkgDir, { recursive: true });
+    const existingTargetPath = path.join(pkgDir, "complete.mkv");
+    fs.writeFileSync(existingTargetPath, binary);
+    let saw416 = false;
+
+    const server = http.createServer((req, res) => {
+      if ((req.url || "") !== "/complete") {
+        res.statusCode = 404;
+        res.end("not-found");
+        return;
+      }
+      const range = String(req.headers.range || "");
+      const match = range.match(/bytes=(\d+)-/i);
+      const start = match ? Number(match[1]) : 0;
+      if (start >= binary.length) {
+        saw416 = true;
+        res.statusCode = 416;
+        res.setHeader("Content-Range", `bytes */${binary.length}`);
+        res.end("");
+        return;
+      }
+
+      const chunk = binary.subarray(start);
+      if (start > 0) {
+        res.statusCode = 206;
+        res.setHeader("Content-Range", `bytes ${start}-${binary.length - 1}/${binary.length}`);
+      } else {
+        res.statusCode = 200;
+      }
+      res.setHeader("Accept-Ranges", "bytes");
+      res.setHeader("Content-Length", String(chunk.length));
+      res.end(chunk);
+    });
+
+    server.listen(0, "127.0.0.1");
+    await once(server, "listening");
+
+    const address = server.address();
+    if (!address || typeof address === "string") {
+      throw new Error("server address unavailable");
+    }
+    const directUrl = `http://127.0.0.1:${address.port}/complete`;
+
+    globalThis.fetch = async (input: RequestInfo | URL, init?: RequestInit): Promise<Response> => {
+      const url = typeof input === "string" ? input : input instanceof URL ? input.toString() : input.url;
+      if (url.includes("/unrestrict/link")) {
+        return new Response(
+          JSON.stringify({
+            download: directUrl,
+            filename: "complete.mkv",
+            filesize: binary.length
+          }),
+          {
+            status: 200,
+            headers: { "Content-Type": "application/json" }
+          }
+        );
+      }
+      return originalFetch(input, init);
+    };
+
+    try {
+      const session = emptySession();
+      const packageId = "complete-pkg";
+      const itemId = "complete-item";
+      const createdAt = Date.now() - 10_000;
+
+      session.packageOrder = [packageId];
+      session.packages[packageId] = {
+        id: packageId,
+        name: "range-complete",
+        outputDir: pkgDir,
+        extractDir: path.join(root, "extract", "range-complete"),
+        status: "queued",
+        itemIds: [itemId],
+        cancelled: false,
+        createdAt,
+        updatedAt: createdAt
+      };
+      session.items[itemId] = {
+        id: itemId,
+        packageId,
+        url: "https://dummy/complete",
+        provider: null,
+        status: "queued",
+        retries: 0,
+        speedBps: 0,
+        downloadedBytes: binary.length,
+        totalBytes: binary.length,
+        progressPercent: 100,
+        fileName: "complete.mkv",
+        targetPath: existingTargetPath,
+        resumable: true,
+        attempts: 0,
+        lastError: "",
+        fullStatus: "Wartet",
+        createdAt,
+        updatedAt: createdAt
+      };
+
+      const manager = new DownloadManager(
+        {
+          ...defaultSettings(),
+          token: "rd-token",
+          outputDir: path.join(root, "downloads"),
+          extractDir: path.join(root, "extract"),
+          autoExtract: false
+        },
+        session,
+        createStoragePaths(path.join(root, "state"))
+      );
+
+      manager.start();
+      await waitFor(() => !manager.getSnapshot().session.running, 25000);
+
+      const item = manager.getSnapshot().session.items[itemId];
+      expect(saw416).toBe(true);
+      expect(item?.status).toBe("completed");
+      expect(item?.targetPath).toBe(existingTargetPath);
+      expect(item?.downloadedBytes).toBe(binary.length);
+      expect(fs.statSync(existingTargetPath).size).toBe(binary.length);
+    } finally {
+      server.close();
+      await once(server, "close");
+    }
+  });
+
+  it("normalizes stale running state on startup", () => {
+    const root = fs.mkdtempSync(path.join(os.tmpdir(), "rd-dm-"));
+    tempDirs.push(root);
+
+    const session = emptySession();
+    session.running = true;
+    session.paused = true;
+    session.reconnectUntil = Date.now() + 30_000;
+    session.reconnectReason = "HTTP 429";
+    const packageId = "stale-pkg";
+    const itemId = "stale-item";
+    const createdAt = Date.now() - 20_000;
+    session.packageOrder = [packageId];
+    session.packages[packageId] = {
+      id: packageId,
+      name: "stale",
+      outputDir: path.join(root, "downloads", "stale"),
+      extractDir: path.join(root, "extract", "stale"),
+      status: "reconnect_wait",
+      itemIds: [itemId],
+      cancelled: false,
+      createdAt,
+      updatedAt: createdAt
+    };
+    session.items[itemId] = {
+      id: itemId,
+      packageId,
+      url: "https://dummy/stale",
+      provider: "realdebrid",
+      status: "paused",
+      retries: 0,
+      speedBps: 100,
+      downloadedBytes: 123,
+      totalBytes: 456,
+      progressPercent: 26,
+      fileName: "stale.mkv",
+      targetPath: path.join(root, "downloads", "stale", "stale.mkv"),
+      resumable: true,
+      attempts: 1,
+      lastError: "",
+      fullStatus: "Pausiert",
+      createdAt,
+      updatedAt: createdAt
+    };
+
+    const manager = new DownloadManager(
+      {
+        ...defaultSettings(),
+        token: "rd-token",
+        outputDir: path.join(root, "downloads"),
+        extractDir: path.join(root, "extract"),
+        autoExtract: false
+      },
+      session,
+      createStoragePaths(path.join(root, "state"))
+    );
+
+    const snapshot = manager.getSnapshot();
+    expect(snapshot.session.running).toBe(false);
+    expect(snapshot.session.paused).toBe(false);
+    expect(snapshot.session.reconnectUntil).toBe(0);
+    expect(snapshot.session.reconnectReason).toBe("");
+    expect(snapshot.session.items[itemId]?.status).toBe("queued");
+    expect(snapshot.session.items[itemId]?.speedBps).toBe(0);
+    expect(snapshot.session.packages[packageId]?.status).toBe("queued");
+    expect(snapshot.canStart).toBe(true);
+  });
+
+  it("resets run counters and reconnect state on start", async () => {
+    const root = fs.mkdtempSync(path.join(os.tmpdir(), "rd-dm-"));
+    tempDirs.push(root);
+
+    const session = emptySession();
+    session.runStartedAt = Date.now() - 3600 * 1000;
+    session.totalDownloadedBytes = 9_999_999;
+    session.reconnectUntil = Date.now() + 120000;
+    session.reconnectReason = "HTTP 503";
+
+    const manager = new DownloadManager(
+      {
+        ...defaultSettings(),
+        token: "rd-token",
+        outputDir: path.join(root, "downloads"),
+        extractDir: path.join(root, "extract"),
+        autoExtract: false
+      },
+      session,
+      createStoragePaths(path.join(root, "state"))
+    );
+
+    manager.start();
+    await waitFor(() => !manager.getSnapshot().session.running, 5000);
+
+    const snapshot = manager.getSnapshot();
+    const summary = manager.getSummary();
+    expect(snapshot.session.totalDownloadedBytes).toBe(0);
+    expect(snapshot.session.reconnectUntil).toBe(0);
+    expect(snapshot.session.reconnectReason).toBe("");
+    expect(summary).toBeNull();
+  });
+
+  it("does not start a run when queue is empty", async () => {
+    const root = fs.mkdtempSync(path.join(os.tmpdir(), "rd-dm-"));
+    tempDirs.push(root);
+
+    const manager = new DownloadManager(
+      {
+        ...defaultSettings(),
+        token: "rd-token",
+        outputDir: path.join(root, "downloads"),
+        extractDir: path.join(root, "extract"),
+        autoExtract: false
+      },
+      emptySession(),
+      createStoragePaths(path.join(root, "state"))
+    );
+
+    manager.start();
+    await new Promise((resolve) => setTimeout(resolve, 80));
+
+    const snapshot = manager.getSnapshot();
+    expect(snapshot.session.running).toBe(false);
+    expect(manager.getSummary()).toBeNull();
+  });
+
+  it("calculates ETA from current run items only", async () => {
+    const root = fs.mkdtempSync(path.join(os.tmpdir(), "rd-dm-"));
+    tempDirs.push(root);
+    const binary = Buffer.alloc(128 * 1024, 4);
+
+    const server = http.createServer((req, res) => {
+      if ((req.url || "") !== "/slow-eta") {
+        res.statusCode = 404;
+        res.end("not-found");
+        return;
+      }
+      res.statusCode = 200;
+      res.setHeader("Accept-Ranges", "bytes");
+      res.setHeader("Content-Length", String(binary.length));
+      const half = Math.floor(binary.length / 2);
+      res.write(binary.subarray(0, half));
+      setTimeout(() => {
+        res.end(binary.subarray(half));
+      }, 700);
+    });
+
+    server.listen(0, "127.0.0.1");
+    await once(server, "listening");
+
+    const address = server.address();
+    if (!address || typeof address === "string") {
+      throw new Error("server address unavailable");
+    }
+    const directUrl = `http://127.0.0.1:${address.port}/slow-eta`;
+
+    globalThis.fetch = async (input: RequestInfo | URL, init?: RequestInit): Promise<Response> => {
+      const url = typeof input === "string" ? input : input instanceof URL ? input.toString() : input.url;
+      if (url.includes("/unrestrict/link")) {
+        return new Response(
+          JSON.stringify({
+            download: directUrl,
+            filename: "new-episode.mkv",
+            filesize: binary.length
+          }),
+          {
+            status: 200,
+            headers: { "Content-Type": "application/json" }
+          }
+        );
+      }
+      return originalFetch(input, init);
+    };
+
+    try {
+      const session = emptySession();
+      const oldPkgId = "old-pkg";
+      const oldItemId = "old-item";
+      const oldNow = Date.now() - 5000;
+      session.packageOrder = [oldPkgId];
+      session.packages[oldPkgId] = {
+        id: oldPkgId,
+        name: "old",
+        outputDir: path.join(root, "downloads", "old"),
+        extractDir: path.join(root, "extract", "old"),
+        status: "completed",
+        itemIds: [oldItemId],
+        cancelled: false,
+        createdAt: oldNow,
+        updatedAt: oldNow
+      };
+      session.items[oldItemId] = {
+        id: oldItemId,
+        packageId: oldPkgId,
+        url: "https://dummy/old",
+        provider: "realdebrid",
+        status: "completed",
+        retries: 0,
+        speedBps: 0,
+        downloadedBytes: 100,
+        totalBytes: 100,
+        progressPercent: 100,
+        fileName: "old.bin",
+        targetPath: path.join(root, "downloads", "old", "old.bin"),
+        resumable: true,
+        attempts: 1,
+        lastError: "",
+        fullStatus: "done",
+        createdAt: oldNow,
+        updatedAt: oldNow
+      };
+
+      const manager = new DownloadManager(
+        {
+          ...defaultSettings(),
+          token: "rd-token",
+          outputDir: path.join(root, "downloads"),
+          extractDir: path.join(root, "extract"),
+          autoExtract: false
+        },
+        session,
+        createStoragePaths(path.join(root, "state"))
+      );
+
+      manager.addPackages([{ name: "new", links: ["https://dummy/new"] }]);
+      manager.start();
+      await new Promise((resolve) => setTimeout(resolve, 120));
+
+      const runningSnapshot = manager.getSnapshot();
+      expect(runningSnapshot.session.running).toBe(true);
+      expect(runningSnapshot.etaText).toBe("ETA: --");
+
+      await waitFor(() => !manager.getSnapshot().session.running, 25000);
+    } finally {
+      server.close();
+      await once(server, "close");
+    }
+  });
+
+  it("keeps accurate summary when completed items are cleaned immediately", async () => {
+    const root = fs.mkdtempSync(path.join(os.tmpdir(), "rd-dm-"));
+    tempDirs.push(root);
+    const binary = Buffer.alloc(128 * 1024, 3);
+
+    const server = http.createServer((req, res) => {
+      if ((req.url || "") !== "/file") {
+        res.statusCode = 404;
+        res.end("not-found");
+        return;
+      }
+      res.statusCode = 200;
+      res.setHeader("Accept-Ranges", "bytes");
+      res.setHeader("Content-Length", String(binary.length));
+      res.end(binary);
+    });
+
+    server.listen(0, "127.0.0.1");
+    await once(server, "listening");
+
+    const address = server.address();
+    if (!address || typeof address === "string") {
+      throw new Error("server address unavailable");
+    }
+    const directUrl = `http://127.0.0.1:${address.port}/file`;
+
+    globalThis.fetch = async (input: RequestInfo | URL, init?: RequestInit): Promise<Response> => {
+      const url = typeof input === "string" ? input : input instanceof URL ? input.toString() : input.url;
+      if (url.includes("/unrestrict/link")) {
+        return new Response(
+          JSON.stringify({
+            download: directUrl,
+            filename: "episode.mkv",
+            filesize: binary.length
+          }),
+          {
+            status: 200,
+            headers: { "Content-Type": "application/json" }
+          }
+        );
+      }
+      return originalFetch(input, init);
+    };
+
+    try {
+      const manager = new DownloadManager(
+        {
+          ...defaultSettings(),
+          token: "rd-token",
+          outputDir: path.join(root, "downloads"),
+          extractDir: path.join(root, "extract"),
+          autoExtract: false,
+          completedCleanupPolicy: "immediate"
+        },
+        emptySession(),
+        createStoragePaths(path.join(root, "state"))
+      );
+
+      manager.addPackages([{ name: "cleanup", links: ["https://dummy/cleanup"] }]);
+      manager.start();
+      await waitFor(() => !manager.getSnapshot().session.running, 25000);
+
+      const snapshot = manager.getSnapshot();
+      const summary = manager.getSummary();
+      expect(Object.keys(snapshot.session.items)).toHaveLength(0);
+      expect(summary).not.toBeNull();
+      expect(summary?.total).toBe(1);
+      expect(summary?.success).toBe(1);
+      expect(summary?.failed).toBe(0);
+      expect(summary?.cancelled).toBe(0);
+    } finally {
+      server.close();
+      await once(server, "close");
+    }
+  });
+
+  it("counts queued package cancellations in run summary", async () => {
+    const root = fs.mkdtempSync(path.join(os.tmpdir(), "rd-dm-"));
+    tempDirs.push(root);
+    const binary = Buffer.alloc(256 * 1024, 5);
+
+    const server = http.createServer((req, res) => {
+      if ((req.url || "") !== "/slow") {
+        res.statusCode = 404;
+        res.end("not-found");
+        return;
+      }
+      res.statusCode = 200;
+      res.setHeader("Accept-Ranges", "bytes");
+      res.setHeader("Content-Length", String(binary.length));
+      const mid = Math.floor(binary.length / 2);
+      res.write(binary.subarray(0, mid));
+      setTimeout(() => {
+        res.end(binary.subarray(mid));
+      }, 600);
+    });
+
+    server.listen(0, "127.0.0.1");
+    await once(server, "listening");
+
+    const address = server.address();
+    if (!address || typeof address === "string") {
+      throw new Error("server address unavailable");
+    }
+    const directUrl = `http://127.0.0.1:${address.port}/slow`;
+
+    globalThis.fetch = async (input: RequestInfo | URL, init?: RequestInit): Promise<Response> => {
+      const url = typeof input === "string" ? input : input instanceof URL ? input.toString() : input.url;
+      if (url.includes("/unrestrict/link")) {
+        return new Response(
+          JSON.stringify({
+            download: directUrl,
+            filename: "episode.mkv",
+            filesize: binary.length
+          }),
+          {
+            status: 200,
+            headers: { "Content-Type": "application/json" }
+          }
+        );
+      }
+      return originalFetch(input, init);
+    };
+
+    try {
+      const manager = new DownloadManager(
+        {
+          ...defaultSettings(),
+          token: "rd-token",
+          outputDir: path.join(root, "downloads"),
+          extractDir: path.join(root, "extract"),
+          autoExtract: false,
+          maxParallel: 1
+        },
+        emptySession(),
+        createStoragePaths(path.join(root, "state"))
+      );
+
+      manager.addPackages([{ name: "cancel-run", links: ["https://dummy/one", "https://dummy/two"] }]);
+      manager.start();
+      await new Promise((resolve) => setTimeout(resolve, 120));
+      const pkgId = manager.getSnapshot().session.packageOrder[0];
+      manager.cancelPackage(pkgId);
+      await waitFor(() => !manager.getSnapshot().session.running, 25000);
+
+      const summary = manager.getSummary();
+      expect(summary).not.toBeNull();
+      expect(summary?.total).toBe(2);
+      expect(summary?.cancelled).toBe(2);
+      expect(summary?.success).toBe(0);
+      expect(summary?.failed).toBe(0);
+    } finally {
+      server.close();
+      await once(server, "close");
+    }
+  });
+});

tests/extractor.test.ts

@@ -0,0 +1,99 @@
+import fs from "node:fs";
+import os from "node:os";
+import path from "node:path";
+import AdmZip from "adm-zip";
+import { afterEach, describe, expect, it } from "vitest";
+import { buildExternalExtractArgs, extractPackageArchives } from "../src/main/extractor";
+
+const tempDirs: string[] = [];
+
+afterEach(() => {
+  for (const dir of tempDirs.splice(0)) {
+    fs.rmSync(dir, { recursive: true, force: true });
+  }
+});
+
+describe("extractor", () => {
+  it("maps external extractor args by conflict mode", () => {
+    expect(buildExternalExtractArgs("7z", "archive.rar", "C:\\target", "overwrite")).toEqual([
+      "x",
+      "-y",
+      "-aoa",
+      "archive.rar",
+      "-oC:\\target"
+    ]);
+    expect(buildExternalExtractArgs("7z", "archive.rar", "C:\\target", "ask")).toEqual([
+      "x",
+      "-y",
+      "-aos",
+      "archive.rar",
+      "-oC:\\target"
+    ]);
+
+    const unrarRename = buildExternalExtractArgs("unrar", "archive.rar", "C:\\target", "rename");
+    expect(unrarRename[0]).toBe("x");
+    expect(unrarRename[1]).toBe("-or");
+    expect(unrarRename[2]).toBe("archive.rar");
+  });
+
+  it("deletes only successfully extracted archives", async () => {
+    const root = fs.mkdtempSync(path.join(os.tmpdir(), "rd-extract-"));
+    tempDirs.push(root);
+    const packageDir = path.join(root, "pkg");
+    const targetDir = path.join(root, "out");
+    fs.mkdirSync(packageDir, { recursive: true });
+
+    const validZipPath = path.join(packageDir, "ok.zip");
+    const invalidZipPath = path.join(packageDir, "bad.zip");
+
+    const zip = new AdmZip();
+    zip.addFile("release.txt", Buffer.from("ok"));
+    zip.writeZip(validZipPath);
+    fs.writeFileSync(invalidZipPath, "not-a-zip", "utf8");
+
+    const result = await extractPackageArchives({
+      packageDir,
+      targetDir,
+      cleanupMode: "delete",
+      conflictMode: "overwrite",
+      removeLinks: false,
+      removeSamples: false
+    });
+
+    expect(result.extracted).toBe(1);
+    expect(result.failed).toBe(1);
+    expect(fs.existsSync(validZipPath)).toBe(false);
+    expect(fs.existsSync(invalidZipPath)).toBe(true);
+    expect(fs.existsSync(path.join(targetDir, "release.txt"))).toBe(true);
+  });
+
+  it("treats ask conflict mode as skip in zip extraction", async () => {
+    const root = fs.mkdtempSync(path.join(os.tmpdir(), "rd-extract-"));
+    tempDirs.push(root);
+    const packageDir = path.join(root, "pkg");
+    const targetDir = path.join(root, "out");
+    fs.mkdirSync(packageDir, { recursive: true });
+    fs.mkdirSync(targetDir, { recursive: true });
+
+    const zipPath = path.join(packageDir, "conflict.zip");
+    const zip = new AdmZip();
+    zip.addFile("same.txt", Buffer.from("new"));
+    zip.writeZip(zipPath);
+
+    const existingPath = path.join(targetDir, "same.txt");
+    fs.writeFileSync(existingPath, "old", "utf8");
+
+    const result = await extractPackageArchives({
+      packageDir,
+      targetDir,
+      cleanupMode: "none",
+      conflictMode: "ask",
+      removeLinks: false,
+      removeSamples: false
+    });
+
+    expect(result.extracted).toBe(1);
+    expect(result.failed).toBe(0);
+    expect(fs.readFileSync(existingPath, "utf8")).toBe("old");
+  });
+});

tests/storage.test.ts

@@ -0,0 +1,127 @@
+import fs from "node:fs";
+import os from "node:os";
+import path from "node:path";
+import { afterEach, describe, expect, it } from "vitest";
+import { AppSettings } from "../src/shared/types";
+import { defaultSettings } from "../src/main/constants";
+import { createStoragePaths, loadSettings, normalizeSettings, saveSettings } from "../src/main/storage";
+
+const tempDirs: string[] = [];
+
+afterEach(() => {
+  for (const dir of tempDirs.splice(0)) {
+    fs.rmSync(dir, { recursive: true, force: true });
+  }
+});
+
+describe("settings storage", () => {
+  it("does not persist provider credentials when rememberToken is disabled", () => {
+    const dir = fs.mkdtempSync(path.join(os.tmpdir(), "rd-store-"));
+    tempDirs.push(dir);
+    const paths = createStoragePaths(dir);
+
+    saveSettings(paths, {
+      ...defaultSettings(),
+      rememberToken: false,
+      token: "rd-token",
+      megaLogin: "mega-user",
+      megaPassword: "mega-pass",
+      bestToken: "best-token",
+      allDebridToken: "all-token"
+    });
+
+    const raw = JSON.parse(fs.readFileSync(paths.configFile, "utf8")) as Record<string, unknown>;
+    expect(raw.token).toBe("");
+    expect(raw.megaLogin).toBe("");
+    expect(raw.megaPassword).toBe("");
+    expect(raw.bestToken).toBe("");
+    expect(raw.allDebridToken).toBe("");
+
+    const loaded = loadSettings(paths);
+    expect(loaded.rememberToken).toBe(false);
+    expect(loaded.token).toBe("");
+    expect(loaded.megaLogin).toBe("");
+    expect(loaded.megaPassword).toBe("");
+    expect(loaded.bestToken).toBe("");
+    expect(loaded.allDebridToken).toBe("");
+  });
+
+  it("persists provider credentials when rememberToken is enabled", () => {
+    const dir = fs.mkdtempSync(path.join(os.tmpdir(), "rd-store-"));
+    tempDirs.push(dir);
+    const paths = createStoragePaths(dir);
+
+    saveSettings(paths, {
+      ...defaultSettings(),
+      rememberToken: true,
+      token: "rd-token",
+      megaLogin: "mega-user",
+      megaPassword: "mega-pass",
+      bestToken: "best-token",
+      allDebridToken: "all-token"
+    });
+
+    const loaded = loadSettings(paths);
+    expect(loaded.token).toBe("rd-token");
+    expect(loaded.megaLogin).toBe("mega-user");
+    expect(loaded.megaPassword).toBe("mega-pass");
+    expect(loaded.bestToken).toBe("best-token");
+    expect(loaded.allDebridToken).toBe("all-token");
+  });
+
+  it("normalizes invalid enum and numeric values", () => {
+    const normalized = normalizeSettings({
+      ...defaultSettings(),
+      providerPrimary: "invalid-provider" as unknown as AppSettings["providerPrimary"],
+      cleanupMode: "broken" as unknown as AppSettings["cleanupMode"],
+      extractConflictMode: "broken" as unknown as AppSettings["extractConflictMode"],
+      completedCleanupPolicy: "broken" as unknown as AppSettings["completedCleanupPolicy"],
+      speedLimitMode: "broken" as unknown as AppSettings["speedLimitMode"],
+      maxParallel: 0,
+      reconnectWaitSeconds: 9999,
+      speedLimitKbps: -1,
+      outputDir: "   ",
+      extractDir: "   ",
+      updateRepo: "   "
+    });
+
+    expect(normalized.providerPrimary).toBe("realdebrid");
+    expect(normalized.cleanupMode).toBe("none");
+    expect(normalized.extractConflictMode).toBe("overwrite");
+    expect(normalized.completedCleanupPolicy).toBe("never");
+    expect(normalized.speedLimitMode).toBe("global");
+    expect(normalized.maxParallel).toBe(1);
+    expect(normalized.reconnectWaitSeconds).toBe(600);
+    expect(normalized.speedLimitKbps).toBe(0);
+    expect(normalized.outputDir).toBe(defaultSettings().outputDir);
+    expect(normalized.extractDir).toBe(defaultSettings().extractDir);
+    expect(normalized.updateRepo).toBe(defaultSettings().updateRepo);
+  });
+
+  it("normalizes malformed persisted config on load", () => {
+    const dir = fs.mkdtempSync(path.join(os.tmpdir(), "rd-store-"));
+    tempDirs.push(dir);
+    const paths = createStoragePaths(dir);
+
+    fs.writeFileSync(
+      paths.configFile,
+      JSON.stringify({
+        providerPrimary: "not-valid",
+        completedCleanupPolicy: "not-valid",
+        maxParallel: "999",
+        reconnectWaitSeconds: "1",
+        speedLimitMode: "not-valid",
+        updateRepo: ""
+      }),
+      "utf8"
+    );
+
+    const loaded = loadSettings(paths);
+    expect(loaded.providerPrimary).toBe("realdebrid");
+    expect(loaded.completedCleanupPolicy).toBe("never");
+    expect(loaded.maxParallel).toBe(50);
+    expect(loaded.reconnectWaitSeconds).toBe(10);
+    expect(loaded.speedLimitMode).toBe("global");
+    expect(loaded.updateRepo).toBe(defaultSettings().updateRepo);
+  });
+});

tests/update.test.ts

@@ -0,0 +1,73 @@
+import { afterEach, describe, expect, it, vi } from "vitest";
+import { checkGitHubUpdate, normalizeUpdateRepo } from "../src/main/update";
+import { APP_VERSION } from "../src/main/constants";
+
+const originalFetch = globalThis.fetch;
+
+afterEach(() => {
+  globalThis.fetch = originalFetch;
+  vi.restoreAllMocks();
+});
+
+describe("update", () => {
+  it("normalizes update repo input", () => {
+    expect(normalizeUpdateRepo("")).toBe("Sucukdeluxe/real-debrid-downloader");
+    expect(normalizeUpdateRepo("owner/repo")).toBe("owner/repo");
+    expect(normalizeUpdateRepo("https://github.com/owner/repo")).toBe("owner/repo");
+    expect(normalizeUpdateRepo("https://www.github.com/owner/repo")).toBe("owner/repo");
+    expect(normalizeUpdateRepo("https://github.com/owner/repo/releases/tag/v1.2.3")).toBe("owner/repo");
+    expect(normalizeUpdateRepo("github.com/owner/repo.git")).toBe("owner/repo");
+    expect(normalizeUpdateRepo("git@github.com:owner/repo.git")).toBe("owner/repo");
+  });
+
+  it("uses normalized repo slug for GitHub API requests", async () => {
+    let requestedUrl = "";
+    globalThis.fetch = (async (input: RequestInfo | URL): Promise<Response> => {
+      requestedUrl = typeof input === "string" ? input : input instanceof URL ? input.toString() : input.url;
+      return new Response(
+        JSON.stringify({
+          tag_name: `v${APP_VERSION}`,
+          html_url: "https://github.com/owner/repo/releases/tag/v1.0.0",
+          assets: []
+        }),
+        {
+          status: 200,
+          headers: { "Content-Type": "application/json" }
+        }
+      );
+    }) as typeof fetch;
+
+    const result = await checkGitHubUpdate("https://github.com/owner/repo/releases");
+    expect(requestedUrl).toBe("https://api.github.com/repos/owner/repo/releases/latest");
+    expect(result.currentVersion).toBe(APP_VERSION);
+    expect(result.latestVersion).toBe(APP_VERSION);
+    expect(result.updateAvailable).toBe(false);
+  });
+
+  it("picks setup executable asset from release list", async () => {
+    globalThis.fetch = (async (): Promise<Response> => new Response(
+      JSON.stringify({
+        tag_name: "v9.9.9",
+        html_url: "https://github.com/owner/repo/releases/tag/v9.9.9",
+        assets: [
+          {
+            name: "Real-Debrid-Downloader 9.9.9.exe",
+            browser_download_url: "https://example.invalid/portable.exe"
+          },
+          {
+            name: "Real-Debrid-Downloader Setup 9.9.9.exe",
+            browser_download_url: "https://example.invalid/setup.exe"
+          }
+        ]
+      }),
+      {
+        status: 200,
+        headers: { "Content-Type": "application/json" }
+      }
+    )) as typeof fetch;
+
+    const result = await checkGitHubUpdate("owner/repo");
+    expect(result.updateAvailable).toBe(true);
+    expect(result.setupAssetUrl).toBe("https://example.invalid/setup.exe");
+  });
+});

tests/utils.test.ts

@@ -34,6 +34,7 @@ describe("utils", () => {
   it("normalizes filenames from links", () => {
     expect(filenameFromUrl("https://rapidgator.net/file/id/show.part1.rar.html")).toBe("show.part1.rar");
     expect(filenameFromUrl("https://debrid.example/dl/abc?filename=Movie.S01E01.mkv")).toBe("Movie.S01E01.mkv");
+    expect(filenameFromUrl("https://debrid.example/dl/%E0%A4%A")).toBe("%E0%A4%A");
     expect(filenameFromUrl("https://debrid.example/dl/e51f6809bb6ca615601f5ac5db433737")).toBe("e51f6809bb6ca615601f5ac5db433737");
     expect(looksLikeOpaqueFilename("download.bin")).toBe(true);
     expect(looksLikeOpaqueFilename("e51f6809bb6ca615601f5ac5db433737")).toBe(true);