fix: retain complete package failure telemetry
Include immediately cleaned successful files and byte aggregates when finalizing package results so mixed cleanup states remain partial instead of failed. Carry additive download, offline, extraction, remux, and cleanup failure counters alongside the prioritized display phase, aggregate them into run results, and expose cleanup failures in the final summary.
This commit is contained in:
@@ -401,6 +401,11 @@ describe("NotificationOutbox", () => {
|
||||
successfulFiles: 0,
|
||||
failedFiles: 1,
|
||||
cancelledFiles: 0,
|
||||
downloadFailures: 1,
|
||||
offlineFailures: 0,
|
||||
extractionFailures: 0,
|
||||
remuxFailures: 0,
|
||||
cleanupFailures: 0,
|
||||
archiveCount: 0,
|
||||
partCount: 0,
|
||||
outputCount: 0,
|
||||
|
||||
@@ -11,6 +11,7 @@ import {
|
||||
durationSecondsBetween,
|
||||
finalizePackageResult
|
||||
} from "../src/main/package-telemetry";
|
||||
import { buildRunResult } from "../src/main/notification-events";
|
||||
import { normalizeLoadedSession } from "../src/main/storage";
|
||||
|
||||
function packageEntry(overrides: Partial<PackageEntry> = {}): PackageEntry {
|
||||
@@ -174,6 +175,28 @@ describe("package lifecycle telemetry", () => {
|
||||
}));
|
||||
});
|
||||
|
||||
it("includes immediately cleaned successes and bytes in a mixed package result", () => {
|
||||
const failedItem = downloadItem("item-3", "failed");
|
||||
const result = finalizePackageResult(telemetry({
|
||||
package: packageEntry({
|
||||
status: "failed",
|
||||
itemIds: [failedItem.id],
|
||||
cleanedCompletedItemCount: 2,
|
||||
cleanedDownloadedBytes: 2_000,
|
||||
cleanedTotalBytes: 2_000
|
||||
}),
|
||||
items: [failedItem]
|
||||
}));
|
||||
|
||||
expect(result).toEqual(expect.objectContaining({
|
||||
status: "partial",
|
||||
successfulFiles: 2,
|
||||
failedFiles: 1,
|
||||
downloadedBytes: 2_000,
|
||||
totalBytes: 3_000
|
||||
}));
|
||||
});
|
||||
|
||||
it("classifies a failed download without error text as a download-phase failure", () => {
|
||||
const item = { ...downloadItem("item-1", "failed"), lastError: "", fullStatus: "" };
|
||||
const result = finalizePackageResult(telemetry({
|
||||
@@ -319,6 +342,39 @@ describe("package lifecycle telemetry", () => {
|
||||
]);
|
||||
});
|
||||
|
||||
it("retains additive failure counters when cleanup is the primary failure phase", () => {
|
||||
const failedItem = { ...downloadItem("item-1", "failed"), lastError: "Host ist offline" };
|
||||
const packageResult = finalizePackageResult(telemetry({
|
||||
items: [failedItem],
|
||||
archiveOperations: [archiveOperation({ status: "failed", errorCategory: "archive-error" })],
|
||||
remuxOperations: [remuxOperation({ status: "failed", errorCategory: "remux-error" })],
|
||||
cleanupErrorCategory: "cleanup-error"
|
||||
}));
|
||||
const runResult = buildRunResult({
|
||||
id: "mixed-failures",
|
||||
stopped: false,
|
||||
startedAt: 1_000,
|
||||
completedAt: 166_000,
|
||||
packages: [packageResult]
|
||||
});
|
||||
|
||||
expect(packageResult).toEqual(expect.objectContaining({
|
||||
failurePhase: "cleanup",
|
||||
downloadFailures: 1,
|
||||
offlineFailures: 1,
|
||||
extractionFailures: 1,
|
||||
remuxFailures: 1,
|
||||
cleanupFailures: 1
|
||||
}));
|
||||
expect(runResult).toEqual(expect.objectContaining({
|
||||
downloadFailures: 1,
|
||||
offlineFailures: 1,
|
||||
extractionFailures: 1,
|
||||
remuxFailures: 1,
|
||||
cleanupFailures: 1
|
||||
}));
|
||||
});
|
||||
|
||||
it("uses audio-strip outcomes when no individual remux operation was recorded", () => {
|
||||
const items = [downloadItem("item-1"), downloadItem("item-2")];
|
||||
const result = finalizePackageResult(telemetry({
|
||||
|
||||
Reference in New Issue
Block a user