From ffc0f918ac863f0e4ac18e8ef747547510979bd4 Mon Sep 17 00:00:00 2001 From: Sucukdeluxe Date: Tue, 25 Aug 2026 05:58:15 +0200 Subject: [PATCH] fix(accounts): isolate checkbox double clicks --- src/renderer/views/settings/AccountWorkspace.tsx | 7 ++++--- tests/settings-view.test.tsx | 2 ++ 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/src/renderer/views/settings/AccountWorkspace.tsx b/src/renderer/views/settings/AccountWorkspace.tsx index acdeb28..2f74473 100644 --- a/src/renderer/views/settings/AccountWorkspace.tsx +++ b/src/renderer/views/settings/AccountWorkspace.tsx @@ -360,10 +360,11 @@ function AccountRow({ actions.onToggleEnabled(row.id, event.target.checked)} - onClick={(event) => event.stopPropagation()} - type="checkbox" + onClick={(event) => event.stopPropagation()} + onDoubleClick={(event) => event.stopPropagation()} + type="checkbox" /> diff --git a/tests/settings-view.test.tsx b/tests/settings-view.test.tsx index e809250..089d85e 100644 --- a/tests/settings-view.test.tsx +++ b/tests/settings-view.test.tsx @@ -1063,6 +1063,7 @@ describe("account workspace", () => { row.props.onKeyDown({ key: "Enter", target: row, currentTarget: row, preventDefault: () => {} }); row.props.onKeyDown({ key: " ", target: checkbox, currentTarget: row, preventDefault: () => {} }); checkbox.props.onChange({ target: { checked: false } }); + checkbox.props.onDoubleClick({ stopPropagation: () => calls.push("checkbox-double-click-stopped") }); row.props.onDoubleClick(); actionButton.props.onClick({ stopPropagation: () => {}, currentTarget: { getBoundingClientRect: () => ({ right: 20, bottom: 30 }) } }); actionButton.props.onDoubleClick({ stopPropagation: () => calls.push("action-double-click-stopped") }); @@ -1072,6 +1073,7 @@ describe("account workspace", () => { `select:${rowId}:true`, `select:${rowId}:false`, `toggle:${rowId}:false`, + "checkbox-double-click-stopped", `edit:${rowId}`, `context:${rowId}`, "action-double-click-stopped"