Sucukdeluxe
b5854a2227
Route account selection clearing through the existing window-level Escape handler so it works regardless of which account surface owns focus. Preserve text editing and open overlay behavior, and remove the misleading focus-dependent workspace handler.
80 lines
3.8 KiB
TypeScript
80 lines
3.8 KiB
TypeScript
import { describe, expect, it } from "vitest";
|
|
import { pruneSelection, shouldClearDownloadSelection, shouldClearDownloadSelectionOnEscape } from "../src/renderer/selection";
|
|
import * as selection from "../src/renderer/selection";
|
|
import type { SessionState } from "../src/shared/types";
|
|
|
|
function session(packageIds: string[], itemIds: string[]): Pick<SessionState, "packages" | "items"> {
|
|
const packages: Record<string, never> = {};
|
|
const items: Record<string, never> = {};
|
|
for (const id of packageIds) packages[id] = {} as never;
|
|
for (const id of itemIds) items[id] = {} as never;
|
|
return { packages, items };
|
|
}
|
|
|
|
describe("pruneSelection", () => {
|
|
it("drops ids whose package/item no longer exists", () => {
|
|
const sel = new Set(["p1", "i1", "ghost-p", "ghost-i"]);
|
|
const next = pruneSelection(sel, session(["p1"], ["i1"]));
|
|
expect([...next].sort()).toEqual(["i1", "p1"]);
|
|
});
|
|
|
|
it("returns the SAME set instance when nothing changed (no needless re-render)", () => {
|
|
const sel = new Set(["p1", "i1"]);
|
|
const next = pruneSelection(sel, session(["p1"], ["i1"]));
|
|
expect(next).toBe(sel);
|
|
});
|
|
|
|
it("returns the same instance for an empty selection", () => {
|
|
const sel = new Set<string>();
|
|
expect(pruneSelection(sel, session(["p1"], ["i1"]))).toBe(sel);
|
|
});
|
|
|
|
it("prunes everything when the whole session was swapped out", () => {
|
|
const sel = new Set(["p1", "i1"]);
|
|
const next = pruneSelection(sel, session([], []));
|
|
expect(next.size).toBe(0);
|
|
expect(next).not.toBe(sel);
|
|
});
|
|
|
|
it("keeps a mixed package+item selection when both survive", () => {
|
|
const sel = new Set(["p1", "p2", "i1"]);
|
|
const next = pruneSelection(sel, session(["p1", "p2"], ["i1", "i2"]));
|
|
expect([...next].sort()).toEqual(["i1", "p1", "p2"]);
|
|
expect(next).toBe(sel); // unchanged → same instance
|
|
});
|
|
});
|
|
|
|
describe("download selection clearing", () => {
|
|
const target = (...classes: string[]): Pick<Element, "closest"> => ({
|
|
closest: (selector: string) => selector.split(",").some((entry: string) => classes.includes(entry.trim().slice(1))) ? {} as Element : null
|
|
});
|
|
|
|
it("preserves selection while header, package and file selection controls handle their own click", () => {
|
|
expect(shouldClearDownloadSelection(target("downloads-selection-cell"))).toBe(false);
|
|
expect(shouldClearDownloadSelection(target("downloads-package-card"))).toBe(false);
|
|
expect(shouldClearDownloadSelection(target("downloads-item-row"))).toBe(false);
|
|
expect(shouldClearDownloadSelection(target("unrelated-surface"))).toBe(true);
|
|
});
|
|
|
|
it("clears checkbox-focused selection on Escape but preserves text editing", () => {
|
|
expect(shouldClearDownloadSelectionOnEscape("INPUT", "checkbox")).toBe(true);
|
|
expect(shouldClearDownloadSelectionOnEscape("DIV")).toBe(true);
|
|
expect(shouldClearDownloadSelectionOnEscape("INPUT", "text")).toBe(false);
|
|
expect(shouldClearDownloadSelectionOnEscape("TEXTAREA")).toBe(false);
|
|
});
|
|
});
|
|
|
|
describe("global Escape selection routing", () => {
|
|
it("routes Escape to the account selection even when focus is outside the account workspace", () => {
|
|
const api = selection as typeof selection & {
|
|
resolveEscapeSelectionScope?: (view: string, settingsSection: string, tagName: string, inputType?: string) => string | null;
|
|
};
|
|
|
|
expect(api.resolveEscapeSelectionScope).toBeTypeOf("function");
|
|
expect(api.resolveEscapeSelectionScope?.("settings", "accounts", "BODY")).toBe("accounts");
|
|
expect(api.resolveEscapeSelectionScope?.("settings", "accounts", "INPUT", "text")).toBeNull();
|
|
expect(api.resolveEscapeSelectionScope?.("downloads", "allgemein", "DIV")).toBe("downloads");
|
|
expect(api.resolveEscapeSelectionScope?.("history", "accounts", "DIV")).toBe("history");
|
|
});
|
|
});
|