Harden upload lifecycle and renderer recovery

Serialize upload starts across durable audit work, drain in-flight batch additions before cleanup, and fail closed when recovery persistence is incomplete. Wire bounded renderer reload recovery with a branded localized failure surface and use merge-safe fallback log persistence.
This commit is contained in:
Sucukdeluxe
2026-08-13 21:11:48 +02:00
parent 4c48044a95
commit 3ced148ee8
7 changed files with 252 additions and 82 deletions
+57
View File
@@ -0,0 +1,57 @@
const test = require('node:test');
const assert = require('node:assert/strict');
const fs = require('node:fs');
const path = require('node:path');
const { createUploadStartReservation } = require('../lib/upload-start-reservation');
test('only one upload start can hold the reservation across asynchronous work', () => {
const reservation = createUploadStartReservation();
const first = reservation.acquire();
assert.ok(first);
assert.equal(reservation.isActive(), true);
assert.equal(reservation.acquire(), null);
first.release();
const second = reservation.acquire();
assert.ok(second);
assert.notStrictEqual(second, first);
});
test('cancelling a reserved start is visible until its owner releases it', () => {
const reservation = createUploadStartReservation();
const lease = reservation.acquire();
assert.equal(reservation.cancel(), true);
assert.equal(lease.isCancelled(), true);
assert.equal(reservation.acquire(), null);
lease.release();
assert.equal(reservation.isActive(), false);
assert.equal(reservation.cancel(), false);
});
test('stale and repeated releases cannot clear a newer reservation', () => {
const reservation = createUploadStartReservation();
const first = reservation.acquire();
first.release();
const second = reservation.acquire();
first.release();
assert.equal(reservation.isActive(), true);
assert.equal(reservation.acquire(), null);
second.release();
assert.equal(reservation.isActive(), false);
});
test('main process reserves starts before audit and exposes cancellation during the wait', () => {
const source = fs.readFileSync(path.join(__dirname, '..', 'main.js'), 'utf8');
const start = source.slice(
source.indexOf("ipcMain.handle('start-upload'"),
source.indexOf("ipcMain.handle('cancel-selected-jobs'")
);
assert.ok(start.indexOf('uploadStartReservation.acquire()') < start.indexOf('appendUploadPlanAudit(batchPlan'));
assert.match(start, /executeReservedUploadStart\(payload, startLease\)\.finally\(\(\) => startLease\.release\(\)\)/);
assert.match(start, /uploadStartReservation\.cancel\(\)/);
assert.match(source, /createSettingsImportGate\(\(\) => !!uploadManager \|\| uploadStartReservation\.isActive\(\)\)/);
});