Administrator/Multi-Hoster-Upload
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 207 Wiki Activity

fix: queue table not updating during uploads (virtual scrolling bug)

Browse Source 
The in-place update path for virtual scrolling would silently skip the
full DOM rebuild when row IDs didn't match due to sort order changes.
The break statement only exited the for-loop but return still fired,
preventing any update. Now tracks allMatch flag and falls through to
innerHTML rebuild when needed.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
Administrator 2026-03-12 05:25:22 +01:00
parent 261463bbe5
commit 3d8979797c
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
renderer/app.js
View File

@ -850,12 +850,13 @@ function _renderVirtualRows(tbody) {
if (startIdx === _lastVisibleRange.start && endIdx === _lastVisibleRange.end) { if (startIdx === _lastVisibleRange.start && endIdx === _lastVisibleRange.end) {
const rows = tbody.querySelectorAll('.queue-row'); const rows = tbody.querySelectorAll('.queue-row');
if (rows.length === endIdx - startIdx) { if (rows.length === endIdx - startIdx) {
let allMatch = true;
for (let i = 0; i < rows.length; i++) { for (let i = 0; i < rows.length; i++) {
const job = _sortedJobsCache[startIdx + i]; const job = _sortedJobsCache[startIdx + i];
if (rows[i].dataset.jobId !== job.id) { break; } // identity mismatch, full rebuild below if (rows[i].dataset.jobId !== job.id) { allMatch = false; break; }
_updateRowInPlace(rows[i], job); _updateRowInPlace(rows[i], job);
} }
return; if (allMatch) return; // all rows updated in-place, no rebuild needed
} }
} }
_lastVisibleRange = { start: startIdx, end: endIdx }; _lastVisibleRange = { start: startIdx, end: endIdx };