Administrator/Multi-Hoster-Upload
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 205 Wiki Activity

perf: use cached Intl.Collator for all sort operations

Browse Source 
Replaces inline localeCompare() calls with a shared Intl.Collator
instance across queue, recent files, and history sorting. Eliminates
~12,000 Collator object allocations per sort on large queues.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
Administrator 2026-03-12 05:18:06 +01:00
parent 3d8e81560c
commit c79f61b4b5
1 changed files with 10 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
renderer/app.js
View File

@ -880,15 +880,18 @@ function _onQueueScroll() {
} }
} }
const _collatorDE = new Intl.Collator('de', { sensitivity: 'base', numeric: true });
const _collatorSimple = new Intl.Collator('de');
function sortQueueJobs(jobs) { function sortQueueJobs(jobs) {
const { key, direction } = queueSortState; const { key, direction } = queueSortState;
const factor = direction === 'asc' ? 1 : -1; const factor = direction === 'asc' ? 1 : -1;
return jobs.slice().sort((a, b) => { return jobs.slice().sort((a, b) => {
let cmp = 0; let cmp = 0;
if (key === 'filename') cmp = a.fileName.localeCompare(b.fileName, 'de', { sensitivity: 'base', numeric: true }); if (key === 'filename') cmp = _collatorDE.compare(a.fileName, b.fileName);
else if (key === 'size') cmp = (a.bytesTotal || 0) - (b.bytesTotal || 0); else if (key === 'size') cmp = (a.bytesTotal || 0) - (b.bytesTotal || 0);
else if (key === 'host') cmp = a.hoster.localeCompare(b.hoster); else if (key === 'host') cmp = _collatorSimple.compare(a.hoster, b.hoster);
else if (key === 'status') cmp = getStatusOrder(a.status) - getStatusOrder(b.status); else if (key === 'status') cmp = getStatusOrder(a.status) - getStatusOrder(b.status);
else if (key === 'speed') cmp = (a.speedKbs || 0) - (b.speedKbs || 0); else if (key === 'speed') cmp = (a.speedKbs || 0) - (b.speedKbs || 0);
else if (key === 'progress') cmp = (a.progress || 0) - (b.progress || 0); else if (key === 'progress') cmp = (a.progress || 0) - (b.progress || 0);
@ -2653,9 +2656,9 @@ function sortRecentFiles(data) {
const dir = direction === 'asc' ? 1 : -1; const dir = direction === 'asc' ? 1 : -1;
sorted.sort((a, b) => { sorted.sort((a, b) => {
if (key === 'date') return dir * ((a.dateTs - b.dateTs) || (a.order - b.order)); if (key === 'date') return dir * ((a.dateTs - b.dateTs) || (a.order - b.order));
if (key === 'filename') return dir * a.filename.localeCompare(b.filename, 'de', { sensitivity: 'base' }); if (key === 'filename') return dir * _collatorDE.compare(a.filename, b.filename);
if (key === 'host') return dir * a.host.localeCompare(b.host, 'de', { sensitivity: 'base' }); if (key === 'host') return dir * _collatorDE.compare(a.host, b.host);
if (key === 'link') return dir * a.link.localeCompare(b.link, 'de', { sensitivity: 'base' }); if (key === 'link') return dir * _collatorDE.compare(a.link, b.link);
return 0; return 0;
}); });
return sorted; return sorted;
@ -2783,7 +2786,7 @@ function sortHistoryRows(rows) {
const { key, direction } = historySortState; const { key, direction } = historySortState;
const factor = direction === 'asc' ? 1 : -1; const factor = direction === 'asc' ? 1 : -1;
return rows.slice().sort((a, b) => { return rows.slice().sort((a, b) => {
let cmp = key === 'date' ? a.dateTs - b.dateTs : String(a[key] || '').localeCompare(String(b[key] || ''), 'de', { sensitivity: 'base', numeric: true }); let cmp = key === 'date' ? a.dateTs - b.dateTs : _collatorDE.compare(String(a[key] || ''), String(b[key] || ''));
return (cmp || a.order - b.order) * factor; return (cmp || a.order - b.order) * factor;
}); });
} }
@ -2916,6 +2919,7 @@ function setupListeners() {
const key = th.dataset.sort; const key = th.dataset.sort;
if (queueSortState.key === key) queueSortState.direction = queueSortState.direction === 'asc' ? 'desc' : 'asc'; if (queueSortState.key === key) queueSortState.direction = queueSortState.direction === 'asc' ? 'desc' : 'asc';
else { queueSortState.key = key; queueSortState.direction = 'asc'; } else { queueSortState.key = key; queueSortState.direction = 'asc'; }
_lastVisibleRange = { start: -1, end: -1 }; // force full rebuild after re-sort
renderQueueTable(); renderQueueTable();
}); });
}); });