Administrator/Multi-Hoster-Upload
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 47 Wiki Activity

release: restore v2.1.19 baseline for v2.1.24
CI / verify (push) Has been cancelled
Details

Browse Source 
Restore the v2.1.19 application baseline and retain only the focused import preflight summary with duplicate, unavailable, destination, job, and size-limit visibility.
This commit is contained in:
Sucukdeluxe
2026-08-17 04:25:22 +02:00
parent 9a213a7395
commit d7c9f287e4
87 changed files with 2185 additions and 16125 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/diagnostics-agent.test.js
+2 -52
View File
@@ -1,9 +1,6 @@
const { test } = require('node:test');
const assert = require('node:assert');
const fs = require('node:fs');
const path = require('node:path');
const { createAgent } = require('../lib/diagnostics-agent');
const { valueScrub } = require('../lib/support-bundle');
function stubCollectors() {
const calls = [];
@@ -31,9 +28,6 @@ test('agent rejects unknown ops and any write/exec-shaped op', () => {
assert.equal(r.ok, false, `${bad} must be rejected`);
assert.match(r.error, /unknown or non-readonly/);
}
const pathShaped = agent.handle(['C:', 'Users', 'PrivateProfile', 'operation'].join('\\'), {});
assert.ok(!pathShaped.error.includes('PrivateProfile'));
assert.match(pathShaped.error, /<redacted-path>/);
});
test('agent rejects inherited Object.prototype members (no whitelist bypass via the prototype chain)', () => {
@@ -59,54 +53,10 @@ test('agent maps each whitelisted op to its collector and is read-only only', ()
for (const op of agent.ops) assert.ok(!/write|delete|set_|exec|restart|cancel|retry/.test(op), `${op} must be read-only`);
});
test('agent redacts collector failures and thrown errors at the response boundary', () => {
const drivePath = ['C:', 'Users', 'PrivateProfile', 'secret.log'].join('\\');
const uncPath = '\\\\?\\UNC\\private-server\\secret-share\\secret.log';
const agent = createAgent({
readLog: () => ({ ok: false, error: `cannot read ${drivePath}` }),
getSystemInfo: () => { throw new Error(`boom at ${uncPath}`); }
});
test('agent surfaces a collector ok:false verbatim and never throws', () => {
const agent = createAgent({ readLog: () => ({ ok: false, error: 'unknown or non-readable log: x' }), getSystemInfo: () => { throw new Error('boom'); } });
assert.equal(agent.handle('read_log', { name: 'x' }).ok, false);
assert.ok(!JSON.stringify(agent.handle('read_log', { name: 'x' })).includes('PrivateProfile'));
const thrown = agent.handle('get_system_info', {});
assert.equal(thrown.ok, false);
assert.match(thrown.error, /boom/);
assert.ok(!thrown.error.includes('private-server'));
assert.match(thrown.error, /<redacted-path>/);
});
test('agent redacts every successful response with configured secrets at the boundary', () => {
const secret = 'configured-secret-123';
const slashUnc = '//private-server/secret-share/secret.log';
const collectors = stubCollectors();
collectors.getSystemInfo = () => ({ nested: { message: `token ${secret}`, path: slashUnc } });
collectors.redactResponse = value => valueScrub(value, [secret]);
const result = createAgent(collectors).handle('get_system_info', {});
const json = JSON.stringify(result);
assert.equal(result.ok, true);
assert.ok(!json.includes(secret));
assert.ok(!json.includes('private-server'));
assert.match(json, /<redacted>/);
assert.match(json, /<redacted-path>/);
});
test('agent fails closed when response redaction fails', () => {
const agent = createAgent({
getSystemInfo: () => ({ token: 'must-not-leak' }),
redactResponse: () => { throw new Error('redactor unavailable'); }
});
const result = agent.handle('get_system_info', {});
assert.deepEqual(result, { ok: false, error: 'diagnostic response could not be safely returned' });
assert.ok(!JSON.stringify(result).includes('must-not-leak'));
});
test('main process keeps diagnostics local and fails closed at its final reply boundary', () => {
const source = fs.readFileSync(path.join(__dirname, '..', 'main.js'), 'utf8');
assert.match(source, /function _diagBindHost\(\)\s*{\s*return '127\.0\.0\.1'/);
assert.match(source, /function _diagPublicHost\(\)\s*{\s*return '127\.0\.0\.1'/);
assert.match(source, /function _diagAllowlist\(\)\s*{\s*return \[\]/);
assert.match(source, /bindMode: 'local'/);
assert.match(source, /catch\s*{\s*result = { ok: false, error: 'diagnostic response could not be safely returned' }/);
assert.match(source, /loadConfig:\s*\(\)\s*=>\s*configStore\.loadDiagnosticsConfig\(\)/);
assert.match(source, /loadHistory:\s*\(\)\s*=>\s*configStore\.loadDiagnosticsHistory\(\)/);
});