From e7d30edab57c99996b0b29640dd73222e3b2b4ca Mon Sep 17 00:00:00 2001 From: Sucukdeluxe <259325684+Sucukdeluxe@users.noreply.github.com> Date: Fri, 21 Aug 2026 00:25:01 +0200 Subject: [PATCH] style: increase update dialog height Give the release-notes viewport a responsive 220-pixel target height so the update dialog gains visible vertical room while remaining bounded on smaller windows. --- renderer/styles.css | 3 ++- tests/startup-renderer.test.js | 2 +- tests/ui-smoke.js | 4 ++-- 3 files changed, 5 insertions(+), 4 deletions(-) diff --git a/renderer/styles.css b/renderer/styles.css index 953505c..2fb3af7 100644 --- a/renderer/styles.css +++ b/renderer/styles.css @@ -2468,7 +2468,8 @@ select.hs-input { max-width: none; width: auto; min-width: 140px; } .update-release-notes { grid-column: 1 / -1; - max-height: 180px; + height: min(220px, 42vh); + max-height: none; margin-top: 18px; padding: 12px; overflow: auto; diff --git a/tests/startup-renderer.test.js b/tests/startup-renderer.test.js index 500c6a4..e3165bd 100644 --- a/tests/startup-renderer.test.js +++ b/tests/startup-renderer.test.js @@ -175,5 +175,5 @@ test('header occupies its final geometry before asynchronous initialization', () assert.match(css, /\.header-update-button\.update-available\s*\{[^}]*background:\s*var\(--success\);[^}]*color:\s*#000;/su); assert.match(css, /\.header-update-button\.update-available:hover\s*\{[^}]*background:\s*var\(--success-end\);[^}]*color:\s*#000;/su); assert.match(css, /\.update-dialog\s*\{[^}]*width:\s*min\(576px,\s*100%\);/su); - assert.match(css, /\.update-release-notes\s*\{[^}]*max-height:\s*180px;/su); + assert.match(css, /\.update-release-notes\s*\{[^}]*height:\s*min\(220px,\s*42vh\);/su); }); diff --git a/tests/ui-smoke.js b/tests/ui-smoke.js index 1794ea7..270c9f0 100644 --- a/tests/ui-smoke.js +++ b/tests/ui-smoke.js @@ -2449,8 +2449,8 @@ setTimeout(async () => { check('Update dialog exposes a red close action', updateCloseColor === 'rgb(255, 133, 140)'); const updateDialogChangelog = await wc.executeJavaScript('(() => { const title = document.querySelector(".update-release-notes-title"); const body = document.getElementById("updateReleaseNotesBody"); const titleRect = title?.getBoundingClientRect(); const bodyRect = body?.getBoundingClientRect(); return { hidden: document.getElementById("updateReleaseNotes")?.hidden, title: title?.textContent?.trim(), body: body?.textContent, gap: bodyRect && titleRect ? bodyRect.top - titleRect.bottom : null }; })()'); check('Update dialog renders a compact normalized changelog', updateDialogChangelog.hidden === false && updateDialogChangelog.title === 'Changelog' && updateDialogChangelog.body === 'New in this version\\n\\nMenus and navigation\\n\\n• Added live language switching.\\n• Improved settings layout.' && updateDialogChangelog.gap <= 10); - const updateDialogSize = await wc.executeJavaScript('(() => ({ width: document.querySelector(".update-dialog")?.getBoundingClientRect().width, notesMaxHeight: getComputedStyle(document.getElementById("updateReleaseNotes")).maxHeight }))()'); - check('Update dialog and changelog provide twenty percent more room', updateDialogSize.width === 576 && updateDialogSize.notesMaxHeight === '180px'); + const updateDialogSize = await wc.executeJavaScript('(() => ({ width: document.querySelector(".update-dialog")?.getBoundingClientRect().width, notesHeight: document.getElementById("updateReleaseNotes")?.getBoundingClientRect().height }))()'); + check('Update dialog and changelog provide more horizontal and vertical room', updateDialogSize.width === 576 && updateDialogSize.notesHeight === 220); const updateHeaderHint = await wc.executeJavaScript('(() => { const button = document.getElementById("headerUpdateBtn"); const tooltip = getComputedStyle(button, "::after"); return [button?.textContent?.trim(), button?.getAttribute("aria-label"), button?.dataset.tooltip, button?.hasAttribute("title"), tooltip.left, tooltip.right].join("|"); })()'); check('Available update uses one centered custom tooltip below the header action', updateHeaderHint === 'Update verfügbar|Update v9.9.9 verfügbar. Klicken zum Installieren.|Update v9.9.9 verfügbar. Klicken zum Installieren.|false|73px|auto');