29d1944328
A 13-agent hunt pinned the "wird mit der Zeit laggy" symptom (CPU/RAM normal, UI sluggish after many uploads) to the main process re-doing config I/O that scales with the ever-growing history, stalling the synchronous main event loop so the renderer's IPC round-trips feel laggy. The renderer render path was already optimized (virtualized queue, capped panels) — confirmed clean. This commit lands the two contained fixes (T1 + T3); the queue-persist rewrite (T2) follows separately. config-store (T1): - load() now has an in-memory cache keyed on the file mtime+size. The processed config (merged + credential-decrypted) is re-read/re-parsed/re-DPAPI-decrypted ONLY when the file actually changes; our writes invalidate it, external edits change mtime/size so the cache misses. Eliminates a full disk read + JSON.parse of the whole growing history + per-credential decrypt on the vast majority of the ~38 load() call sites. load() always returns a structuredClone so callers can mutate freely without corrupting the cache. - _serializeForDisk clones ONLY the hosters subtree (the only thing encryptCredentials touches) instead of JSON.parse(JSON.stringify(whole config)) — no more deep-cloning an 8 MB history on every write. - _atomicWrite refreshes the .bak with a raw fs.copyFileSync instead of read + JSON.parse + write (it was re-parsing the full config a 2nd time per write). main.js (T3): - The log-flush paths resolved the log file via configStore.load() ~8x/second during uploads (re-reading + cloning the whole config just to read logMode/logFilePath). Cache those two strings in module scope, invalidate on the settings-save handlers. Verified: 26 config-store tests (incl. new cache-correctness: independent clones, external-change invalidation, save invalidation) + full 394-test suite green, lint 0 errors. Benchmark (8000-batch / 4.6 MB history): log flush no longer calls load() at all; the remaining per-write history serialize is what T2 removes from the hot path. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
105 lines
2.9 KiB
JavaScript
105 lines
2.9 KiB
JavaScript
import security from 'eslint-plugin-security';
|
|
|
|
const sharedRules = {
|
|
// Security rules
|
|
// detect-object-injection disabled: 78 false positives from config lookups like obj[hosterName]
|
|
'security/detect-object-injection': 'off',
|
|
'security/detect-non-literal-regexp': 'warn',
|
|
'security/detect-unsafe-regex': 'warn',
|
|
'security/detect-buffer-noassert': 'warn',
|
|
'security/detect-eval-with-expression': 'error',
|
|
'security/detect-no-csrf-before-method-override': 'warn',
|
|
'security/detect-possible-timing-attacks': 'warn',
|
|
'security/detect-pseudoRandomBytes': 'warn',
|
|
// Code quality
|
|
'no-unused-vars': ['warn', { argsIgnorePattern: '^_', varsIgnorePattern: '^_' }],
|
|
'no-undef': 'error',
|
|
'no-constant-condition': 'warn',
|
|
'no-debugger': 'error',
|
|
'no-duplicate-case': 'error',
|
|
'no-empty': ['warn', { allowEmptyCatch: true }],
|
|
'no-ex-assign': 'error',
|
|
'no-extra-boolean-cast': 'warn',
|
|
'no-func-assign': 'error',
|
|
'no-inner-declarations': 'error',
|
|
'no-irregular-whitespace': 'error',
|
|
'no-unreachable': 'error',
|
|
'use-isnan': 'error',
|
|
'valid-typeof': 'error',
|
|
'eqeqeq': ['warn', 'always'],
|
|
'no-caller': 'error',
|
|
'no-eval': 'error',
|
|
'no-implied-eval': 'error',
|
|
'no-new-func': 'error',
|
|
'no-throw-literal': 'warn',
|
|
'no-self-assign': 'error',
|
|
'no-self-compare': 'error',
|
|
'no-loss-of-precision': 'error',
|
|
'no-dupe-keys': 'error',
|
|
'no-unsafe-finally': 'error',
|
|
'no-unmodified-loop-condition': 'warn',
|
|
'no-template-curly-in-string': 'warn',
|
|
};
|
|
|
|
const nodeGlobals = {
|
|
process: 'readonly',
|
|
console: 'readonly',
|
|
setTimeout: 'readonly',
|
|
clearTimeout: 'readonly',
|
|
setInterval: 'readonly',
|
|
clearInterval: 'readonly',
|
|
setImmediate: 'readonly',
|
|
Buffer: 'readonly',
|
|
URL: 'readonly',
|
|
URLSearchParams: 'readonly',
|
|
fetch: 'readonly',
|
|
crypto: 'readonly',
|
|
structuredClone: 'readonly',
|
|
};
|
|
|
|
export default [
|
|
{ ignores: ['**/node_modules/**', 'release/**', 'tests/**'] },
|
|
{
|
|
files: ['**/*.js'],
|
|
ignores: ['gateway/**'],
|
|
plugins: { security },
|
|
languageOptions: {
|
|
ecmaVersion: 2022,
|
|
sourceType: 'commonjs',
|
|
globals: {
|
|
require: 'readonly',
|
|
module: 'readonly',
|
|
exports: 'readonly',
|
|
__dirname: 'readonly',
|
|
__filename: 'readonly',
|
|
...nodeGlobals,
|
|
AbortController: 'readonly',
|
|
AbortSignal: 'readonly',
|
|
navigator: 'readonly',
|
|
document: 'readonly',
|
|
window: 'readonly',
|
|
localStorage: 'readonly',
|
|
HTMLElement: 'readonly',
|
|
alert: 'readonly',
|
|
confirm: 'readonly',
|
|
requestAnimationFrame: 'readonly',
|
|
queueMicrotask: 'readonly',
|
|
Intl: 'readonly',
|
|
EventSource: 'readonly',
|
|
}
|
|
},
|
|
rules: sharedRules
|
|
},
|
|
{
|
|
files: ['gateway/**/*.js', 'gateway/**/*.mjs'],
|
|
ignores: ['gateway/node_modules/**'],
|
|
plugins: { security },
|
|
languageOptions: {
|
|
ecmaVersion: 2022,
|
|
sourceType: 'module',
|
|
globals: nodeGlobals
|
|
},
|
|
rules: sharedRules
|
|
}
|
|
];
|