0c6c502aab
Matches the Real-Debrid-Downloader's rd-diagnostics-mcp model so the read-only
diagnostics agent is reachable over Tailscale (or any private tunnel) the same way
the downloader is, instead of requiring an SSH local-forward.
- lib/ip-allowlist.js (NEW): fail-closed IP allowlist — normalizeIp strips
::ffff:, loopback is always allowed, an empty allowlist accepts loopback ONLY
(fail-closed), exact IP + CIDR (incl. the Tailscale CGNAT range 100.64.0.0/10) +
wildcard rules. The real socket peer IP is the authority (never a forwarded header).
- remote-server.js: rejects non-allowlisted peers at connection (close 4005). Opt-in
via config.allowlist (the existing remote-control server, which passes none, is
unaffected). Loopback always passes, so local + SSH-forward use keeps working.
- Two bind modes (config diagnostics.bindMode): "local" -> 127.0.0.1 (default),
"network" -> 0.0.0.0 but ONLY when a non-empty allowlist is set (else it stays
loopback, fail-closed). The allowlist + token gate access; the tunnel
(Tailscale/WireGuard) is the confidentiality layer (transport is still plaintext ws://).
- The connection code now carries the host: mhu1_<base64url{v,h,p,t,n,fp?,s?}>. The
gateway decode is tolerant of the legacy {port,token,label} keys; connect_server
takes the host from the code (host arg is an optional override). Proven end-to-end:
the integration harness now connects with NO host arg and resolves it from the code.
- Renderer: Sichtbarkeit selector (local/network), public-host input with
suggested-host chips (os.networkInterfaces — the Tailscale IP shows up there),
allowlist textarea (network mode), and network-requires-allowlist validation.
- main.js: bindMode->host, getSuggestedRemoteHosts, host-in-code, allowlist plumbed
into startDiagnosticAgent + the diagnostics IPC (get/save/status).
- docs: rewritten for Tailscale (set the allowlist to your tailnet, put the Tailscale
IP/MagicDNS in the code address — no SSH forward needed).
This supersedes the v3.3.85 hard loopback-lock with the downloader's allowlist model.
Tests: lib/ip-allowlist (8) + remote-server allowlist wiring/loopback (2) + gateway
decode (host short-key + legacy tolerance). 393 app tests + 9 gateway tests + e2e +
host-in-code integration + adversarial all green; lint 0 errors.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
65 lines
2.2 KiB
JavaScript
65 lines
2.2 KiB
JavaScript
import { test } from 'node:test';
|
|
import assert from 'node:assert/strict';
|
|
import { encode, decode } from '../code.js';
|
|
|
|
test('decode reads the host-bearing short-key format (h/p/t/n/s/fp)', () => {
|
|
const code = encode({ v: 1, h: '100.64.0.5', p: 9110, t: 'deadbeefcafe1234', n: 'prod-3', s: 'wss', fp: 'AB:CD:EF:01' });
|
|
assert.ok(code.startsWith('mhu1_'));
|
|
const d = decode(code);
|
|
assert.equal(d.host, '100.64.0.5');
|
|
assert.equal(d.port, 9110);
|
|
assert.equal(d.token, 'deadbeefcafe1234');
|
|
assert.equal(d.label, 'prod-3');
|
|
assert.equal(d.scheme, 'wss');
|
|
assert.equal(d.fp, 'AB:CD:EF:01');
|
|
});
|
|
|
|
test('decode is tolerant of the legacy long-key format (port/token/label, no host -> ws)', () => {
|
|
const d = decode(encode({ v: 1, port: 9110, token: 'token-abc', label: 'localhost' }));
|
|
assert.equal(d.host, undefined);
|
|
assert.equal(d.port, 9110);
|
|
assert.equal(d.token, 'token-abc');
|
|
assert.equal(d.label, 'localhost');
|
|
assert.equal(d.scheme, 'ws');
|
|
});
|
|
|
|
test('decode rejects a string without the mhu1_ prefix', () => {
|
|
assert.throws(() => decode('hello-world'), /missing "mhu1_" prefix/);
|
|
});
|
|
|
|
test('decode rejects a wrong-version payload', () => {
|
|
const bad = 'mhu1_' + Buffer.from(
|
|
JSON.stringify({ v: 2, port: 9110, token: 'x', label: 'l' }),
|
|
'utf8',
|
|
).toString('base64url');
|
|
assert.throws(() => decode(bad), /unsupported version/);
|
|
});
|
|
|
|
test('decode rejects garbage after the prefix', () => {
|
|
assert.throws(() => decode('mhu1_!!!not-base64-or-json!!!'), /Invalid code/);
|
|
});
|
|
|
|
test('decode rejects an empty payload', () => {
|
|
assert.throws(() => decode('mhu1_'), /empty payload/);
|
|
});
|
|
|
|
test('decode rejects a non-string input', () => {
|
|
assert.throws(() => decode(null), /expected a string/);
|
|
});
|
|
|
|
test('decode rejects a missing token', () => {
|
|
const bad = 'mhu1_' + Buffer.from(
|
|
JSON.stringify({ v: 1, port: 9110, label: 'l' }),
|
|
'utf8',
|
|
).toString('base64url');
|
|
assert.throws(() => decode(bad), /token/);
|
|
});
|
|
|
|
test('decode rejects a non-number port', () => {
|
|
const bad = 'mhu1_' + Buffer.from(
|
|
JSON.stringify({ v: 1, port: 'nope', token: 'x', label: 'l' }),
|
|
'utf8',
|
|
).toString('base64url');
|
|
assert.throws(() => decode(bad), /port/);
|
|
});
|