Adds the connect-by-code side of remote diagnostics and closes two real secret-leak vectors that an end-to-end gateway<->agent test surfaced. Gateway (gateway/, local stdio MCP, Claude connects once): - 14 read-only tools (server_health hub, read_log, list_logs, list_errors, get_queue_state, get_history, get_config_redacted, get_system_info, get_rotation_state, get_app_events + connect/disconnect/list/current). - The HOST is always supplied by the operator, never taken from the code. - TLS fingerprint pinning is enforced in the socket 'open' handler BEFORE the token is sent (wss opt-in); plain ws is loopback-only. - registry.json (holds bearer tokens) is gitignored; only an empty example ships. Security hardening (gates every off-box payload): - redactLogText now scrubs opaque bearer/token-family secrets that are NOT stored config credentials (e.g. a session token a hoster returns inside an error string): bare token/auth_token/refresh_token/session_token + standalone "Bearer <opaque>". Benign "token bucket" prose is left intact. - get_config_redacted deep-redacts every string leaf (JSON-safe, per-leaf, so the cookie/sess line patterns can't gobble across a compact-JSON field) and drops the history subtree (served by get_history with its own per-error redaction). This plugs leaks via globalSettings.pendingQueue[].error etc. Bind-address safety: - _safeDiagBindAddress() forces the diagnostic agent to 127.0.0.1/::1; the 0.0.0.0 UI option is removed. Direct LAN/Internet bind stays disabled until encrypted transport (wss) exists — remote access goes through an SSH/VPN tunnel to loopback. (Never plaintext ws:// on all interfaces.) Tests: end-to-end gateway<->agent gate (connect -> server_health/read_log/ get_config_redacted, asserts zero secret leakage, rejects doodstream log, path traversal and write ops); + redaction regression tests in the main suite. 385 app tests + 9 gateway tests pass; lint 0 errors. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
51 lines
1.5 KiB
JavaScript
51 lines
1.5 KiB
JavaScript
import { readFile, writeFile } from 'node:fs/promises';
|
|
import { fileURLToPath } from 'node:url';
|
|
import { dirname, join } from 'node:path';
|
|
|
|
const HERE = dirname(fileURLToPath(import.meta.url));
|
|
const REGISTRY_PATH = join(HERE, 'registry.json');
|
|
|
|
export async function loadRegistry() {
|
|
try {
|
|
const raw = await readFile(REGISTRY_PATH, 'utf8');
|
|
const parsed = JSON.parse(raw);
|
|
if (!parsed || typeof parsed !== 'object' || Array.isArray(parsed)) {
|
|
return {};
|
|
}
|
|
return parsed;
|
|
} catch {
|
|
return {};
|
|
}
|
|
}
|
|
|
|
export async function saveRegistry(registry) {
|
|
const data = registry && typeof registry === 'object' ? registry : {};
|
|
await writeFile(REGISTRY_PATH, JSON.stringify(data, null, 2) + '\n', 'utf8');
|
|
}
|
|
|
|
export async function upsertEntry(entry) {
|
|
if (!entry || typeof entry.label !== 'string' || entry.label.length === 0) {
|
|
throw new Error('upsertEntry: entry.label is required');
|
|
}
|
|
const registry = await loadRegistry();
|
|
registry[entry.label] = {
|
|
host: entry.host,
|
|
port: entry.port,
|
|
token: entry.token,
|
|
fp: entry.fp,
|
|
label: entry.label,
|
|
version: entry.version,
|
|
lastConnectedAt: entry.lastConnectedAt ?? new Date().toISOString(),
|
|
};
|
|
await saveRegistry(registry);
|
|
return registry[entry.label];
|
|
}
|
|
|
|
export async function getEntry(label) {
|
|
if (typeof label !== 'string' || label.length === 0) return null;
|
|
const registry = await loadRegistry();
|
|
return registry[label] ?? null;
|
|
}
|
|
|
|
export { REGISTRY_PATH };
|