Administrator/Twitch-VOD-Manager
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 230 Wiki Activity

fix(release): preserve Windows signing defaults

Browse Source
This commit is contained in:
Sucukdeluxe
2026-08-12 02:37:39 +02:00
parent 66e84508c8
commit 661d7d9858
2 changed files with 1 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
package.json
-1
View File
@@ -82,7 +82,6 @@
"win": {
"target": "nsis",
"icon": "build/icon.ico",
"signExecutable": false,
"artifactName": "Twitch-VOD-Manager-Setup-${version}.${ext}"
},
"nsis": {
scripts/smoke-test-public-release-config.js
+1 -1
View File
@@ -33,7 +33,7 @@ check(installerSource.includes('CreateShortCut "$newStartMenuLink"'), 'start men
check(installerSource.includes('SHChangeNotify(i 0x08000000, i 0x1000'), 'Windows shell icon cache is not flushed after shortcut refresh');
check(installerSource.includes('${ifNot} ${isUpdated}') && installerSource.includes('RMDir /r "$LOCALAPPDATA\\Twitch VOD Manager\\Shortcut Icons"'), 'persistent shortcut icons are not cleaned up on a real uninstall');
check(packageJson.build?.win?.signAndEditExecutable !== false, 'Windows executable resource editing is enabled');
check(packageJson.build?.win?.signExecutable === false, 'Windows code signing remains disabled without suppressing icon resources');
check(packageJson.build?.win?.signExecutable !== false, 'Windows executable signing is disabled');
check(fs.existsSync(path.join(root, 'build', 'icon.png')), 'application PNG icon is missing');
check(fs.existsSync(path.join(root, 'build', 'icon.ico')), 'application ICO icon is missing');
check(mainSource.includes('app.setAppUserModelId(WINDOWS_APP_IDENTITY.appUserModelId)'), 'Windows AppUserModelID is not applied from the centralized identity');