Administrator/Twitch-VOD-Manager
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 212 Wiki Activity

fix: live-status poller — eviction now runs even when watch list is empty

Browse Source 
Subtle leak in runLiveStatusBatchPoll: the eviction pass (which
removes liveStatusByLogin entries for streamers no longer in
config.streamers) ran INSIDE the fetch branch — but the fetch
branch is skipped early when logins.length === 0.

Concretely: if a user had 3 streamers all marked live, then
removed all 3, the poll would early-return at length-check,
leaving stale liveStatusByLogin entries forever (until app
restart) — main-process memory + an inaccurate
get-live-status-snapshot IPC response.

Renderer wasn't visibly affected because renderStreamers only
looks up entries for streamers in the rendered list, but the
underlying state was wrong.

Restructured so the eviction pass always runs first based on the
current watch list, then the fetch + diff only runs when the list
is non-empty. Empty-list case still emits "removed -> offline"
changes to the renderer so its parallel map stays in sync.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
xRangerDE 2026-05-11 03:51:42 +02:00
parent 4518f8867a
commit 77e4c84c45
1 changed files with 18 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
src/main.ts
View File

@ -3750,26 +3750,32 @@ async function runLiveStatusBatchPoll(): Promise<void> {
const logins = ((config.streamers as string[]) || []) const logins = ((config.streamers as string[]) || [])
.map((s) => normalizeLogin(s)) .map((s) => normalizeLogin(s))
.filter((s): s is string => Boolean(s)); .filter((s): s is string => Boolean(s));
if (logins.length === 0) return;
const fresh = await fetchLiveStatusBatch(logins);
const changes: Array<{ login: string; isLive: boolean }> = []; const changes: Array<{ login: string; isLive: boolean }> = [];
const seen = new Set(fresh.keys()); const watchedSet = new Set(logins);
for (const [login, isLive] of fresh.entries()) {
const prev = liveStatusByLogin.get(login); // Always run the eviction pass FIRST — entries left over from a
if (prev !== isLive) changes.push({ login, isLive }); // streamer that's no longer in the watch list must go regardless
liveStatusByLogin.set(login, isLive); // of whether we're about to fetch fresh data. Previously this
} // ran inside the fetch branch only, so removing the last
// Streamers that vanished from the watch list (or that GQL didn't // streamer left ghost entries in liveStatusByLogin until the
// return for) get evicted so a removed streamer doesn't leave a // next add.
// ghost-live dot behind.
for (const oldLogin of Array.from(liveStatusByLogin.keys())) { for (const oldLogin of Array.from(liveStatusByLogin.keys())) {
if (!seen.has(oldLogin)) { if (!watchedSet.has(oldLogin)) {
liveStatusByLogin.delete(oldLogin); liveStatusByLogin.delete(oldLogin);
changes.push({ login: oldLogin, isLive: false }); changes.push({ login: oldLogin, isLive: false });
} }
} }
if (logins.length > 0) {
const fresh = await fetchLiveStatusBatch(logins);
for (const [login, isLive] of fresh.entries()) {
const prev = liveStatusByLogin.get(login);
if (prev !== isLive) changes.push({ login, isLive });
liveStatusByLogin.set(login, isLive);
}
}
if (mainWindow && changes.length > 0) { if (mainWindow && changes.length > 0) {
// Renderer only consumes `changes` — initial state comes via // Renderer only consumes `changes` — initial state comes via
// the get-live-status-snapshot IPC at boot. Don't ship the // the get-live-status-snapshot IPC at boot. Don't ship the