From e705beabf32c03fe0f73354a1aca296cca8db76a Mon Sep 17 00:00:00 2001 From: xRangerDE Date: Mon, 11 May 2026 05:33:47 +0200 Subject: [PATCH] cleanup: dedupe setPageTitle fallback in renderer-settings MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 4.6.77 inlined the setPageTitle global-window resolution + fallback twice — once in each branch of the "vods+streamer vs other tab" conditional. Reading two near-identical 4-line if/else stanzas back to back was harder than necessary. Collapsed the branch to a single ternary that picks the title text first, then a single setPageTitle resolve + apply block at the end. Same behavior, one resolution of the optional global. Co-Authored-By: Claude Opus 4.7 (1M context) --- src/renderer-settings.ts | 16 ++++++---------- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/src/renderer-settings.ts b/src/renderer-settings.ts index ac11970..eeb7b70 100644 --- a/src/renderer-settings.ts +++ b/src/renderer-settings.ts @@ -193,16 +193,12 @@ function changeLanguage(lang: string): void { const activeTabId = document.querySelector('.tab-content.active')?.id || 'vodsTab'; const activeTab = activeTabId.replace('Tab', ''); - if (activeTab === 'vods' && currentStreamer) { - const setTitle = (window as unknown as { setPageTitle?: (text: string) => void }).setPageTitle; - if (typeof setTitle === 'function') setTitle(currentStreamer); - else byId('pageTitle').textContent = currentStreamer; - } else { - const setTitle = (window as unknown as { setPageTitle?: (text: string) => void }).setPageTitle; - const text = (UI_TEXT.tabs as Record)[activeTab] || UI_TEXT.appName; - if (typeof setTitle === 'function') setTitle(text); - else byId('pageTitle').textContent = text; - } + const titleText = (activeTab === 'vods' && currentStreamer) + ? currentStreamer + : ((UI_TEXT.tabs as Record)[activeTab] || UI_TEXT.appName); + const setTitle = (window as unknown as { setPageTitle?: (text: string) => void }).setPageTitle; + if (typeof setTitle === 'function') setTitle(titleText); + else byId('pageTitle').textContent = titleText; void refreshRuntimeMetrics(); void refreshAutomationStatusLine();