package.json

@@ -1,6 +1,6 @@
 {
   "name": "real-debrid-downloader",
-  "version": "1.7.153",
+  "version": "1.7.152",
   "description": "Desktop downloader",
   "main": "build/main/main/main.js",
   "author": "Sucukdeluxe",

src/main/download-manager.ts

@@ -3686,16 +3686,15 @@ export class DownloadManager extends EventEmitter {
     }
   }
 
-  /** Move matching SUBTITLE companions alongside a video collected into the
-   *  library. Note: .nfo / metadata files are intentionally NOT moved — the
-   *  library should contain video + subs only. .nfo stays in the extract
-   *  dir and is removed by normal cleanup. */
+  /** Move matching subtitle / metadata companions alongside a video that
+   *  was just collected into the library. Mirrors renameCompanionFiles but
+   *  for cross-directory moves. */
   private async moveCompanionFiles(
     sourceVideoPath: string,
     targetVideoPath: string,
     pkg?: PackageEntry
   ): Promise<void> {
-    const COMPANION_EXTENSIONS = new Set([".srt", ".ass", ".ssa", ".sub", ".idx", ".vtt", ".smi"]);
+    const COMPANION_EXTENSIONS = new Set([".srt", ".ass", ".ssa", ".sub", ".idx", ".vtt", ".smi", ".nfo"]);
     const sourceDir = path.dirname(sourceVideoPath);
     const targetDir = path.dirname(targetVideoPath);
     const sourceVideoBase = path.basename(sourceVideoPath, path.extname(sourceVideoPath));
@@ -3777,18 +3776,17 @@ export class DownloadManager extends EventEmitter {
       return null;
     }
 
-    // Note: total-path length is intentionally NOT checked here. We used to
-    // cap it at 247 chars (v1.7.151) on the assumption that paths beyond
-    // Windows MAX_PATH (260) would fail or be unusable downstream. That
-    // turned out to be ACTIVELY HARMFUL: renamePathWithExdevFallback wraps
-    // every rename via toWindowsLongPathIfNeeded (\\?\ prefix), and the
-    // file ends up in the library dir after mkv-move where the parent path
-    // is short. Imposing a 247-char cap on the EXTRACT-dir intermediate
-    // path threw away perfectly-good scene-release names like
-    // "Dr.House.S04E02.Der.Stoff.aus.dem.die.Heldin.ist.GERMAN.5.1.DL.AC3.720p.BDRiP.x264-TvR.mkv"
-    // and replaced them with ugly "Dr.House.S04E02.mkv" via fallback.
-    // We rely on the long-path prefix for the rename and on the 255-char
-    // NTFS file-name limit above for the actual constraint.
+    // Windows MAX_PATH is 260 chars without the \\?\ long-path prefix.
+    // The actual rename via renamePathWithExdevFallback ALWAYS wraps with
+    // toWindowsLongPathIfNeeded, so paths up to ~32K technically work, but
+    // many downstream consumers (Explorer, MediaPlayers, scripts) struggle
+    // beyond ~248. Use a conservative 247-char limit so the renamed file
+    // remains usable. Caller will fall back to buildShortPackageFallback
+    // when this returns null.
+    const SAFE_TOTAL_PATH_CHARS = 247;
+    if (candidatePath.length > SAFE_TOTAL_PATH_CHARS) {
+      return null;
+    }
 
     return candidatePath;
   }

tests/download-manager.test.ts

@@ -10540,54 +10540,6 @@ describe("download manager", () => {
     expect(fs.existsSync(path.join(sharedDir, "EpisodeFolder", "obfus.mkv"))).toBe(true);
   });
 
-  it("mkv-move moves SUBTITLES to library but NOT .nfo metadata files", async () => {
-    const root = fs.mkdtempSync(path.join(os.tmpdir(), "rd-mvcompanion-"));
-    tempDirs.push(root);
-    const extractDir = path.join(root, "extract");
-    const libDir = path.join(root, "library");
-    fs.mkdirSync(extractDir, { recursive: true });
-    fs.mkdirSync(libDir, { recursive: true });
-    const epFolder = path.join(extractDir, "Show.S01E01.GERMAN.x264-GROUP");
-    fs.mkdirSync(epFolder, { recursive: true });
-    fs.writeFileSync(path.join(epFolder, "Show.S01E01.GERMAN.x264-GROUP.mkv"), Buffer.alloc(1024, 0));
-    fs.writeFileSync(path.join(epFolder, "Show.S01E01.GERMAN.x264-GROUP.srt"), "subs");
-    fs.writeFileSync(path.join(epFolder, "Show.S01E01.GERMAN.x264-GROUP.nfo"), "info");
-
-    const manager = new DownloadManager(
-      {
-        ...defaultSettings(),
-        token: "rd-token",
-        outputDir: path.join(root, "out"),
-        extractDir,
-        autoExtract: true,
-        collectMkvToLibrary: true,
-        mkvLibraryDir: libDir
-      },
-      emptySession(),
-      createStoragePaths(path.join(root, "state"))
-    );
-    const pkg: any = {
-      id: "movecomp-pkg",
-      name: "Show.S01.GERMAN.x264-GROUP",
-      outputDir: path.join(root, "out", "Show"),
-      extractDir,
-      status: "completed", itemIds: [], cancelled: false, enabled: true, priority: "normal",
-      createdAt: 0, updatedAt: 0, downloadStartedAt: 0, downloadCompletedAt: 0
-    };
-
-    await (manager as any).collectMkvFilesToLibrary("movecomp-pkg", pkg);
-
-    const libFiles = fs.readdirSync(libDir);
-    // Video AND subtitle moved to library.
-    expect(libFiles).toContain("Show.S01E01.GERMAN.x264-GROUP.mkv");
-    expect(libFiles).toContain("Show.S01E01.GERMAN.x264-GROUP.srt");
-    // .nfo MUST NOT end up in the library — that's the user-visible bug
-    // we are fixing. (It gets cleaned up with other residual files in
-    // cleanupNonMkvResidualFiles after the move; we don't care whether it
-    // survives in the extract dir, only that the library stays clean.)
-    expect(libFiles).not.toContain("Show.S01E01.GERMAN.x264-GROUP.nfo");
-  });
-
   it("auto-rename also renames matching subtitle / .nfo companion files", async () => {
     const root = fs.mkdtempSync(path.join(os.tmpdir(), "rd-companion-"));
     tempDirs.push(root);